From: Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE>
To: bug-gnu-emacs@gnu.org
Cc: 1899-reopen@emacsbugs.donarmstrong.com, cyd@stupidchicken.com
Subject: bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart)
Date: Thu, 15 Jan 2009 09:44:29 +0100 () [thread overview]
Message-ID: <ud4epvtzm.fsf@WDFD00185931A.sap.corp> (raw)
In-Reply-To: <mailman.4868.1231967014.26697.bug-gnu-emacs@gnu.org>
Chong Yidong <cyd@stupidchicken.com> wrote:
>> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el)
>> is not prepared for the case that the parameter localpart could be
>> nil: (regexp-quote nil) is an error. This is especially problematic
>> since the corresponding function for setting cookies,
>> url-cookie-store, defines the parameter localpart as optional.
>
> I've checked in a fix. Thanks.
Your fix changed the "string-match" to "equal" while keeping the
"regexp-quote". This will not work for all cases where "localpart" is
not empty.
I am afraid that this mail might not be the right way to reopen the bug.
I apologize for any inconvenience this might cause.
--
Klaus Straubinger
prev parent reply other threads:[~2009-01-15 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fxjlvcl7.fsf@cyd.mit.edu>
2009-01-14 12:43 ` bug#1899: url-cookie-retrieve is not prepared for missing localpart Klaus Straubinger
2009-01-14 20:55 ` bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart) Emacs bug Tracking System
[not found] ` <mailman.4868.1231967014.26697.bug-gnu-emacs@gnu.org>
2009-01-15 8:44 ` Klaus Straubinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ud4epvtzm.fsf@WDFD00185931A.sap.corp \
--to=ksnetz@usenet.arcornews.de \
--cc=1899-reopen@emacsbugs.donarmstrong.com \
--cc=1899@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.