From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: process-attributes patch Date: Tue, 03 Feb 2009 21:50:08 +0200 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1233690989 30922 80.91.229.12 (3 Feb 2009 19:56:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Feb 2009 19:56:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 03 20:57:43 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUROm-0004Y2-On for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2009 20:57:33 +0100 Original-Received: from localhost ([127.0.0.1]:49275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LURNU-0002cT-53 for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2009 14:56:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LURHc-0008F0-HB for emacs-devel@gnu.org; Tue, 03 Feb 2009 14:50:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LURHb-0008Dp-AB for emacs-devel@gnu.org; Tue, 03 Feb 2009 14:50:08 -0500 Original-Received: from [199.232.76.173] (port=49598 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LURHb-0008Dk-6i for emacs-devel@gnu.org; Tue, 03 Feb 2009 14:50:07 -0500 Original-Received: from mtaout6.012.net.il ([84.95.2.16]:51500) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LURHX-00066G-SA; Tue, 03 Feb 2009 14:50:04 -0500 Original-Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KEI001009EVES00@i-mtaout6.012.net.il>; Tue, 03 Feb 2009 21:50:25 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.228.158.130]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KEI007T89S0TJ90@i-mtaout6.012.net.il>; Tue, 03 Feb 2009 21:50:25 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108701 Archived-At: > From: Miles Bader > Date: Tue, 03 Feb 2009 19:13:00 +0900 > > (2) Add a "process_pid" function in process.c that contains the > process->pid mapping code which used to be in Fsignal_process. > process_pid also accepts straight process-ids. How many copies of this function did you add to process.c? It looks like you added only one, while I think you need 2: one each for the #ifdef subprocess branch and the #else branch. > (4) Rename Fsystem_process_attributes to Fprocess_attributes, and have > it call process_pid to convert a process object to a pid. These are already documented in the ELisp reference manual, so the docs need to be updated as well.