From: Eli Zaretskii <eliz@gnu.org>
To: Miles Bader <miles@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: process-attributes patch
Date: Tue, 03 Feb 2009 21:50:08 +0200 [thread overview]
Message-ID: <ud4dzuwpb.fsf@gnu.org> (raw)
In-Reply-To: <buoskmvhlqr.fsf@dhlpc061.dev.necel.com>
> From: Miles Bader <miles@gnu.org>
> Date: Tue, 03 Feb 2009 19:13:00 +0900
>
> (2) Add a "process_pid" function in process.c that contains the
> process->pid mapping code which used to be in Fsignal_process.
> process_pid also accepts straight process-ids.
How many copies of this function did you add to process.c? It looks
like you added only one, while I think you need 2: one each for the
#ifdef subprocess branch and the #else branch.
> (4) Rename Fsystem_process_attributes to Fprocess_attributes, and have
> it call process_pid to convert a process object to a pid.
These are already documented in the ELisp reference manual, so the
docs need to be updated as well.
next prev parent reply other threads:[~2009-02-03 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 10:13 process-attributes patch Miles Bader
2009-02-03 19:50 ` Eli Zaretskii [this message]
2009-02-03 21:05 ` Stefan Monnier
2009-02-03 22:34 ` Miles Bader
2009-02-04 4:11 ` Eli Zaretskii
2009-02-04 6:39 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ud4dzuwpb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.