From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Out-of-date completions for `read-buffer'
Date: Sat, 02 Sep 2006 14:23:37 +0300 [thread overview]
Message-ID: <ubqpywlza.fsf@gnu.org> (raw)
In-Reply-To: <41563.128.165.123.18.1156796747.squirrel@webmail.lanl.gov> (herring@lanl.gov)
> Date: Mon, 28 Aug 2006 13:25:47 -0700 (PDT)
> From: "Stuart D. Herring" <herring@lanl.gov>
>
> > Your patch is clean, but we should call the new function
> > internal-complete-buffer so that people won't complain that it isn't
> > documented it in the Lisp Manual.
> >
> > Would someone (Eli?) please install the patch, with that change?
>
> Not to harass, but this hasn't happened in ten days, so I thought I'd
> re-raise it. The patch's message is at
> http://lists.gnu.org/archive/html/emacs-devel/2006-08/msg00574.html.
Installed.
Your original patch didn't compile:
minibuf.c: In function `Fread_buffer':
minibuf.c:1218: error: incompatible type for argument 2 of `Fcompleting_read'
make[1]: *** [minibuf.o] Error 1
I fixed that by using `intern ("internal-complete-buffer")' instead of
`Sinternal_complete_buffer'. I also expanded the doc string to
explain the arguments.
Thanks.
prev parent reply other threads:[~2006-09-02 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 20:55 Out-of-date completions for `read-buffer' Stuart D. Herring
2006-08-17 15:18 ` Richard Stallman
2006-08-17 19:51 ` Stuart D. Herring
2006-08-18 15:46 ` Richard Stallman
2006-08-28 20:25 ` Stuart D. Herring
2006-08-30 10:38 ` Eli Zaretskii
2006-08-30 15:43 ` Stuart D. Herring
2006-08-30 17:03 ` Eli Zaretskii
2006-08-30 17:12 ` Stuart D. Herring
2006-09-02 11:23 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ubqpywlza.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.