From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: shell-command - missing shell-quote-argument for program?
Date: Sat, 14 Oct 2006 16:02:35 +0200 [thread overview]
Message-ID: <ubqofro5g.fsf@gnu.org> (raw)
In-Reply-To: <45251C56.8010603@student.lu.se> (message from Lennart Borgman on Thu, 05 Oct 2006 16:53:10 +0200)
> Date: Thu, 05 Oct 2006 16:53:10 +0200
> From: Lennart Borgman <lennart.borgman.073@student.lu.se>
>
> Lennart Borgman wrote:
> > In some places the program to run from `shell-command' is not quoted
> > by `shell-quote-argument'. Examples are the calls in emerge.el.
> >
> > Should not the program name be quoted by `shell-quote-argment' when it
> > is possible?
If we quote emerge-command and the various emerge-*-program, we in
effect disallow them to be shell commands with switches. Is that
reasonable? If it is, then we should quote the programs.
Note that emerge-protect-metachars assumes a Posix shell, so it will
break on Windows with cmdproxy if the file names include whitespace.
> And I should have mentioned `shell-command-to-string' to of course. More
> examples of probably missing shell quotings are in
>
> - filesets.el
> - defcustom explicit-bash-args
I think this indeed needs quoting.
> - python-after-info-look: python-command
But python.el seems to limit this to no whitespace, no? If so,
there's no need to quote.
> - flymake-get-project-include-dirs-imp: basedir should perhaps be quoted?
Probably.
> - ada-find-in-src-path
Yes, but this isn't trivial, since it concats the directory with a
wildcard.
> - ido-wide-find-dirs-or-files: several examples of missing quoting
Was fixed since you wrote this, right?
> - locate.el: locate-update-command shoue perhaps be quoted? (But
> probably not, since it may include more than the program name. Bad
> structure?)
I don't think it should be quoted automatically, for the reasons you
mentioned.
> - fortune.el
Yes.
> - org.el
Maybe, I'm not sure I understand the semantics there.
> - reftex-create-tags-file in reftex-global.el
This was already taken care of.
next prev parent reply other threads:[~2006-10-14 14:02 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 14:34 shell-command - missing shell-quote-argument for program? Lennart Borgman
2006-10-05 14:53 ` Lennart Borgman
2006-10-06 11:38 ` Lennart Borgman
2006-10-06 12:34 ` Andreas Schwab
2006-10-06 12:43 ` Kim F. Storm
2006-10-06 12:49 ` David Kastrup
2006-10-06 13:34 ` Kim F. Storm
2006-10-07 1:07 ` Richard Stallman
2006-10-07 13:11 ` Andreas Schwab
2006-10-08 3:30 ` Richard Stallman
2006-10-08 15:43 ` Andreas Schwab
2006-10-08 22:27 ` Richard Stallman
2006-10-08 22:36 ` Andreas Schwab
2006-10-09 20:08 ` Richard Stallman
2006-10-09 9:12 ` Kim F. Storm
2006-10-06 12:49 ` Kim F. Storm
2006-10-06 13:20 ` Lennart Borgman
2006-10-12 14:56 ` Kim F. Storm
2006-10-12 22:38 ` Richard Stallman
2006-10-13 21:26 ` Lennart Borgman
2006-10-13 23:16 ` Lennart Borgman
2006-10-14 7:13 ` Thomas Link
2006-10-13 18:13 ` Thomas Link
2006-10-13 19:55 ` Lennart Borgman
2006-10-13 21:20 ` [Bulk] " Thomas Link
2006-10-14 10:07 ` Richard Stallman
2006-10-14 14:11 ` Eli Zaretskii
[not found] ` <4526434B.9010606@student.lu.se>
[not found] ` <rzqr6xhf9l9.fsf@loveshack.ukfsn.org>
2006-10-09 22:14 ` Lennart Borgman
2006-10-10 6:46 ` Slawomir Nowaczyk
2006-10-10 7:02 ` Lennart Borgman
2006-10-12 13:52 ` Slawomir Nowaczyk
2006-10-12 14:18 ` Kim F. Storm
2006-10-15 13:50 ` Dave Love
2006-10-15 19:08 ` Lennart Borgman
2006-10-16 22:33 ` Dave Love
2006-10-16 22:37 ` Lennart Borgman
2006-10-14 14:02 ` Eli Zaretskii [this message]
2006-10-14 15:33 ` Lennart Borgman
2006-10-14 17:50 ` Andreas Schwab
2006-10-14 18:15 ` Eli Zaretskii
2006-10-15 9:30 ` Lennart Borgman
2006-10-15 20:43 ` Kim F. Storm
2006-10-14 18:22 ` Eli Zaretskii
2006-10-14 23:02 ` Kim F. Storm
2006-10-15 9:00 ` Lennart Borgman
2006-10-15 9:35 ` Lennart Borgman
2006-10-15 20:42 ` Kim F. Storm
2006-10-15 10:12 ` Richard Stallman
2006-10-15 14:14 ` Slawomir Nowaczyk
2006-10-15 10:12 ` Richard Stallman
2006-10-15 19:13 ` Lennart Borgman
2006-10-15 20:43 ` Kim F. Storm
2006-10-05 19:36 ` Stefan Monnier
2006-10-05 19:58 ` Eli Zaretskii
2006-10-05 20:21 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ubqofro5g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.