From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH/Now RFA] Console based mouse face highlighting. Date: Wed, 16 May 2007 06:24:47 +0300 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179285900 509 80.91.229.12 (16 May 2007 03:25:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 16 May 2007 03:25:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 16 05:24:58 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HoA8H-0001Uo-An for ged-emacs-devel@m.gmane.org; Wed, 16 May 2007 05:24:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoAGD-0001r4-2P for ged-emacs-devel@m.gmane.org; Tue, 15 May 2007 23:33:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HoAG9-0001qz-9E for emacs-devel@gnu.org; Tue, 15 May 2007 23:33:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HoAG6-0001qm-Tj for emacs-devel@gnu.org; Tue, 15 May 2007 23:33:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoAG6-0001qj-OE for emacs-devel@gnu.org; Tue, 15 May 2007 23:33:02 -0400 Original-Received: from heller.inter.net.il ([213.8.233.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HoA89-0007yJ-Q6 for emacs-devel@gnu.org; Tue, 15 May 2007 23:24:50 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-147-83.inter.net.il [80.230.147.83]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id CPC87141 (AUTH halo1); Wed, 16 May 2007 06:24:44 +0300 (IDT) In-reply-to: <17994.14013.614407.875104@kahikatea.snap.net.nz> (message from Nick Roberts on Wed, 16 May 2007 10:39:57 +1200) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71139 Archived-At: > From: Nick Roberts > Date: Wed, 16 May 2007 10:39:57 +1200 > Cc: emacs-devel@gnu.org > > Thanks, I've got something that seems to work now. I read your message > afterwards, so I'm afraid I think it does modify the glyph matrix and I've not > used FRAME_TERMCAP_P. Too bad. > I'm still not sure how the iterator, glyph matrix and write_glyphs > relate. The iterator is used to create the ``desired glyph matrix'', one that describes what _should_have_been_ on the screen given the current buffer contents and point position. Then the desired matrix is diffed against the current matrix (which describes what _is_ on the screen now), and finally the diffs are used to update the affected portions of the screen by calls to write_glyphs. > I would have thought if I've changed the glyph matrix I don't need > to call write_glyphs but that doesn't seem to be the case. Probably because you modify the glyph matrix where Emacs doesn't expect it to happen. term.c is supposed to access the glyph matrix in the read-only mode. I actually don't understand at all why you need to modify the glyph matrix. What are you modifying there, exactly? > Also if I call write_glyphs with different values, these would get > overwritten with those from the glyph matrix when an update is > done.) Again, because Emacs doesn't expect the glyph matrix to change at this point. > Anyway I'd like to commit these changes now. I'd be happier if you fixed the two aspects we've been talking about (not change the glyph matrix and avoid calling this code on non-tty frames. I think these are really nasty bugs. And I don't see any reason for haste here. Thanks for working on this.