From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sridhar Boovaraghavan Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50 compile problem on Windows XP Date: Thu, 04 Oct 2007 21:17:08 -0400 Message-ID: References: <47035169.8070402@gnu.org> <4703869F.6070909@gnu.org> <47038922.10105@gnu.org> <4705652C.5070803@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191547078 1891 80.91.229.12 (5 Oct 2007 01:17:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 5 Oct 2007 01:17:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 05 03:17:55 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Idbp8-0001N7-TX for ged-emacs-devel@m.gmane.org; Fri, 05 Oct 2007 03:17:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Idbp4-0005aL-0q for ged-emacs-devel@m.gmane.org; Thu, 04 Oct 2007 21:17:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Idbp0-0005aG-HO for emacs-devel@gnu.org; Thu, 04 Oct 2007 21:17:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Idboy-0005a4-4F for emacs-devel@gnu.org; Thu, 04 Oct 2007 21:17:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Idbox-0005a1-Uw for emacs-devel@gnu.org; Thu, 04 Oct 2007 21:17:39 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Idbox-0000Qf-KY for emacs-devel@gnu.org; Thu, 04 Oct 2007 21:17:39 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Idbol-0004Sw-Ns for emacs-devel@gnu.org; Fri, 05 Oct 2007 01:17:27 +0000 Original-Received: from ool-4356a48d.dyn.optonline.net ([67.86.164.141]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Oct 2007 01:17:27 +0000 Original-Received: from sridhar_ml by ool-4356a48d.dyn.optonline.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Oct 2007 01:17:27 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: ool-4356a48d.dyn.optonline.net User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (windows-nt) Cancel-Lock: sha1:mE++Gc8tuvaVsGAeEuOyfjQnl8c= X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80260 Archived-At: Jason Rumney writes: > Sridhar Boovaraghavan wrote: >> Thank you for looking into and diagnosing the problem. I have moved >> the inclusion of above "lisp.h" in the affected files and >> here's a patch against HEAD that solves this issue. >> > There are several other files that include stdlib.h after lisp.h > conditional on WINDOWSNT too. Does that not also cause the same problem? > Also msdos.c includes lisp.h before stdlib.h, so there could be a > problem there too. It doesn't seem to affect other files that an nmake bootstrap uses. > > I think it is better to remove this definition from lisp.h and include > stdlib.h in the files that need it. But perhaps there is a good reason > not to do that in the first place, so I'll wait and let others comment > on my mail from yesterday before making that change. Sounds good. -- Sridhar Boovaraghavan