From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#1853: Trouble with gzipped info files on Windows Date: Sat, 24 Jan 2009 17:34:42 +0200 Message-ID: References: Reply-To: Eli Zaretskii , 1853@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1232811915 13235 80.91.229.12 (24 Jan 2009 15:45:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Jan 2009 15:45:15 +0000 (UTC) Cc: lekktu@gmail.com, 1853@emacsbugs.donarmstrong.com, emacs-devel@gnu.org, handa@m17n.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 24 16:46:26 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LQkiI-0004Ul-EV for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jan 2009 16:46:26 +0100 Original-Received: from localhost ([127.0.0.1]:44179 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQkh0-0006yR-UK for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jan 2009 10:45:06 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQkfV-0006NX-NI for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 10:43:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQkfU-0006NA-8v for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 10:43:33 -0500 Original-Received: from [199.232.76.173] (port=56809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQkfU-0006N7-0R for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 10:43:32 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:51748) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQkfT-0005qh-AH for bug-gnu-emacs@gnu.org; Sat, 24 Jan 2009 10:43:31 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0OFhSE3026823; Sat, 24 Jan 2009 07:43:29 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0OFe3Fk025735; Sat, 24 Jan 2009 07:40:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Sat, 24 Jan 2009 15:40:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1853 X-Emacs-PR-Package: emacs,w32 X-Emacs-PR-Keywords: Original-Received: via spool by 1853-submit@emacsbugs.donarmstrong.com id=B1853.123281129224396 (code B ref 1853); Sat, 24 Jan 2009 15:40:03 +0000 Original-Received: (at 1853) by emacsbugs.donarmstrong.com; 24 Jan 2009 15:34:52 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout6.012.net.il (mtaout6.012.net.il [84.95.2.16]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0OFYmXW024390 for <1853@emacsbugs.donarmstrong.com>; Sat, 24 Jan 2009 07:34:49 -0800 Original-Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KDZ00M00ECIK500@i-mtaout6.012.net.il> for 1853@emacsbugs.donarmstrong.com; Sat, 24 Jan 2009 17:34:57 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.6.113]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KDZ003DTFA7IMH0@i-mtaout6.012.net.il>; Sat, 24 Jan 2009 17:34:57 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 24 Jan 2009 10:43:33 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24461 Archived-At: > From: Stefan Monnier > Cc: 1853@emacsbugs.donarmstrong.com, handa@m17n.org, lekktu@gmail.com, > emacs-devel@gnu.org > Date: Tue, 20 Jan 2009 00:10:04 -0500 > > > the kludge being that this only works because of the specific order > > files are loaded at dump time and the order of function invocation > > during startup. Are we okay with making non-trivial changes in that > > at this time? > > I guess it's better to make a simpler local change, and add a big fat > comment about what should be done instead. Done, with the following change: Index: lisp/international/mule-cmds.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/international/mule-cmds.el,v retrieving revision 1.353 retrieving revision 1.354 diff -u -r1.353 -r1.354 --- lisp/international/mule-cmds.el 9 Jan 2009 05:01:02 -0000 1.353 +++ lisp/international/mule-cmds.el 24 Jan 2009 15:31:09 -0000 1.354 @@ -1933,7 +1933,25 @@ "Do various coding system setups for language environment LANGUAGE-NAME." (let* ((priority (get-language-info language-name 'coding-priority)) (default-coding (car priority)) - (eol-type (coding-system-eol-type default-buffer-file-coding-system))) + ;; If default-buffer-file-coding-system is nil, don't use + ;; coding-system-eol-type, because it treats nil as + ;; `no-conversion'. default-buffer-file-coding-system is set + ;; to nil by reset-language-environment, and in that case we + ;; want to have here the native EOL type for each platform. + ;; FIXME: there should be a common code that runs both on + ;; startup and here to set the default EOL type correctly. + ;; Right now, DOS/Windows platforms set this on dos-w32.el, + ;; which works only as long as the order of loading files at + ;; dump time and calling functions at startup is not modified + ;; significantly, i.e. as long as this function is called + ;; _after_ default-buffer-file-coding-system was set by + ;; dos-w32.el. + (eol-type + (if (null default-buffer-file-coding-system) + (cond ((memq system-type '(windows-nt ms-dos)) 1) + ((eq system-type 'macos) 2) + (t 0)) + (coding-system-eol-type default-buffer-file-coding-system)))) (when priority (set-default-coding-systems (if (memq eol-type '(0 1 2 unix dos mac))