From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: lekktu@gmail.com, 1853@emacsbugs.donarmstrong.com,
emacs-devel@gnu.org, handa@m17n.org
Subject: Re: bug#1853: Trouble with gzipped info files on Windows
Date: Sat, 24 Jan 2009 17:34:42 +0200 [thread overview]
Message-ID: <ubptwu38t.fsf@gnu.org> (raw)
In-Reply-To: <jwvpriiftrm.fsf-monnier+emacsbugreports@gnu.org>
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: 1853@emacsbugs.donarmstrong.com, handa@m17n.org, lekktu@gmail.com,
> emacs-devel@gnu.org
> Date: Tue, 20 Jan 2009 00:10:04 -0500
>
> > the kludge being that this only works because of the specific order
> > files are loaded at dump time and the order of function invocation
> > during startup. Are we okay with making non-trivial changes in that
> > at this time?
>
> I guess it's better to make a simpler local change, and add a big fat
> comment about what should be done instead.
Done, with the following change:
Index: lisp/international/mule-cmds.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/international/mule-cmds.el,v
retrieving revision 1.353
retrieving revision 1.354
diff -u -r1.353 -r1.354
--- lisp/international/mule-cmds.el 9 Jan 2009 05:01:02 -0000 1.353
+++ lisp/international/mule-cmds.el 24 Jan 2009 15:31:09 -0000 1.354
@@ -1933,7 +1933,25 @@
"Do various coding system setups for language environment LANGUAGE-NAME."
(let* ((priority (get-language-info language-name 'coding-priority))
(default-coding (car priority))
- (eol-type (coding-system-eol-type default-buffer-file-coding-system)))
+ ;; If default-buffer-file-coding-system is nil, don't use
+ ;; coding-system-eol-type, because it treats nil as
+ ;; `no-conversion'. default-buffer-file-coding-system is set
+ ;; to nil by reset-language-environment, and in that case we
+ ;; want to have here the native EOL type for each platform.
+ ;; FIXME: there should be a common code that runs both on
+ ;; startup and here to set the default EOL type correctly.
+ ;; Right now, DOS/Windows platforms set this on dos-w32.el,
+ ;; which works only as long as the order of loading files at
+ ;; dump time and calling functions at startup is not modified
+ ;; significantly, i.e. as long as this function is called
+ ;; _after_ default-buffer-file-coding-system was set by
+ ;; dos-w32.el.
+ (eol-type
+ (if (null default-buffer-file-coding-system)
+ (cond ((memq system-type '(windows-nt ms-dos)) 1)
+ ((eq system-type 'macos) 2)
+ (t 0))
+ (coding-system-eol-type default-buffer-file-coding-system))))
(when priority
(set-default-coding-systems
(if (memq eol-type '(0 1 2 unix dos mac))
next prev parent reply other threads:[~2009-01-24 15:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <uab9gu30o.fsf@gnu.org>
2009-01-10 21:49 ` bug#1853: Trouble with gzipped info files on Windows Juanma Barranquero
2009-01-17 12:59 ` set-language-environment sets default EOL type to -unix Eli Zaretskii
2009-01-17 14:36 ` Stefan Monnier
2009-01-17 15:23 ` Eli Zaretskii
2009-01-17 15:40 ` Juanma Barranquero
2009-01-17 16:36 ` Eli Zaretskii
2009-01-17 16:59 ` Juanma Barranquero
2009-01-18 1:45 ` Stefan Monnier
2009-01-17 13:11 ` bug#1853: Trouble with gzipped info files on Windows Eli Zaretskii
2009-01-17 14:05 ` Eli Zaretskii
2009-01-17 14:15 ` Eli Zaretskii
2009-01-17 14:15 ` Eli Zaretskii
2009-01-18 21:01 ` Stefan Monnier
2009-01-19 4:11 ` Eli Zaretskii
2009-01-20 5:10 ` Stefan Monnier
2009-01-20 5:10 ` Stefan Monnier
2009-01-24 15:34 ` Eli Zaretskii
2009-01-24 15:34 ` Eli Zaretskii [this message]
2009-01-19 4:11 ` Eli Zaretskii
2009-01-18 21:01 ` Stefan Monnier
2009-01-17 14:05 ` Eli Zaretskii
2009-01-17 13:20 ` bug#1853: marked as done (Trouble with gzipped info files on Windows) Emacs bug Tracking System
2009-01-24 15:45 ` Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ubptwu38t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=1853@emacsbugs.donarmstrong.com \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
--cc=lekktu@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.