From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GCTtCN9G3mT5IQEASxT56A (envelope-from ) for ; Thu, 17 Aug 2023 18:12:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EEXFCN9G3mTvbQAAauVa8A (envelope-from ) for ; Thu, 17 Aug 2023 18:12:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B2CB461CFC for ; Thu, 17 Aug 2023 18:12:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692288735; a=rsa-sha256; cv=none; b=ifD/OPR7xpheTKn57EIHSxqpH98qZBydp7LS3h/Pkqkr+MjU3+O6EejfaRvfXUUuEPuYlM XX7u9A+1f6PGT52Qe/RAXXrB/6AhG27e7PT6TmjJaXl5LxoY50BPKmVyniEFkO3FMLKHin wzjNDNLXn4mDFoSY0qlgnUTlBW5TelKeBjVcCYQWqhD7Y+H8BrCwj6jNFqvyS73WrkktsY G232Y/92K0lzTyYHGHprc0bG2FoF07jEfXNCexS0mtPeN0BOYWp1Ok7iu3BvsxEeM1uJVL vK8ky2+qzsYlBSst/Z8pIiwQ/xdFWM58RBuI/wjHhcaVnyA3x6MpxI92SkfUfg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692288735; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=igWGeSv/gLwcVrvXNW3YTR5Y9WWFMA1ywSLpJ99kJZc=; b=L9+zgcqJ3XdD8pSDelgpgsZ9pGH9nuS+T1cyQL3fLK1P6VlnM7x0DmZ4RDE7djmo2ZBg+j M9i8D4eaFvNJeq+Xl3LQUJuJKyWpqfOkN/PKDmwirvhQJakZghnhYBk0WkU5GMAreCSuLs mI0mhvQXFQcVJ7dvkwbOPfFeVcUAyHP/uYnJv4itU1tvIRQlIKUacEcy66ZugSpWqMNFlP xkTunr8DOqATijIoXDsVJAlbz3dSr59CITYZXAmsgJHLbw6NN/JbAkQIyQYBpB8WuIpOVw mhk3hmc9p0XJ1LGSkmaQRWKxxCpj+9kosDuNAOwJloaVHkVoFNy9tn0nnC+bdQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWfal-0001YU-8M; Thu, 17 Aug 2023 12:11:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWfah-0001Y9-5k for emacs-orgmode@gnu.org; Thu, 17 Aug 2023 12:11:19 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWfae-0000S5-Fr for emacs-orgmode@gnu.org; Thu, 17 Aug 2023 12:11:18 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qWfab-0001Np-CU for emacs-orgmode@gnu.org; Thu, 17 Aug 2023 18:11:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [BUG][SECURITY] ob-sqlite header args allows execution of arbitrary shell commands Date: Thu, 17 Aug 2023 23:11:01 +0700 Message-ID: References: <87zg2vl6qc.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US, ru-RU In-Reply-To: <87zg2vl6qc.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-4.01, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: B2CB461CFC X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.47 X-Spam-Score: -5.47 X-TUID: o6aRo4XlPMKg On 13/08/2023 14:52, Ihor Radchenko wrote: > What do you think about creating a new API to built shell commands and > then using it across all the babel backends? I support the idea in general, but not its particular implementation as `org-make-shell-command' in your patch. It does not address the issue I raised. #+begin_src sqlite :db '(literal "/tmp/ob.sqlite$(date >/tmp/ob-sqlite-vuln.log)") select 1 #+end_src still executes a shell command without user prompt. Moreover for org-babel such value does not look like as something that may be evaluated, it is just a list. So the proposed syntax is more explicit (and I like it), but it does not prevent unsolicited execution of shell command. I would consider some way to specify whether COMMAND should be quoted as well. Path to an executable may contain a space or other special character at least for some shells. On the other hand it is more usual case to specify some arguments to the command. I am unsure if a note should be added to the `org-fill-template' docstring that the function should not be used for building shell commands.