From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Code inspection: W32 specific problems
Date: Tue, 12 Jul 2005 21:59:16 +0300
Message-ID: <uackrn94r.fsf@gnu.org>
References: <m3ll4cp52h.fsf@kfs-l.imdomain.dk>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1121195475 23942 80.91.229.2 (12 Jul 2005 19:11:15 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Tue, 12 Jul 2005 19:11:15 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 12 21:11:14 2005
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1DsQ9T-0007bC-Ue
	for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2005 21:10:44 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1DsQB7-0001XE-9D
	for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2005 15:12:25 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DsQ1c-0007ID-7H
	for emacs-devel@gnu.org; Tue, 12 Jul 2005 15:02:36 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DsQ1C-00074e-60
	for emacs-devel@gnu.org; Tue, 12 Jul 2005 15:02:11 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DsQ1B-00073v-UJ
	for emacs-devel@gnu.org; Tue, 12 Jul 2005 15:02:10 -0400
Original-Received: from [192.114.186.66] (helo=romy.inter.net.il)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DsQ65-00082w-3G
	for emacs-devel@gnu.org; Tue, 12 Jul 2005 15:07:13 -0400
Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-210-29.inter.net.il
	[83.130.210.29]) by romy.inter.net.il (MOS 3.5.8-GR)
	with ESMTP id BVI96936 (AUTH halo1);
	Tue, 12 Jul 2005 21:59:16 +0300 (IDT)
Original-To: storm@cua.dk (Kim F. Storm)
In-reply-to: <m3ll4cp52h.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:40840
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40840

> From: storm@cua.dk (Kim F. Storm)
> Date: Tue, 12 Jul 2005 14:44:06 +0200
> 
> 
> Code inspection revealed the following w32 specific problems:
> 
> - Qhigh and Qlow have no staticpro.
> 
> - Vw32_valid_codepages has no staticpro.
> 
> - Vw32_valid_locale_ids has no staticpro.
> 
> - Qw32_charset_default is never initialized, but its value
>   is used in two places.
> 
> - Vx_hand_shape is declared, but never initialized or used.
> 
> 
> Can someone pls. look at this and fix the problems, or
> alternatively specify why staticpro's are not needed.

Can please you remind the rules for what variables need staticpro?