From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: safe_call1 considered harmful
Date: Fri, 21 Jul 2006 18:49:29 +0300 [thread overview]
Message-ID: <uac73gdpy.fsf@gnu.org> (raw)
In-Reply-To: <E1G3tGq-0006Z3-00@etlken> (message from Kenichi Handa on Fri, 21 Jul 2006 20:34:16 +0900)
> From: Kenichi Handa <handa@m17n.org>
> CC: emacs-devel@gnu.org
> Date: Fri, 21 Jul 2006 20:34:16 +0900
>
> But, by considering this problem again, I found another
> solution than calling find-operation-coding-system with
> (FILENAME . BUFFER). That is to provide an extra argument
> BUFFER. Then, we can keep backward compatibility and
> find-buffer-file-type-coding-system works as before, and, by
> modifying po-find-file-coding-system to check that extra
> argument instead of checking if FILENAME is cons or not, we
> can make it work well too.
This will work if no function on file-coding-system-alist currently
looks at arguments beyond the 1st one, the file name. If there are
functions which look beyond that, such a change will break them.
While the chance of having such functions is very small, I don't see
how any significant change in the API could avoid breaking some
function that wasn't written to support the new API.
In any case, I think we should revert the change you made to use
safe_call1. Then we will quickly find any remaining functions that
need to be modified.
next prev parent reply other threads:[~2006-07-21 15:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 9:36 safe_call1 considered harmful Eli Zaretskii
2006-07-21 11:34 ` Kenichi Handa
2006-07-21 15:49 ` Eli Zaretskii [this message]
2006-07-24 1:36 ` Kenichi Handa
2006-07-29 11:00 ` Eli Zaretskii
2006-07-31 3:04 ` Kenichi Handa
2006-07-21 19:37 ` Richard Stallman
2006-07-24 1:44 ` Kenichi Handa
2006-07-24 18:22 ` Richard Stallman
2006-07-30 9:18 ` Kenichi Handa
2006-07-31 4:38 ` Richard Stallman
2006-07-31 5:14 ` Kenichi Handa
2006-07-31 22:16 ` Richard Stallman
2006-08-01 0:50 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uac73gdpy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.