From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: patch to fileio.c
Date: Fri, 14 Nov 2008 21:01:50 +0200 [thread overview]
Message-ID: <uabc2nnc1.fsf@gnu.org> (raw)
In-Reply-To: <87skpv3a35.fsf@cyd.mit.edu>
> From: Chong Yidong <cyd@stupidchicken.com>
> Date: Thu, 13 Nov 2008 10:43:42 -0500
>
> "Fabrice Popineau" <fabrice.popineau@free.fr> writes:
>
> > [ I'm posting my answer here too.]
> >
> >> Thanks for the patch. Your analysis sounds correct.
> >>
> >> However, I would like to test it first. Do you have a recipe for
> >> demonstrating incorrect specpdl_ptr handling (e.g. a crash)?
> >
> > I compiled emacs with msvc, and it crashed all the time under the same
> > circumstance. Visit a file, modify it outside emacs, and try to
> > re-visit it. Emacs will detect that it has been modified and will ask
> > about reloading it. The fd is closed twice because of the
> > unwind_protect. With msvcrt.dll, the MS C library, this is a
> > crash. I'm not sure that glibc is that picky. Possibly you won't see
> > the problem. However, to make sure, and to test the patch, I added
> > printf() statements at both places where fd can be closed, to trace
> > what happened.
>
> Does anyone else using Windows see this problem?
I don't see the crashes, but if I run Emacs under GDB and put a
breakpoint in w32.c:sys_close, I definitely see it being called twice
for the same file descriptor on which Emacs opened the file in
insert-file-contents.
next prev parent reply other threads:[~2008-11-14 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 15:15 patch to fileio.c Fabrice Popineau
2008-11-04 17:20 ` Chong Yidong
2008-11-07 0:17 ` Fabrice Popineau
2008-11-13 15:43 ` Chong Yidong
2008-11-14 19:01 ` Eli Zaretskii [this message]
2008-11-14 21:11 ` Chong Yidong
2008-11-14 21:16 ` Chong Yidong
2008-11-14 22:28 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uabc2nnc1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.