* [PATCH] Use ibuffer-buffer-file-name in ibuffer filename filter
@ 2013-07-17 8:16 Kan-Ru Chen (陳侃如)
2013-07-31 7:33 ` Glenn Morris
0 siblings, 1 reply; 2+ messages in thread
From: Kan-Ru Chen (陳侃如) @ 2013-07-17 8:16 UTC (permalink / raw
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
So that the filter works for dired buffer too. The original behavior is
confusing because you could see the buffer name in the *Ibuffer* buffer
but the filter didn't pick it up.
[-- Attachment #2: ibuf-ext-use-ibuffer-buffer-file-name.txt --]
[-- Type: text/plain, Size: 3034 bytes --]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: kanru@kanru.info-20130717080021-cmprj244462z7bf1
# target_branch: bzr://bzr.savannah.gnu.org/emacs/trunk/
# testament_sha1: a6ecbede343a3850a462576604f134690e9df849
# timestamp: 2013-07-17 16:14:54 +0800
# base_revision_id: eggert@cs.ucla.edu-20130715025617-8jaslimwdmfjvd1t
#
# Begin patch
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2013-07-15 02:33:54 +0000
+++ lisp/ChangeLog 2013-07-17 08:00:21 +0000
@@ -1,3 +1,8 @@
+2013-07-17 Kan-Ru Chen (陳侃如) <kanru@kanru.info>
+
+ * ibuf-ext.el (filename): Use ibuffer-buffer-file-name so the
+ filename filter works consistently with the displayed filename.
+
2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
* shell.el (explicit-bash-args): Remove obsolete hack for Bash 1.x.
=== modified file 'lisp/ibuf-ext.el'
--- lisp/ibuf-ext.el 2013-06-12 11:42:12 +0000
+++ lisp/ibuf-ext.el 2013-07-17 08:00:21 +0000
@@ -1050,7 +1050,7 @@
"Toggle current view to buffers with filename matching QUALIFIER."
(:description "filename"
:reader (read-from-minibuffer "Filter by filename (regexp): "))
- (ibuffer-awhen (buffer-local-value 'buffer-file-name buf)
+ (ibuffer-awhen (with-current-buffer buf (ibuffer-buffer-file-name))
(string-match qualifier it)))
;;;###autoload (autoload 'ibuffer-filter-by-size-gt "ibuf-ext")
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWWtBu9AAAjjf+QAwUHP/91oM
EgC////wGAAAIAEACAEGIFAEmeadCq7jt3UulVhJKaJNiamyU/Jqb1Ghok9PIgR5TaQAfqgkomVP
MTUxNMRNAnlPUPKMBBgQaYSmoqfiTTU09TymNJoMho0GagwgABzAATJgATCYJhDAEYAEkgImBMmm
min6Co9R5T9UMNAGkAJs1k9W4+4i2mkUanPrTVPmfcZie+URdfgXXukpoaCnPG0rM+8hJk/uDU+K
Md57xygq4Ouzax3IatZgDSMef16vIYk2Q8YNTzJkS7nqaecDHMyz8UPZBklrD0wX47NDpYWnyPlE
N4DBjNamXRliBw7J6jG9RXie+EjfR0CNHWcRaGkx1NlmyFmJLgw2KDUBOJnuEt20CE0dYyGFm5PH
Djds5d2BaAU1CtpUWgFKZxUbycdlpcD7HJ6mgY7eEyKq9fEw/O6sUxTfxNjdZor/LnCUBWZlnC12
BwqNVjcgpV+JVcngXmyXRhZ2FoS6cK8c1pZpwphCraLuyFnEWRUgltyMuKjSdz5gPUDGnNkdcKzW
sDEpsKBKmY4UJ1XuHkAtIRde5+zHTWgJDZ52CfWMRE4B4HAYDCKjOOcC1Pk+shYUmGZshMGf6kco
qqxYMSz0EHGLS5SLRlp9Wj5tnDYLo89wnSnUUFYxqywQZ4zuNIUm+8HFDpzqZIYFuUB5YWFhWVSC
BviWgVjyY8VZSzA05rALIuor1P0toiQhkZpUWzKiJyk44rCgVOV4ptC8rsbuOlIJb3ItoaLoZQUX
AoqLSYlJb8MjWHThnSVaWYTY8Vo6QRyjCnSQzNz7JSFtUDxxAZIyBF3BwaAzDhVlffSaqrGumm2I
v8KEijoRTq4ETSpXqRZ7c53+GOtdzAUvfSiVgZfUWsW83j5XGu3TJvtodEEwHKec49AiyruWa2lU
T0F5O8OGJEMh28iRRupsYOaY86wPJVPDewW0MhlMAmHMhGHT1WGikqxURsgdZQQmSinT0CYvc/Q8
HSOwMLyL+fMrFja3l1DrUimrqzve4wMFiK8JjcoAyuGS3Vu1RhbseRo3qQxoh+IbOSTDPKttnqYU
dikJgKCxMB8Sxcz8j3O+I8L10SHHX07O8VfiZDDwtDi9cJG1i6wEIS8oTjmRESbaPLyZqnDQ0V/d
DR8FVYgHFyk8UZXiJrKoa0XojUw4rVkBDEDxXhtXI1EaGiYuvNNEVHFH4MFyLnBWHkPST1WS147Y
FJGXIbNlCgkRpNS00verQOJZVjWPJIcdEwdCEURZIco3chPBESaCTAy5cshgKRMX/XcXFCO7iJki
0oXB6trW7DcwwOUIEr3AP7YaxT0YMBcK0b7arqUpa7lHluAkXMV7nOeiN4Ik5eBtB+6XoWHFis4I
qHFC1barySNgxQJ1R9ENvCgoCfWNY05CUgbFNCGeMiRBDAa9wT9DgXAwREVMIf5BxEuMKt2/sLVW
rejlzVNRd2igIZxVe8Yif4DGSVX8wPk7Qsf6/mGH9wwwr/4u5IpwoSDWg3eg
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Use ibuffer-buffer-file-name in ibuffer filename filter
2013-07-17 8:16 [PATCH] Use ibuffer-buffer-file-name in ibuffer filename filter Kan-Ru Chen (陳侃如)
@ 2013-07-31 7:33 ` Glenn Morris
0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2013-07-31 7:33 UTC (permalink / raw
To: Kan-Ru Chen (陳侃如); +Cc: emacs-devel
Thanks; applied.
(BTW, it is better to send such things as bug reports.)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-31 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 8:16 [PATCH] Use ibuffer-buffer-file-name in ibuffer filename filter Kan-Ru Chen (陳侃如)
2013-07-31 7:33 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.