all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: rms@gnu.org
Cc: hannes@saeurebad.de, kifer@cs.sunysb.edu, emacs-devel@gnu.org
Subject: Re: Problems with setting face attributes for specific frames
Date: Sun, 30 Sep 2007 18:28:55 +0200	[thread overview]
Message-ID: <u7im8azi0.fsf@gnu.org> (raw)
In-Reply-To: <E1IbyK0-0005DQ-DU@fencepost.gnu.org> (message from Richard Stallman on Sun, 30 Sep 2007 08:54:56 -0400)

> From: Richard Stallman <rms@gnu.org>
> CC: emacs-devel@gnu.org
> Date: Sun, 30 Sep 2007 08:54:56 -0400
> 
> Not many packages call `set-face-attribute'.  There are just
> two in Emacs that use it with a frame: ediff-wind.el
> and mac-win.el.  pc-win.el calls it via `set-face-foreground'
> and `set-face-background'.  The obsolete hilit19 package 
> calls `set-face-font', but we could delete that.
> 
> Kifer, what is ediff-wind.el trying to do, and could it be done in
> another way?
> 
> Eli, what is pc-win.el trying to do, and could it be done in
> another way?  Perhaps by changing the deffaces for those faces?

Do I understand correctly that the problem is with pc-win.el's use of
the frame argument to `set-face-fore/background'?  If so, I think we
can easily delete that argument: the only frame that exists when
msdos-face-setup runs is `terminal-frame' so nothing bad will happen.

For the record, what those calls do is set up the standard colors for
some popular faces, notably the colors of the drop-down menus.

  parent reply	other threads:[~2007-09-30 16:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 14:38 [BUG] Dark/bright face detection problem Johannes Weiner
2007-09-28 15:46 ` Johannes Weiner
2007-09-29 16:10   ` Richard Stallman
2007-09-29 21:20     ` Johannes Weiner
2007-09-29 21:32       ` Johannes Weiner
     [not found]         ` <E1IbyK0-0005DQ-DU@fencepost.gnu.org>
2007-09-30 16:28           ` Eli Zaretskii [this message]
2007-10-01 17:40             ` Problems with setting face attributes for specific frames Richard Stallman
2007-09-30 23:54           ` Drew Adams
2007-10-01 17:40             ` Richard Stallman
2007-10-01 18:17               ` Drew Adams
2007-10-02  3:32                 ` Richard Stallman
2007-10-02 15:09                   ` Drew Adams
2007-10-02 22:00                     ` Richard Stallman
2007-10-01 18:45               ` Stephen J. Turnbull
2007-10-02  3:32                 ` Richard Stallman
2007-09-29 16:21   ` [BUG] Dark/bright face detection problem Dan Nicolaescu
2007-09-29 15:52 ` Eli Zaretskii
2007-09-29 16:16   ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u7im8azi0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=hannes@saeurebad.de \
    --cc=kifer@cs.sunysb.edu \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.