all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org, angelo.graziosi@alice.it
Subject: Re: 'Strange' changes in status line
Date: Thu, 28 Aug 2008 22:33:01 +0300	[thread overview]
Message-ID: <u7ia10wb6.fsf@gnu.org> (raw)
In-Reply-To: <okmyixu19o.fsf@fencepost.gnu.org>

> From: Glenn Morris <rgm@gnu.org>
> Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 28 Aug 2008 02:00:51 -0400
> 
> Angelo Graziosi wrote:
> 
> > In the status line, now I see 'Emacs' near the buffer name
> >
> > --:----Emacs foo.f90 59% ....
> >
> > Just a curiosity, Why this change and which usefulness?
> 
> I believe it's an unintended consequence of this:
> 
> 2008-08-25  Eli Zaretskii  <eliz@gnu.org>
> 
>     * bindings.el (mode-line-frame-control): New function, caters to
>     `pc' ``window system''.
>     (mode-line-frame-identification): Use it instead of
>     accessing window-system directly.
> 
> 
> In X:
> 
> emacs -Q
> 
> C-h v mode-line-frame-identification
> Its value is ("-%F  ")
> 
> M-: (mode-line-frame-control)
> -> " "
> 
> ie, the variable is being set at the wrong time.

Does this change fix the problem on X?  (I cannot try this on X right
now, but I verified that it works on a tty, MS-Windows, and MS-DOS.)

Index: lisp/bindings.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/bindings.el,v
retrieving revision 1.211
diff -u -r1.211 bindings.el
--- lisp/bindings.el	25 Aug 2008 21:50:55 -0000	1.211
+++ lisp/bindings.el	28 Aug 2008 19:30:19 -0000
@@ -219,8 +219,8 @@
 (defun mode-line-frame-control ()
   "Compute mode-line control for frame identification.
 Value is used for `mode-line-frame-identification', which see."
-  (if (or (null (window-system))
-	  (eq (window-system) 'pc))
+  (if (or (null initial-window-system)
+	  (eq initial-window-system 'pc))
       "-%F  "
     "  "))
 




  parent reply	other threads:[~2008-08-28 19:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 23:52 'Strange' changes in status line Angelo Graziosi
2008-08-28  6:00 ` Glenn Morris
2008-08-28  8:09   ` Angelo Graziosi
2008-08-28 18:15     ` Eli Zaretskii
2008-08-28 18:54   ` Eli Zaretskii
2008-08-28 19:33   ` Eli Zaretskii [this message]
2008-08-29  6:34     ` Glenn Morris
2008-08-29  9:14       ` Eli Zaretskii
2008-08-29 16:34         ` Glenn Morris
2008-08-29 17:58           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u7ia10wb6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=angelo.graziosi@alice.it \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.