23.0; Error in generated makefile on windows xp

23.0; Error in generated makefile on windows xp

[Christoph Conrad]

Current CVS emacs, Visual Studio .NET 2003.

.\configure.bat  --with-msvc --without-png --without-jpeg --without-gif --without-tiff --without-xpm

,----
| ifdef USE_FONTBACKEND
| FONTOBJ = $(BLD)/w32font.$(O)
| endif
`----

in "src\makefile" should be

,----
| !ifdef USE_FONTBACKEND
| FONTOBJ = $(BLD)/w32font.$(O)
| !endif
`----

'!' is missing at two places.

Re: 23.0; Error in generated makefile on windows xp

[Jason Rumney]

Christoph Conrad wrote:
> Current CVS emacs, Visual Studio .NET 2003.
>
> .\configure.bat  --with-msvc --without-png --without-jpeg --without-gif --without-tiff --without-xpm
>
> ,----
> | ifdef USE_FONTBACKEND
> | FONTOBJ = $(BLD)/w32font.$(O)
> | endif
> `----
>
> in "src\makefile" should be
>
> ,----
> | !ifdef USE_FONTBACKEND
> | FONTOBJ = $(BLD)/w32font.$(O)
> | !endif
> `----
>
> '!' is missing at two places.
>   

If someone can come up with a simple fix that does not break the build 
when using GNU make/gcc, then it can be installed, but since that 
conditional will eventually be removed before 23.1 goes into pretest, I 
don't think it is worth spending a large amount of time overhauling the 
build process for.

Re: 23.0; Error in generated makefile on windows xp

[Eli Zaretskii]

> Date: Thu, 28 Feb 2008 17:17:25 +0000
> From: Jason Rumney <jasonr@gnu.org>
> Cc: bug-gnu-emacs@gnu.org
> 
> Christoph Conrad wrote:
> > Current CVS emacs, Visual Studio .NET 2003.
> >
> > .\configure.bat  --with-msvc --without-png --without-jpeg --without-gif --without-tiff --without-xpm
> >
> > ,----
> > | ifdef USE_FONTBACKEND
> > | FONTOBJ = $(BLD)/w32font.$(O)
> > | endif
> > `----
> >
> > in "src\makefile" should be
> >
> > ,----
> > | !ifdef USE_FONTBACKEND
> > | FONTOBJ = $(BLD)/w32font.$(O)
> > | !endif
> > `----
> >
> > '!' is missing at two places.
> >   
> 
> If someone can come up with a simple fix that does not break the build 
> when using GNU make/gcc, then it can be installed

One way of fixing this would be to move this conditional into
gamke.defs and nmake.defs, where one can use the syntax appropriate
for each flavor of Make.

Re: 23.0; Error in generated makefile on windows xp

[Jason Rumney]

Eli Zaretskii wrote:
>> Date: Thu, 28 Feb 2008 17:17:25 +0000
>> From: Jason Rumney <jasonr@gnu.org>
>> Cc: bug-gnu-emacs@gnu.org
>>
>> Christoph Conrad wrote:
>>     
>>> Current CVS emacs, Visual Studio .NET 2003.
>>>
>>> .\configure.bat  --with-msvc --without-png --without-jpeg --without-gif --without-tiff --without-xpm
>>>
>>> ,----
>>> | ifdef USE_FONTBACKEND
>>> | FONTOBJ = $(BLD)/w32font.$(O)
>>> | endif
>>> `----
>>>
>>> in "src\makefile" should be
>>>
>>> ,----
>>> | !ifdef USE_FONTBACKEND
>>> | FONTOBJ = $(BLD)/w32font.$(O)
>>> | !endif
>>> `----
>>>
>>> '!' is missing at two places.
>>>   
>>>       
>> If someone can come up with a simple fix that does not break the build 
>> when using GNU make/gcc, then it can be installed
>>     
>
> One way of fixing this would be to move this conditional into
> gamke.defs and nmake.defs, where one can use the syntax appropriate
> for each flavor of Make.
>   
I don't think $(BLD) is defined at that point, as it is specific to the 
src makefile. I'm also not sure where it gets expanded (when defined, or 
when used) and whether that is consistent between nmake and GNU make.