all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
Cc: rogers-emacs@rgrjr.dyndns.org, mituharu@math.s.chiba-u.ac.jp,
	emacs-devel@gnu.org
Subject: Re: Bug in incremental undrawing of mouseover highlighting
Date: Sat, 25 Nov 2006 23:10:12 +0200	[thread overview]
Message-ID: <u4psn5j2j.fsf@gnu.org> (raw)
In-Reply-To: <87y7pzo5yx.fsf@stupidchicken.com> (message from Chong Yidong on Sat, 25 Nov 2006 11:18:14 -0500)

> Cc: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>,
> 	  rogers-emacs@rgrjr.dyndns.org,  emacs-devel@gnu.org
> From: Chong Yidong <cyd@stupidchicken.com>
> Date: Sat, 25 Nov 2006 11:18:14 -0500
> 
> > I don't consider myself much of a redisplay expert, but I did express
> > a (different) concern for the patch as posted, a concern that
> > seemingly had no effect whatsoever.
> 
> It's still unclear, from the messages you sent, whether this bug can
> happen outside of HAVE_WINDOW_SYSTEM.  The bugfix is meant to plug a
> loophole in the code in note_mouse_highlight that computes whether or
> not the mouse highlight has been updated, which is only present for
> HAVE_WINDOW_SYSTEM.

You will see that the same code is duplicated, more or less, in
msdos.c, beginning at line 1612.  That is why I thought the same
problem could happen there, and that is why I was bothered by the fact
that the fix was only applied to builds that define
HAVE_WINDOW_SYSTEM.

Meanwhile, I've built an MSDOS port of Emacs 22.0.91 and found I
couldn't reproduce the original problem in it.  So I guess the issue
of whether the same fix should be applied to the MSDOS port can now be
closed.

As to the concerns expressed by Yamamoto Mitsuharu, I would also
suggest that a redisplay expert looks into them.

  reply	other threads:[~2006-11-25 21:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-19 22:32 Bug in incremental undrawing of mouseover highlighting Bob Rogers
2006-11-19 22:50 ` David Kastrup
2006-11-19 23:45   ` Bob Rogers
2006-12-13 14:45     ` Stephen Berman
2006-12-13 16:04       ` Chong Yidong
2006-12-14  9:22         ` Stephen Berman
2006-12-16 12:31           ` Stephen Berman
2006-11-20  4:20   ` Eli Zaretskii
2006-11-20 19:22 ` Chong Yidong
2006-11-20 20:24   ` misleading install instruction in emacs/mac/INSTALL Gilbert Harman
2006-11-21  7:47     ` Richard Stallman
2006-11-22  8:23       ` YAMAMOTO Mitsuharu
2006-11-22 17:07         ` Gilbert Harman
2006-11-20 20:36   ` Bug in incremental undrawing of mouseover highlighting Eli Zaretskii
2006-11-22  4:06     ` Bob Rogers
2006-11-22 18:35       ` Eli Zaretskii
2006-11-22 15:07     ` Chong Yidong
2006-11-22 22:20       ` Eli Zaretskii
2006-11-22 23:57         ` Nick Roberts
2006-11-23  4:12           ` Eli Zaretskii
2006-11-23  4:50             ` Nick Roberts
2006-11-24 18:18               ` Eli Zaretskii
2006-11-25  1:53   ` YAMAMOTO Mitsuharu
2006-11-25  4:18     ` Chong Yidong
2006-11-25  7:28       ` YAMAMOTO Mitsuharu
2006-11-25 10:53         ` Eli Zaretskii
2006-11-25 16:18           ` Chong Yidong
2006-11-25 21:10             ` Eli Zaretskii [this message]
2006-11-26 19:05               ` Kim F. Storm
2006-12-26  2:26 ` Richard Stallman
2006-12-27  3:58   ` Bob Rogers
2006-12-27 21:16     ` Richard Stallman
2007-01-02 15:46       ` Kim F. Storm
2007-01-05  0:38         ` Michael Mauger
2007-01-19 15:33         ` Chong Yidong
2007-01-20 21:40           ` Stephen Berman
2007-01-21 14:36             ` Stephen Berman
2007-11-07 22:18               ` Stephen Berman
2007-01-23 16:28           ` John Paul Wallington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u4psn5j2j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    --cc=rogers-emacs@rgrjr.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.