From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: nt/makefile.w32-in Date: Fri, 22 Dec 2006 13:41:02 +0200 Message-ID: References: <458A71F9.2050709@gnu.org> <458AFA12.4010700@student.lu.se> <458B0F4C.90909@student.lu.se> Reply-To: Eli Zaretskii NNTP-Posting-Host: dough.gmane.org X-Trace: sea.gmane.org 1166787736 18767 80.91.229.10 (22 Dec 2006 11:42:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 22 Dec 2006 11:42:16 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 22 12:42:14 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1Gximy-0000DJ-6N for ged-emacs-devel@m.gmane.org; Fri, 22 Dec 2006 12:42:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gximx-00089F-HJ for ged-emacs-devel@m.gmane.org; Fri, 22 Dec 2006 06:42:11 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gxim4-0007Cm-Rk for emacs-devel@gnu.org; Fri, 22 Dec 2006 06:41:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gxim2-0007AJ-LA for emacs-devel@gnu.org; Fri, 22 Dec 2006 06:41:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gxim1-00079s-Jx for emacs-devel@gnu.org; Fri, 22 Dec 2006 06:41:13 -0500 Original-Received: from [192.114.186.73] (helo=heller.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gxilx-0001BG-SK; Fri, 22 Dec 2006 06:41:10 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-84-229-216-239.inter.net.il [84.229.216.239]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id BIH38939 (AUTH halo1); Fri, 22 Dec 2006 13:40:58 +0200 (IST) Original-To: lekktu@gmail.com, jasonr@gnu.org, emacs-devel@gnu.org In-reply-to: (message from Eli Zaretskii on Fri, 22 Dec 2006 13:07:03 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64100 Archived-At: > Date: Fri, 22 Dec 2006 13:07:03 +0200 > From: Eli Zaretskii > Cc: lekktu@gmail.com, jasonr@gnu.org, emacs-devel@gnu.org > > > Date: Thu, 21 Dec 2006 23:48:44 +0100 > > From: Lennart Borgman > > CC: lekktu@gmail.com, emacs-devel@gnu.org, jasonr@gnu.org > > > > > > After the release, I will convert gmake.defs and nmake.defs to DOS EOL > > > format. I don't want to touch them now, as no one complained that it > > > interferes with the build. > > > > I guess you are pretty sure that this is the right thing to do. Why not > > do it now then? > > Because this has been in the code base since December 2001, and no one > complained. I want to avoid introducing new problems for which we > don't have enough testing time before the release. Actually, the plot thickens. It turns out Andrew Innes reverted back to Unix EOLs a short while after the change to DOS EOLs: 2000-09-17 Andrew Innes * gmake.defs: Revert to Unix line endings. * nmake.defs: Revert to Unix line endings. 2000-09-14 Andrew Innes * makefile.w32-in: Revert to Unix line endings. 2000-09-03 Andrew Innes * makefile.w32-in: Change to DOS line endings. What happened next is two things: on 2001-09-25 the Emacs 21 release branch was cut, and on 2001-12-03, nt/makefile.w32-in was checked in on HEAD with this change: (bootstrap-nmake): (bootstrap-gmake): Extend bootstrap process to first do bootstrap-clean in lisp dir and rebuild the DOC file. (bootstrap): Do a "normal" make after the bootstrap work. (which btw is not in ChangeLog). This changed the file back to DOS EOLs as a side effect, evidently by accident. As a result, all Emacs 21.x releases were shipped with nt/makefile.w32-in that had Unix EOLs, while in CVS we have DOS EOLs since December 2001. So, on the one hand, this makes a very strong argument for changing the EOLs back to Unix, because all users of Emacs 21.x who built it did that with Unix EOLs, but OTOH the experience of CVS usage tells us that the current situation did not cause any trouble since 2001-12. It is clear that the file should be reverted to Unix EOLs, but now I'm unsure what, if anything, should we do before the release. Thoughts?