From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: list-colors-display: filter same adjecent colors Date: 24 Feb 2004 08:43:54 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20040224034358.17107.qmail@web60301.mail.yahoo.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1077605137 20602 80.91.224.253 (24 Feb 2004 06:45:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 24 Feb 2004 06:45:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Feb 24 07:45:28 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AvWJs-0004zu-00 for ; Tue, 24 Feb 2004 07:45:28 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AvWJs-0002wx-00 for ; Tue, 24 Feb 2004 07:45:28 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvWHj-0004Yh-3A for emacs-devel@quimby.gnus.org; Tue, 24 Feb 2004 01:43:15 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1AvWHM-0004W5-Qg for emacs-devel@gnu.org; Tue, 24 Feb 2004 01:42:52 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1AvWGq-0003tb-SX for emacs-devel@gnu.org; Tue, 24 Feb 2004 01:42:51 -0500 Original-Received: from [207.232.27.5] (helo=WST0054) by monty-python.gnu.org with asmtp (Exim 4.30) id 1AvWGp-0003lm-Ea; Tue, 24 Feb 2004 01:42:19 -0500 Original-To: Michael Mauger In-reply-to: <20040224034358.17107.qmail@web60301.mail.yahoo.com> (message from Michael Mauger on Mon, 23 Feb 2004 19:43:58 -0800 (PST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20150 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20150 > Date: Mon, 23 Feb 2004 19:43:58 -0800 (PST) > From: Michael Mauger > > This was another conversation from November. > > See http://mail.gnu.org/archive/html/emacs-devel/2003-11/msg00189.html Thanks for following up. > (defun facemenu-color-equal (a b) > "Return t if colors A and B are the same color. > -A and B should be strings naming colors. > -This function queries the display system to find out what the color > -names mean. It returns nil if the colors differ or if it can't > -determine the correct answer." > - (cond ((equal a b) t) > - ((equal (color-values a) (color-values b))))) > +A and B should be strings naming colors. These names are > +downcased, stripped of spaces and the string `grey' is turned > +into `gray'. This accomidates alternative spellings of colors > +found commonly in the list. It returns nil if the colors differ." > + (progn > + (setq a (replace-regexp-in-string "grey" "gray" > + (replace-regexp-in-string " " "" > + (downcase a))) > + b (replace-regexp-in-string "grey" "gray" > + (replace-regexp-in-string " " "" > + (downcase b)))) > + > + (equal a b))) Hmm, how about making this a new function, and leaving the original facemenu-color-equal alone? None of the Lisp files bundled with Emacs use facemenu-color-equal, but perhaps some add-on packages do, as it sounds like useful functionality and is there since 1994. Also, I think we should mention the MS-Windows case and the special color names used there explicitly, at least in a comment to the function's code, if not in the doc string. A year from now, no one will remember why we modified the way colors are compared.