From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: [drew.adams@oracle.com: mouse-2 on menu item yanks into current buffer] Date: Sat, 11 Mar 2006 14:43:22 +0000 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1142088330 7151 80.91.229.2 (11 Mar 2006 14:45:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 11 Mar 2006 14:45:30 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 11 15:45:29 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FI5LL-0003rq-1H for ged-emacs-devel@m.gmane.org; Sat, 11 Mar 2006 15:45:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FI5LK-0005Iq-KE for ged-emacs-devel@m.gmane.org; Sat, 11 Mar 2006 09:45:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FI5L6-0005Il-O1 for emacs-devel@gnu.org; Sat, 11 Mar 2006 09:45:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FI5L3-0005IK-4V for emacs-devel@gnu.org; Sat, 11 Mar 2006 09:45:04 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FI5L2-0005IH-TO for emacs-devel@gnu.org; Sat, 11 Mar 2006 09:45:00 -0500 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FI5OT-0008Pq-4W; Sat, 11 Mar 2006 09:48:33 -0500 Original-Received: from wanchan.jasonrumney.net (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail.freedom2surf.net (8.12.10/8.12.10) with ESMTP id k2BEiq5K009030; Sat, 11 Mar 2006 14:44:52 GMT Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id D95D532; Sat, 11 Mar 2006 14:44:51 +0000 (GMT) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Sat, 11 Mar 2006 15:55:20 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51468 Archived-At: Eli Zaretskii writes: > Would Windows GUI gurus please look at the patch below and tell if > it's the right one? It does seem to fix the problem for me (on > Windows XP): Can you try it with just the final segment of your patch. The right button seems to already be filtered out by the system (or somewhere else in Emacs I haven't noticed), so the code to ignore the right button is superfluous I think. > Index: src/w32fns.c > =================================================================== > RCS file: /cvsroot/emacs/emacs/src/w32fns.c,v > retrieving revision 1.262 > diff -u -p -r1.262 w32fns.c > --- src/w32fns.c 6 Feb 2006 15:23:22 -0000 1.262 > +++ src/w32fns.c 11 Mar 2006 13:52:50 -0000 > @@ -3250,6 +3260,11 @@ w32_wnd_proc (hwnd, msg, wParam, lParam) > BOOL up; > int button; > > + /* Ignore middle and extra buttons as long as the menu is active. */ > + f = x_window_to_frame (dpyinfo, hwnd); > + if (f && f->output_data.w32->menubar_active) > + return 0; > + > if (parse_button (msg, HIWORD (wParam), &button, &up)) > { > if (up) ReleaseCapture ();