all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Fran Litterio <flitterio@gmail.com>
Cc: 722@emacsbugs.donarmstrong.com, bug-gnu-emacs@gnu.org
Subject: bug#722: More Visual Studio 6.0 compiler errors on Windows XP
Date: Fri, 15 Aug 2008 20:02:20 +0300	[thread overview]
Message-ID: <u3al6fbz7.fsf@gnu.org> (raw)
In-Reply-To: <a5b589a70808150939t292364c2peac97dfd476d383b@mail.gmail.com>

> Date: Fri, 15 Aug 2008 12:39:27 -0400
> From: "Fran Litterio" <flitterio@gmail.com>
> Cc: 722@emacsbugs.donarmstrong.com, schwab@suse.de, 
> 	bug-submit-list@donarmstrong.com, bug-gnu-emacs@gnu.org, 
> 	don@donarmstrong.com
> 
> > Emacs has always compiled using VC++ 6.0 in the past, so some change
> > > must have introduced this problem.
> >
> > The problems in w32.c are due to a recent change I did to impement two
> > new primitives, but the change in dired.c that made st_size be
> > unsigned 64-bit type is fairly old.  When did you last build the CVS
> > code?
> >
> 
> Some timestamp sleuthing leads me to believe it was Jan 19th, 2008.

In that case, it is quite probable that you didn't see those changes
then.

> > Also, a 64-bit integer (signed or unsigned) cannot safely be cast to
> > > double without loss of data.
> >
> > Yes, when file sizes will start hitting 64-bits, we will start losing
> > precision here.  But I hope till then all compilers will have long
> > double data type, and then this code could be fixed.
> 
> 
> Good point!

Maybe I should simply make st_size be a signed 64-bit type.  Does
anyone see any problems with that?






  reply	other threads:[~2008-08-15 17:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-14 21:11 bug#722: More Visual Studio 6.0 compiler errors on Windows XP Francis Litterio
2008-08-15  9:33 ` Andreas Schwab
2008-08-15 12:33 ` Eli Zaretskii
     [not found] ` <mailman.16775.1218793661.18990.bug-gnu-emacs@gnu.org>
2008-08-15 13:35   ` Francis Litterio
2008-08-15 16:17     ` Eli Zaretskii
2008-08-15 16:39       ` Fran Litterio
2008-08-15 17:02         ` Eli Zaretskii [this message]
     [not found] ` <mailman.16795.1218804458.18990.bug-gnu-emacs@gnu.org>
2008-08-15 14:20   ` Francis Litterio
2008-08-15 17:09     ` Eli Zaretskii
2008-08-15 19:35 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u3al6fbz7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=722@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=flitterio@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.