* bug#2193: 23.0.90/winxp; crash when closing speedbar
2009-02-04 13:29 ` bug#2193: 23.0.90/winxp; crash when closing speedbar lode leroy
@ 2009-02-04 18:23 ` Eli Zaretskii
2009-02-05 18:20 ` martin rudalics
2009-02-08 15:45 ` bug#2193: marked as done (23.0.90/winxp; crash when closing speedbar) Emacs bug Tracking System
2 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2009-02-04 18:23 UTC (permalink / raw)
To: lode leroy, 2193
> Date: Wed, 4 Feb 2009 14:29:46 +0100
> From: lode leroy <lode.leroy@gmail.com>
> Cc:
>
> emacs crashes every time I do the following:
>
> go to Options->Show/Hide->speedbar
> in the speedbar frame: click modeline->Speedbar->Quit
Confirmed.
For those who (unlike myself) have time to look at this, here's the
crash report from DrMinGW:
emacs.exe caused an Access Violation at location 0115f1cf in module emacs.exe Reading from location 00000104.
Registers:
eax=00000000 ebx=02a2b801 ecx=02a2b801 edx=02bcee00 esi=02a2b801 edi=00000002
eip=0115f1cf esp=0082fbf0 ebp=0082fbf8 iopl=0 nv up ei pl zr na po nc
cs=001b ss=0023 ds=0023 es=0023 fs=003b gs=0000 efl=00000246
Call stack:
0115F1CF emacs.exe:0115F1CF cancel_hourglass w32fns.c:5283
...
hourglass_hwnd);
> f->output_data.w32->hourglass_p = 0;
SetCursor (f->output_data.w32->current_cursor);
hourglass_shown_p = 0;
...
01052280 emacs.exe:01052280 cancel_hourglass_unwind keyboard.c:1516
...
{
cancel_hourglass ();
> return Qnil;
}
#endif
...
0100A50A emacs.exe:0100A50A unbind_to eval.c:3429
...
SET_SYMBOL_VALUE (this_binding.symbol, this_binding.old_value);
else
> set_internal (this_binding.symbol, this_binding.old_value, 0, 1);
}
}
...
0105F2BF emacs.exe:0105F2BF command_loop_1 keyboard.c:1908
...
just because a command in the macro finishes. */
if (NILP (Vexecuting_kbd_macro))
> unbind_to (scount, Qnil);
#endif
}
...
01009FBE emacs.exe:01009FBE internal_condition_case eval.c:1512
...
val = (*bfun) ();
> catchlist = c.next;
handlerlist = h.next;
return val;
...
0105207A emacs.exe:0105207A command_loop_2 keyboard.c:1357
...
do
> val = internal_condition_case (command_loop_1, Qerror, cmd_error);
while (!NILP (val));
...
01009EF3 emacs.exe:01009EF3 internal_catch eval.c:1247
...
/* Call FUNC. */
if (! _setjmp (c.jmp))
> c.val = (*func) (arg);
/* Throw works by a longjmp that comes right here. */
...
01051E87 emacs.exe:01051E87 command_loop keyboard.c:1340
...
/* End of file in -batch run causes exit here. */
> if (noninteractive)
Fkill_emacs (Qt);
}
...
01051F20 emacs.exe:01051F20 recursive_edit_1 keyboard.c:952
...
val = command_loop ();
> if (EQ (val, Qt))
Fsignal (Qquit, Qnil);
/* Handle throw from read_minibuf when using minibuffer
...
01052041 emacs.exe:01052041 Frecursive_edit keyboard.c:1014
...
recursive_edit_1 ();
> return unbind_to (count, Qnil);
}
...
01002E47 emacs.exe:01002E47 main emacs.c:1855
...
/* NOTREACHED */
return 0;
> }
/* Sort the args so we can find the most important ones
...
0100124B emacs.exe:0100124B
01001298 emacs.exe:01001298
7C816D4F kernel32.dll:7C816D4F RegisterWaitForInputIdle
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#2193: 23.0.90/winxp; crash when closing speedbar
2009-02-04 13:29 ` bug#2193: 23.0.90/winxp; crash when closing speedbar lode leroy
2009-02-04 18:23 ` Eli Zaretskii
@ 2009-02-05 18:20 ` martin rudalics
2009-02-08 15:45 ` bug#2193: marked as done (23.0.90/winxp; crash when closing speedbar) Emacs bug Tracking System
2 siblings, 0 replies; 4+ messages in thread
From: martin rudalics @ 2009-02-05 18:20 UTC (permalink / raw)
To: lode leroy; +Cc: 2193
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
> emacs crashes every time I do the following:
>
> go to Options->Show/Hide->speedbar
> in the speedbar frame: click modeline->Speedbar->Quit
>
> In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
> of 2009-02-01 on SOFT-MJASON
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4)'
Could you please try the attached patch?
Thank you, martin.
[-- Attachment #2: w32fns.c.diff --]
[-- Type: text/plain, Size: 799 bytes --]
*** w32fns.c.~1.354.~ 2009-01-18 17:29:00.343750000 +0100
--- w32fns.c 2009-02-05 19:17:05.515625000 +0100
***************
*** 5277,5288 ****
{
if (hourglass_shown_p)
{
! struct frame *f = x_window_to_frame (&one_w32_display_info,
! hourglass_hwnd);
- f->output_data.w32->hourglass_p = 0;
- SetCursor (f->output_data.w32->current_cursor);
hourglass_shown_p = 0;
}
}
--- 5277,5295 ----
{
if (hourglass_shown_p)
{
! struct frame *f;
!
! BLOCK_INPUT;
! f = x_window_to_frame (&one_w32_display_info, hourglass_hwnd);
!
! if (f)
! {
! f->output_data.w32->hourglass_p = 0;
! SetCursor (f->output_data.w32->current_cursor);
! }
hourglass_shown_p = 0;
+ UNBLOCK_INPUT;
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#2193: marked as done (23.0.90/winxp; crash when closing speedbar)
2009-02-04 13:29 ` bug#2193: 23.0.90/winxp; crash when closing speedbar lode leroy
2009-02-04 18:23 ` Eli Zaretskii
2009-02-05 18:20 ` martin rudalics
@ 2009-02-08 15:45 ` Emacs bug Tracking System
2 siblings, 0 replies; 4+ messages in thread
From: Emacs bug Tracking System @ 2009-02-08 15:45 UTC (permalink / raw)
To: Jason Rumney
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
Your message dated Sun, 08 Feb 2009 23:36:54 +0800
with message-id <498EFC16.1090704@gnu.org>
and subject line Re: bug#2193: 23.0.90/winxp; crash when closing speedbar
has caused the Emacs bug report #2193,
regarding 23.0.90/winxp; crash when closing speedbar
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
2193: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2193
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 3163 bytes --]
From: lode leroy <lode.leroy@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.90/winxp; crash when closing speedbar
Date: Wed, 4 Feb 2009 14:29:46 +0100
Message-ID: <b41dbf4a0902040529q39dde778n7596e1716d7f1624@mail.gmail.com>
emacs crashes every time I do the following:
go to Options->Show/Hide->speedbar
in the speedbar frame: click modeline->Speedbar->Quit
In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
of 2009-02-01 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
[-- Attachment #3: Type: message/rfc822, Size: 3007 bytes --]
From: Jason Rumney <jasonr@gnu.org>
To: martin rudalics <rudalics@gmx.at>, 2193-done@emacsbugs.donarmstrong.com
Cc: lode leroy <lode.leroy@gmail.com>
Subject: Re: bug#2193: 23.0.90/winxp; crash when closing speedbar
Date: Sun, 08 Feb 2009 23:36:54 +0800
Message-ID: <498EFC16.1090704@gnu.org>
martin rudalics wrote:
> Could you please try the attached patch?
I installed a more comprehensive patch that does more than just avoid
the crash, since I don't think we want to keep displaying an hourglass
in these circumstances.
^ permalink raw reply [flat|nested] 4+ messages in thread