From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: LGLYPH_SET_CODE Date: Fri, 29 Aug 2008 11:44:58 +0300 Message-ID: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1219999539 5920 80.91.229.12 (29 Aug 2008 08:45:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Aug 2008 08:45:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 29 10:46:33 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYzcY-0001nz-1R for ged-emacs-devel@m.gmane.org; Fri, 29 Aug 2008 10:46:18 +0200 Original-Received: from localhost ([127.0.0.1]:51577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYzbZ-0005Hg-9O for ged-emacs-devel@m.gmane.org; Fri, 29 Aug 2008 04:45:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYzbU-0005HZ-Ft for emacs-devel@gnu.org; Fri, 29 Aug 2008 04:45:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYzbT-0005HN-R1 for emacs-devel@gnu.org; Fri, 29 Aug 2008 04:45:11 -0400 Original-Received: from [199.232.76.173] (port=57837 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYzbT-0005HK-MT for emacs-devel@gnu.org; Fri, 29 Aug 2008 04:45:11 -0400 Original-Received: from mtaout7.012.net.il ([84.95.2.19]:35017) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYzbT-0006Nx-6Z for emacs-devel@gnu.org; Fri, 29 Aug 2008 04:45:11 -0400 Original-Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K6C00G82TNV3GC0@i-mtaout7.012.net.il> for emacs-devel@gnu.org; Fri, 29 Aug 2008 11:45:32 +0300 (IDT) X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:103152 Can the second argument to this macro be negative? If so, the current definition: #define LGLYPH_SET_CODE(g, val) \ do { \ if (val == FONT_INVALID_CODE) \ ASET ((g), LGLYPH_IX_CODE, Qnil); \ else if ((EMACS_INT)val > MOST_POSITIVE_FIXNUM) \ ASET ((g), LGLYPH_IX_CODE, Fcons (make_number ((val) >> 16), \ make_number ((val) & 0xFFFF)));\ else \ ASET ((g), LGLYPH_IX_CODE, make_number (val)); \ } while (0) does not handle such values correctly, because their absolute value could be large enough to overflow an EMACS_INT. If negative values are possible, we should use FIXNUM_OVERFLOW_P instead of a comparison with MOST_POSITIVE_FIXNUM.