From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#18334: 24.3.93; ImageMagick: eww shows favicon animations in search results Date: Sun, 14 Sep 2014 20:10:56 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1410739876 6760 80.91.229.3 (15 Sep 2014 00:11:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Sep 2014 00:11:16 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , 18334@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 15 02:11:09 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XTJsq-0003xq-6O for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Sep 2014 02:11:08 +0200 Original-Received: from localhost ([::1]:56555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTJsp-0004wA-Nx for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Sep 2014 20:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTJsl-0004vt-Hg for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 20:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTJsk-0000ns-E7 for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 20:11:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTJsk-0000no-Al for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 20:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XTJsj-0000EU-Tz for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 20:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Sep 2014 00:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18334-submit@debbugs.gnu.org id=B18334.1410739861888 (code B ref 18334); Mon, 15 Sep 2014 00:11:01 +0000 Original-Received: (at 18334) by debbugs.gnu.org; 15 Sep 2014 00:11:01 +0000 Original-Received: from localhost ([127.0.0.1]:41018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTJsi-0000EF-J6 for submit@debbugs.gnu.org; Sun, 14 Sep 2014 20:11:00 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:37644) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTJsg-0000E7-9X for 18334@debbugs.gnu.org; Sun, 14 Sep 2014 20:10:58 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XTJse-0001IM-5W; Sun, 14 Sep 2014 20:10:56 -0400 X-Spook: Belknap ASIO e-cash Albright Lon Horiuchi enemy of the X-Ran: l(ZEy[to0T]*DeVyfAcH~QR (Glenn Morris's message of "Sun, 14 Sep 2014 14:20:48 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93368 Archived-At: >> Should image-multi-frame-p, a new function in 24.4, stop using >> image-default-frame-delay as a default value for DELAY? Or should each >> caller of image-multi-frame-p temporarily let-bind >> image-default-frame-delay to nil if it doesn't want to treat images >> that are missing DELAY value as animations? > > I think I was intending it to work the first way, not the second way > (which sounds a bit yucky?). But I don't seem to have implemented it > right. No idea what I was thinking... I think perhaps I meant to do something like the following, which I applied to emacs-24. However, AFAICS now nothing is animated in eww. Perhaps this is related to shr's preference for ImageMagick and the fact that that backend still does not return a delay (http://debbugs.gnu.org/10747). In theory ImageMagick should be used only when rescaling is needed, but it seems to be used all (?) the time (because in shr-put-image, size is often nil?). --- a/lisp/image.el 2014-02-25 21:59:14 +0000 +++ b/lisp/image.el 2014-09-14 23:59:57 +0000 @@ -637,8 +637,8 @@ (images (plist-get metadata 'count)) (delay (plist-get metadata 'delay))) (when (and images (> images 1)) - (if (or (not (numberp delay)) (< delay 0)) - (setq delay image-default-frame-delay)) + (and delay (or (not (numberp delay)) (< delay 0)) + (setq delay image-default-frame-delay)) (cons images delay)))))