bug#45611: 28.0.50; xterm.c compile anomaly and link failure

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[William C Doughty III]

Looking at the compile output for the master branch,
it appears that Xrender is not being found or the
test for it is buggy.

Needed to manually set HAVE_XRENDER and add -lXrender
to src/Makefile, after this the make compiles xterm.c
cleanly and the link for temacs succeeds.





In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.16.0)
 of 2020-12-28 built on LAPTOP-D3MMH7MQ
Repository revision: 42fb6de0b366622cd59006f69fbc13c5cf3a0714
Repository branch: native-comp
Windowing system distributor 'Choung Networks', version 11.0.20802000
System Description: Generic 32 (Generic)

Configured using:
 'configure --with-nativecomp'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 XDBE XIM MODULES NATIVE_COMP THREADS JSON PDUMPER

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Magit Log

Minor modes in effect:
  semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode)  S)))
  ivy-mode: t
  global-magit-file-mode: t
  magit-auto-revert-mode: t
  global-semantic-decoration-mode: t
  global-semantic-idle-completions-mode: t
  global-semantic-idle-scheduler-mode: t
  global-semantic-idle-summary-mode: t
  ecb-minor-mode: t
  global-semanticdb-minor-mode: t
  global-semantic-highlight-func-mode: t
  global-semantic-stickyfunc-mode: t
  semantic-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-company-mode: t
  company-mode: t
  show-paren-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  shell-dirtrack-mode: t
  epa-global-mail-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow emacsbug sendmail sh-script smie executable ecb-layout-defs
cus-edit image-mode exif man autoconf autoconf-mode find-dired
multiple-cursors-core rect pcmpl-unix semantic/doc
semantic/analyze/complete semantic/tag-file semantic/db-typecache
lsp-sqls lsp-yaml lsp-xml lsp-vhdl lsp-vetur lsp-html lsp-verilog
lsp-terraform lsp-solargraph lsp-serenata lsp-rust lsp-pyls lsp-pwsh
lsp-perl lsp-json lsp-intelephense lsp-haxe lsp-go lsp-gdscript
lsp-fsharp lsp-eslint lsp-erlang lsp-elm lsp-css lsp-csharp lsp-clojure
lsp-clients lsp-mode lsp-protocol tree-widget spinner lv inline ht f s
ewoc dash-functional bindat gnus-fun semantic/edit semantic/bovine/make
semantic/bovine/make-by make-mode ediff-ptch magit-ediff ediff
ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init
ediff-util arc-mode archive-mode novice vc-mtn vc-hg vc-bzr vc-src
vc-sccs vc-svn vc-cvs vc-rcs vc vc-dispatcher tramp tramp-loaddefs
trampver tramp-integration files-x tramp-compat ls-lisp
company-yasnippet ivy delsel colir ivy-overlay semantic/tag-write
magit-extras magit-submodule magit-obsolete magit-blame magit-stash
magit-bisect magit-push magit-pull magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magit-branch magit-fetch forge-list forge-commands forge-semi
forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab
forge-github forge-notify forge-revnote forge-pullreq forge-issue
forge-topic forge-post markdown-mode color noutline outline forge-repo
forge forge-core forge-db closql emacsql-sqlite emacsql emacsql-compiler
magit-reset magit-collab ghub-graphql treepy gsexp ghub url-http url-gw
url-auth let-alist magit-files magit-refs magit-status magit magit-repos
magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode
diff magit-core magit-autorevert autorevert filenotify magit-process
magit-margin magit-mode ffap semantic/db-file data-debug cedet-files
semantic/bovine/c semantic/decorate/include semantic/decorate/mode
semantic/decorate hideif semantic/bovine/c-by semantic/lex-spp
semantic/bovine/gcc semantic/dep semantic/bovine semantic/analyze/refs
cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs asm390prn-mode asm390-mode jcl-mode em-unix em-term term
ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-dirs esh-var
em-cmpl em-basic em-banner em-alias esh-mode eshell esh-cmd esh-ext
esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util flow-fill
html2text sort smiley gnus-cite mm-archive mail-extr gnus-async
gnus-bcklg qp gnus-ml disp-table cursor-sensor utf-7 nndraft nnmh gnutls
nnfolder network-stream nsm gnus-agent gnus-srvr gnus-score score-mode
nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig
nntp gnus-cache gnus-sum shr kinsoku svg dom gnus-group gnus-undo
gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7
netrc nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win
gnus nnheader log4e jka-compr bug-reference semantic/idle eieio-opt
shortdoc cal-coptic cal-julian cal-x help-fns cl-print debug backtrace
pulse misearch multi-isearch grep view cal-china lunar solar cal-dst
cal-bahai cal-islam cal-hebrew holidays hol-loaddefs vc-git diff-mode
diary-lib diary-loaddefs mule-util cal-move cal-seasonal-updates
cal-sanctoral-updates cal-franciscan cal-dominican cal-catholic-diary
cal-benedictine macros dired-aux ecb ecb-symboldef ecb-analyse
ecb-compatibility ecb-winman-support ecb-autogen autoload radix-tree
lisp-mnt ecb-tod ecb-cycle ecb-eshell ecb-help ecb-jde
ecb-method-browser hideshow ecb-semantic-wrapper ecb-semantic
ecb-file-browser ecb-speedbar ecb-layout compile ecb-create-layout
ecb-compilation ecb-common-browser speedbar dframe ecb-navigate
eieio-compat ecb-mode-line ecb-face tree-buffer ecb-upgrade
ecb-cedet-wrapper semantic/db-mode semantic/db-find semantic/db-ref
semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn
semantic/db eieio-base semantic/format ezimage semantic/tag-ls
semantic/find semantic/ctxt semantic/util-modes semantic/util semantic
pp semantic/tag semantic/lex semantic/fw mode-local find-func cedet
wid-edit ecb-util thingatpt cl silentcomp cal-catholic cal-particular
cal-seasonal cal-sanctoral cal-menu calendar cal-loaddefs
yasnippet-classic-snippets yasnippet-snippets yasnippet company-oddmuse
company-keywords company-etags etags fileloop generator xref project
company-gtags company-dabbrev-code company-dabbrev company-files
company-capf company-cmake company-xcode company-clang company-semantic
company-eclim company-template company-bbdb company edmacro kmacro
tango-dark-theme paren git-commit with-editor comp comp-cstr warnings rx
cl-extra help-mode async-bytecomp advice async shell pcomplete comint
ansi-color server magit-git magit-section magit-utils magit-popup
format-spec crm log-edit easy-mmode message rmc puny dired
dired-loaddefs rfc822 mml mml-sec gnus-util rmail rmail-loaddefs
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev
gmm-utils mailheader ring pcvs-util add-log dash epa-mail mail-utils epa
derived epg epg-config cus-start cus-load finder-inf info package
easymenu browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face pcase macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process nativecomp
emacs)

Memory information:
((conses 16 1801081 334307)
 (symbols 48 56394 45)
 (strings 32 293096 33055)
 (string-bytes 1 9211977)
 (vectors 16 157873)
 (vector-slots 8 3035926 446348)
 (floats 8 1773 654)
 (intervals 56 81237 4867)
 (buffers 984 171))
<#secure method=pgpmime mode=sign>

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Eli Zaretskii]

> From: William C Doughty III <n2ocm@optonline.net>
> Date: Sat, 02 Jan 2021 07:20:39 -0500
> 
> 
> Looking at the compile output for the master branch,
> it appears that Xrender is not being found or the
> test for it is buggy.
> 
> Needed to manually set HAVE_XRENDER and add -lXrender
> to src/Makefile, after this the make compiles xterm.c
> cleanly and the link for temacs succeeds.

Please show the part of config.log where it tests for Xrender
availability.

Thanks.

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Eli Zaretskii]

[Please use Reply All to keep the bug address on the CC list.]

> From: William C Doughty III <n2ocm@optonline.net>
> Date: Sat, 02 Jan 2021 10:03:15 -0500
> 
> >> Needed to manually set HAVE_XRENDER and add -lXrender
> >> to src/Makefile, after this the make compiles xterm.c
> >> cleanly and the link for temacs succeeds.
> >
> > Please show the part of config.log where it tests for Xrender
> > availability.
> >
> > Thanks.
> 
> >From the config.log , at least I think that's the section.
> 
> | #define USE_XIM 1
> | #define XRegisterIMInstantiateCallback_arg6 XPointer
> | /* end confdefs.h.  */
> | #include <X11/Intrinsic.h>
> | 	 #include <X11/extensions/Xrender.h>
> | 
> | int
> | main ()
> | {
> | return !XRenderQueryExtension;
> |   ;
> |   return 0;
> | }

Yes, but please show all the rest, starting with "checking for
XRenderQueryExtension in -lXrender" and ending with "$? = ..." after
the test.  The test program is printed _after_ the stuff I want to
see, in particular the error messages that failed the compilation of
the test program.

> configure:14699: checking for cairo >= 1.8.0
> configure:14706: $PKG_CONFIG --exists --print-errors "$CAIRO_MODULE"
> configure:14709: $? = 0
> configure:14723: $PKG_CONFIG --exists --print-errors "$CAIRO_MODULE"
> configure:14726: $? = 0
> configure:14764: result

This the next test, so it is not relevant.

> The below if from the last time I tried a a compile from
> master. This is on a Fedora 32 system after :

Strange, it looks like the test for XRender was not done at all...
On my system that test is between these two:

> checking for inotify_init1... yes
> checking for cairo >= 1.8.0... yes

It says:

  checking for XRenderQueryExtension in -lXrender... yes

Why isn't that test being run on your system?

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Michael Schmidt]

[-- Attachment #1: Type: text/html, Size: 6745 bytes --]

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[William C Doughty III]

Eli Zaretskii <eliz@gnu.org> writes:

> [Please use Reply All to keep the bug address on the CC list.]
>
>> From: William C Doughty III <n2ocm@optonline.net>
>> Date: Sat, 02 Jan 2021 10:03:15 -0500
>> 
>> >> Needed to manually set HAVE_XRENDER and add -lXrender
>> >> to src/Makefile, after this the make compiles xterm.c
>> >> cleanly and the link for temacs succeeds.
>> >
>> > Please show the part of config.log where it tests for Xrender
>> > availability.
>> >
>> > Thanks.
>> 
>> >From the config.log , at least I think that's the section.
>> 
>> | #define USE_XIM 1
>> | #define XRegisterIMInstantiateCallback_arg6 XPointer
>> | /* end confdefs.h.  */
>> | #include <X11/Intrinsic.h>
>> | 	 #include <X11/extensions/Xrender.h>
>> | 
>> | int
>> | main ()
>> | {
>> | return !XRenderQueryExtension;
>> |   ;
>> |   return 0;
>> | }
>
> Yes, but please show all the rest, starting with "checking for
> XRenderQueryExtension in -lXrender" and ending with "$? = ..." after
> the test.  The test program is printed _after_ the stuff I want to
> see, in particular the error messages that failed the compilation of
> the test program.
>
>> configure:14699: checking for cairo >= 1.8.0
>> configure:14706: $PKG_CONFIG --exists --print-errors "$CAIRO_MODULE"
>> configure:14709: $? = 0
>> configure:14723: $PKG_CONFIG --exists --print-errors "$CAIRO_MODULE"
>> configure:14726: $? = 0
>> configure:14764: result
>
> This the next test, so it is not relevant.
>
>> The below if from the last time I tried a a compile from
>> master. This is on a Fedora 32 system after :
>
> Strange, it looks like the test for XRender was not done at all...
> On my system that test is between these two:
>
>> checking for inotify_init1... yes
>> checking for cairo >= 1.8.0... yes
>
> It says:
>
>   checking for XRenderQueryExtension in -lXrender... yes
>
> Why isn't that test being run on your system?

Your guess is as good ( or better ) than mine. I'm not too
familiar with how these scripts work. And as far as config.log
the check for XRenderQueryExyension in -lXrender it's not there
at all.

I just checked the version of autoconf. It's 2.69. So either
This commit borked the config setup. Or somthing else is going
on. As I said backing out this commit make the config and
compile happy. BTW. this commit was the last I saw that
affected configure.ac

Commit follows:

Author:     Paul Eggert <eggert@cs.ucla.edu>
AuthorDate: Fri Jan 1 12:52:55 2021 -0800
Commit:     Paul Eggert <eggert@cs.ucla.edu>
CommitDate: Fri Jan 1 12:58:17 2021 -0800

Parent:     ac8875173a New file scratch_buffer_dupfree.c
Merged:     emacs-27
Contained:  master
Follows:    emacs-27.1 (4105)

Port to Solaris 10

* configure.ac: Instead of AC_CHECK_HEADER, use AC_COMPILE_IFELSE
with X11/Intrinsic.h when checking for X11/extensions/Xrender.h.
This suppresses a bogus "report a bug to bug-gnu-emacs" diagnostic
from 'configure' in Solaris 10.
(SETUP_SLAVE_PTY): Adjust to recent renaming of forkin to
std_in in callproc.c.  Needed on Solaris and Unixware.
* lib-src/Makefile.in (LIB_GETRANDOM, LIBS_ETAGS): New vars,
needed because on Solaris 10 the Gnulib tempname module now needs
the -lrt library for clock_gettime.  Throw in the LIB_GETRANDOM
stuff too while we’re at it; from getrandom.m4 it seems to be
needed for MingW.
(LIBS_MOVE, etags_libs): Use them.
* src/callproc.c [SETUP_SLAVE_PTY]: Include sys/stream.h
and sys/stropts.h, for SETUP_SLAVE_PTY’s definiens.
* src/process.c [NEED_BSDTTY]: Don’t include bsdtty.h; hasn’t been
needed in years.
[USG5_4]: Don’t include sys/stream.h or sys/stropts.h; these
directives havbe been moved to callproc.c because the only use of
SETUP_SLAVE_PTY is there now.

4 files changed, 19 insertions(+), 13 deletions(-)
configure.ac        | 9 +++++++--
lib-src/Makefile.in | 9 +++++++--
src/callproc.c      | 5 +++++
src/process.c       | 9 ---------

modified   configure.ac
@@ -3291,7 +3291,12 @@ AC_DEFUN
 # Check for XRender
 HAVE_XRENDER=no
 if test "${HAVE_X11}" = "yes"; then
-  AC_CHECK_HEADER([X11/extensions/Xrender.h],
+  AC_COMPILE_IFELSE(
+    [AC_LANG_PROGRAM(
+       [[#include <X11/Intrinsic.h>
+	 #include <X11/extensions/Xrender.h>
+       ]],
+       [[return !XRenderQueryExtension;]])],
     [AC_CHECK_LIB([Xrender], [XRenderQueryExtension], [HAVE_XRENDER=yes])])
   if test $HAVE_XRENDER = yes; then
     XRENDER_LIBS="-lXrender"
@@ -4926,7 +4931,7 @@ AC_DEFUN
     AC_DEFINE(FIRST_PTY_LETTER, ['z'])
     AC_DEFINE(PTY_NAME_SPRINTF, [strcpy (pty_name, "/dev/ptmx");])
     dnl Push various streams modules onto a PTY channel.  Used in process.c.
-    AC_DEFINE(SETUP_SLAVE_PTY, [if (ioctl (forkin, I_PUSH, "ptem") == -1) fatal ("ioctl I_PUSH ptem"); if (ioctl (forkin, I_PUSH, "ldterm") == -1) fatal ("ioctl I_PUSH ldterm"); if (ioctl (forkin, I_PUSH, "ttcompat") == -1) fatal ("ioctl I_PUSH ttcompat");], [How to set up a slave PTY, if needed.])
+    AC_DEFINE(SETUP_SLAVE_PTY, [if (ioctl (std_in, I_PUSH, "ptem") == -1) fatal ("ioctl I_PUSH ptem"); if (ioctl (std_in, I_PUSH, "ldterm") == -1) fatal ("ioctl I_PUSH ldterm"); if (ioctl (std_in, I_PUSH, "ttcompat") == -1) fatal ("ioctl I_PUSH ttcompat");], [How to set up a slave PTY, if needed.])
     ;;
 esac
 



<#secure method=pgpmime mode=sign>

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Eli Zaretskii]

> From: William C Doughty III <n2ocm@optonline.net>
> Cc: 45611@debbugs.gnu.org
> Date: Sat, 02 Jan 2021 11:49:08 -0500
> 
> > Strange, it looks like the test for XRender was not done at all...
> > On my system that test is between these two:
> >
> >> checking for inotify_init1... yes
> >> checking for cairo >= 1.8.0... yes
> >
> > It says:
> >
> >   checking for XRenderQueryExtension in -lXrender... yes
> >
> > Why isn't that test being run on your system?
> 
> Your guess is as good ( or better ) than mine. I'm not too
> familiar with how these scripts work. And as far as config.log
> the check for XRenderQueryExyension in -lXrender it's not there
> at all.
> 
> I just checked the version of autoconf. It's 2.69. So either
> This commit borked the config setup. Or somthing else is going
> on. As I said backing out this commit make the config and
> compile happy. BTW. this commit was the last I saw that
> affected configure.ac

I'm not sure this is the culprit.  At least on my system, I still see
the test for Xrender after that commit.

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[William C Doughty III]

Eli Zaretskii <eliz@gnu.org> writes:

>> 
>> Your guess is as good ( or better ) than mine. I'm not too
>> familiar with how these scripts work. And as far as config.log
>> the check for XRenderQueryExyension in -lXrender it's not there
>> at all.
>> 
>> I just checked the version of autoconf. It's 2.69. So either
>> This commit borked the config setup. Or somthing else is going
>> on. As I said backing out this commit make the config and
>> compile happy. BTW. this commit was the last I saw that
>> affected configure.ac
>
> I'm not sure this is the culprit.  At least on my system, I still see
> the test for Xrender after that commit.

If you want I can attach a copy of the config.log and the last
compile I did (compressed of course).
<#secure method=pgpmime mode=sign>

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Eli Zaretskii]

> From: William C Doughty III <n2ocm@optonline.net>
> Cc: 45611@debbugs.gnu.org
> Date: Sat, 02 Jan 2021 12:32:15 -0500
> 
> If you want I can attach a copy of the config.log and the last
> compile I did (compressed of course).

Yes, please.

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Eli Zaretskii]

> From: William C Doughty III <n2ocm@optonline.net>
> Date: Sat, 02 Jan 2021 13:08:25 -0500
> 
> >> From: William C Doughty III <n2ocm@optonline.net>
> >> Cc: 45611@debbugs.gnu.org
> >> Date: Sat, 02 Jan 2021 12:32:15 -0500
> >> 
> >> If you want I can attach a copy of the config.log and the last
> >> compile I did (compressed of course).
> >
> > Yes, please.
> 
> Here ya go, hope this helps to figure out what is going on.

Here's the problem:

  configure:14640: gcc -c  -g3 -O2 -isystem /usr/include/librsvg-2.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/gdk-pixbuf-2.0 -pthread -isystem /usr/include/cairo -isystem /usr/include/pixman-1 -isystem /usr/include/freetype2 -isystem /usr/include/libpng16      conftest.c >&5
  conftest.c:119:10: fatal error: X11/Intrinsic.h: No such file or directory
    119 | #include <X11/Intrinsic.h>
	|          ^~~~~~~~~~~~~~~~~
  compilation terminated.

Your X11 headers seem to be in bad shape.  Maybe you need to
re-install some development package(s)?

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Michael Schmidt]

[-- Attachment #1: Type: text/html, Size: 271 bytes --]

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[William C Doughty III]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: William C Doughty III <n2ocm@optonline.net>
>> Date: Sat, 02 Jan 2021 13:08:25 -0500
>> 
>> >> From: William C Doughty III <n2ocm@optonline.net>
>> >> Cc: 45611@debbugs.gnu.org
>> >> Date: Sat, 02 Jan 2021 12:32:15 -0500
>> >> 
>> >> If you want I can attach a copy of the config.log and the last
>> >> compile I did (compressed of course).
>> >
>> > Yes, please.
>> 
>> Here ya go, hope this helps to figure out what is going on.
>
> Here's the problem:
>
>   configure:14640: gcc -c  -g3 -O2 -isystem /usr/include/librsvg-2.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/gdk-pixbuf-2.0 -pthread -isystem /usr/include/cairo -isystem /usr/include/pixman-1 -isystem /usr/include/freetype2 -isystem /usr/include/libpng16      conftest.c >&5
>   conftest.c:119:10: fatal error: X11/Intrinsic.h: No such file or directory
>     119 | #include <X11/Intrinsic.h>
> 	|          ^~~~~~~~~~~~~~~~~
>   compilation terminated.
>
> Your X11 headers seem to be in bad shape.  Maybe you need to
> re-install some development package(s)?
>

Yup that was definitely it. Installed dev packages for libXt. The compile
now works. I think a new dependency has just been added. The patch I had
a problem with looks like it added it. Things have compiled cleanly in
the past without those libraries (at least with how I was configuring
the emacs compile in the past). Oh well, it's fixed here now.

Thanks muchly for your very able assistance and for all your hard work
on the emacs project.

<#secure method=pgpmime mode=sign>

bug#45611: 28.0.50; xterm.c compile anomaly and link failure

[Eli Zaretskii]

> From: William C Doughty III <n2ocm@optonline.net>
> Cc: 45611@debbugs.gnu.org
> Date: Sat, 02 Jan 2021 15:16:35 -0500
> 
> >     119 | #include <X11/Intrinsic.h>
> > 	|          ^~~~~~~~~~~~~~~~~
> >   compilation terminated.
> >
> > Your X11 headers seem to be in bad shape.  Maybe you need to
> > re-install some development package(s)?
> >
> 
> Yup that was definitely it. Installed dev packages for libXt. The compile
> now works. I think a new dependency has just been added. The patch I had
> a problem with looks like it added it. Things have compiled cleanly in
> the past without those libraries (at least with how I was configuring
> the emacs compile in the past). Oh well, it's fixed here now.

Thanks, I'm therefore closing this bug.