From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Christopher Dimech Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Fri, 11 Dec 2020 19:56:43 +0100 Message-ID: References: <87im9fgm27.fsf@protesilaos.com> <87zh2ozer4.fsf@tcd.ie> <87ft4edret.fsf@protesilaos.com> <87zh2ldgtf.fsf@protesilaos.com> <87k0toof83.fsf@mail.linkov.net> <83wnxo1mcr.fsf@gnu.org> <83v9d81khh.fsf@gnu.org> <83mtyk1hq3.fsf@gnu.org> <87czzgbapt.fsf@protesilaos.com> <83lfe4192f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8609"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, Protesilaos Stavrou , stefankangas@gmail.com, 45068@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 11 20:36:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knoD9-00026M-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 20:36:15 +0100 Original-Received: from localhost ([::1]:59364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knoD8-0000Wd-NA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 14:36:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knnbD-00032x-Di for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 13:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knnbC-00051j-Tn for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 13:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knnbB-0000tp-Rp for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 13:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Dimech Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 18:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.16077130163445 (code B ref 45068); Fri, 11 Dec 2020 18:57:01 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 11 Dec 2020 18:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:42944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knnb5-0000tV-Vj for submit@debbugs.gnu.org; Fri, 11 Dec 2020 13:56:56 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:33003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knnb2-0000tE-0J for 45068@debbugs.gnu.org; Fri, 11 Dec 2020 13:56:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607713003; bh=Nv0nMI8c5ThLoC1o7b++oAwkk1dj4BTxaH/bBDENV4c=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=JCeDHVFDc8CsDBr7n6K3URP/r5Y1xFQTtCvWg1hP3vs2pzeE7B6CdHYrrOEjSsfaR 9rTqudpchGDdwkP1gmI6OErPNCljXyeyogPWBweYXKemwlSKTf403bPRx4NSk+GFR0 ff4CwLA0Ls04ry3jUH+v3hSdxCbLrIYLCxwxZCp8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [213.165.168.94] ([213.165.168.94]) by web-mail.gmx.net (3c-app-mailcom-bs06.server.lan [172.19.170.174]) (via HTTP); Fri, 11 Dec 2020 19:56:43 +0100 Importance: normal Sensitivity: Normal In-Reply-To: <83lfe4192f.fsf@gnu.org> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:8mGoFDlvwwZ/JoeZNy15tMpEQYk1v1FGHTzl3RL/De8IECtFisOGxsY53Wj8hYMky74/O Y5d7UzyEHTSahkCJ7IzHWn0LYo7nD/6BZv/SEXCo57oLsa/gknwVOttwd0rqcu7yW15SJncy7EDd dgWEXEirzi4q2h+9q7BfL+AL/75PaS3gvaPgppaGL2fZG62aL4Mm1DbnOU462X59mcns2qeoc07q 01FjEbTIKMTqY3IXimGR1pvZMSVfIKQ98N1leZ2oMZLSy+7m49RX5HNDs7VbFrpXw27oB3ofWcXI EU= X-UI-Out-Filterresults: notjunk:1;V03:K0:F+xECZnN4U4=:zGzghAulqg8R2CzfzaJohZ KOh3Wm1Kj9vc78z2mmrNVL1svMfD4ctoVy/Yhsf3j/k8uzLrx6RNmmJaT5JHMe+8uPH4ozbYS 4PkDjdRRoE6VV1SayOHyiuZeK8vZOzXjJLDbAYEidJqp2gtCfPs2A4T/sh8KCMFaiR7hLW0ye AGVstWSnr/FY2wQN28Oen4uynvQl5dXRmWSdRU4oPR+qGqQ84E0XbPcwziYGJqeb0EFe94yXx HHfYZE4O4mRyS37LdSswzRI2evPxbfrLQMfgEk69qp+XC0i8ndYfsEd2ctj1mF5w8qktwto12 pX+mobJZFLHS/KUZt2ctRPSLLVhrYvsSj5qyHhLPgE5GaFngXhVv7VVwLeqW5pIXmAiZVMv0q 8/oHgl0VoG8+2NNftNf8P/WjyrpPQh8RK+ScB31MQ5utDZy0BP9WCxZeOoyS/MIivigoNBMDc e6CeU9dmKO/Jz/cxOzOuk0DzUJ4VZRN+RnysMa90VLA5Je4Ln4h+2LdZbIYEH7bwrTeUEP84s g5OOywd6bqDKBbciGLfnvPfCc8zU7cJ1M5GapvNQPAN51GVDK35YFllNtyvD/9A9sIffhwc3O h1IkxmYmrxL2I= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195797 Archived-At: > Sent: Friday, December 11, 2020 at 7:39 PM > From: "Eli Zaretskii" > To: "Protesilaos Stavrou" > Cc: contovob@tcd.ie, 45068@debbugs.gnu.org, stefankangas@gmail.com, juri= @linkov.net > Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward= -incompatible) > > > From: Protesilaos Stavrou > > Cc: Stefan Kangas , juri@linkov.net, > > contovob@tcd.ie, 45068@debbugs.gnu.org > > Date: Fri, 11 Dec 2020 17:53:34 +0200 > > > > >> > What theme-related files need to be byte-compiled, and why? > > >> > > >> I believe the issues involved are explained in some detail in the f= irst > > >> message in this bug report. > > > > > > If they are, I'm missing that. All I see is an assertion that the > > > files must be byte-compiled: > > > > > >> The problem with contributing this new code to Emacs is that it can= not > > >> work if it is placed in ../etc/themes/. Instead, the files need to= be > > >> in a path that handles byte-compilation, like ../lisp/modus-themes/= . > > > > > > I'm probably missing something, and that is what I'm asking to > > > elaborate on. > > > > There now are four *.el files that make up the project: > > > > + modus-themes.el contains all defcustom, color palettes as alists, > > helper functions, and the face specs. > > > > + modus-themes-core.el contains a macro that 'let' binds the > > aforementioned alists around 'custom-theme-set-faces' and > > 'custom-theme-set-variables'. > > > > + modus-{operandi-vivendi}-theme.el contain a 'deftheme' and concomita= nt > > 'provide-theme' referencing each of them and just expand the macro. > > > > - Each of those files has (require 'modus-themes) and > > (eval-when-compile (require 'modus-themes-core)). Though I also > > tried without the eval-when-compile part. > > > > When I attempted to place all four files in etc/themes/ and then start= a > > new 'emacs -Q' session, M-x load-theme RET modus-{operandi,vivendi} > > would throw an error: > > > > Cannot open load file: No such file or directory, modus-themes > > So this is not about byte-compiling, it's about being able to load > some of the files that constitute this group of themes? > > If so, I see several possibilities: > > . make a single file with all the functionalities > . invent a new function custom-require that would search the custom > load-path, and use that instead of 'require' > . don't consider this a "theme", but a normal Lisp package (since it > basically violates the conventions for writing a theme) It is still a theme though. What conventions does it violate, briefly? Not being a single file?