* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight @ 2021-05-26 17:35 pauline-galea 2021-05-27 9:54 ` Philip Kaludercic 0 siblings, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-26 17:35 UTC (permalink / raw) To: Help Gnu Emacs Have loaded emacs with "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" Loaded an elisp file with the following code ;;; * heading 1 ;; brief ;;;; ** subheading 1.1 ;; brief ;;;;; ***subsubheading 1.1.1 ;; brief Then used the command M-x outline-minor-mode Then executed (setq-default outline-minor-mode-highlight 'override) with C-x C-e But the different highlight levels are not being highlighted with different colours. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-26 17:35 "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight pauline-galea @ 2021-05-27 9:54 ` Philip Kaludercic 2021-05-27 13:38 ` pauline-galea 0 siblings, 1 reply; 22+ messages in thread From: Philip Kaludercic @ 2021-05-27 9:54 UTC (permalink / raw) To: pauline-galea; +Cc: Help Gnu Emacs pauline-galea@gmx.com writes: > Have loaded emacs with "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" > > Loaded an elisp file with the following code > > ;;; * heading 1 > ;; brief > ;;;; ** subheading 1.1 > ;; brief > ;;;;; ***subsubheading 1.1.1 > ;; brief > > Then used the command > > M-x outline-minor-mode > > Then executed > > (setq-default outline-minor-mode-highlight 'override) > > with C-x C-e > > But the different highlight levels are not being highlighted with different colours. I am guessing that you should first set outline-minor-mode-highlight then activate outline-minor-mode. Setting a variable directly usually does not perform any changes. -- Philip K. ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 9:54 ` Philip Kaludercic @ 2021-05-27 13:38 ` pauline-galea 2021-05-27 13:47 ` Philip Kaludercic 0 siblings, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-27 13:38 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Help Gnu Emacs > Sent: Thursday, May 27, 2021 at 9:54 PM > From: "Philip Kaludercic" <philipk@posteo.net> > To: pauline-galea@gmx.com > Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > pauline-galea@gmx.com writes: > > > Have loaded emacs with "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" > > > > Loaded an elisp file with the following code > > > > ;;; * heading 1 > > ;; brief > > ;;;; ** subheading 1.1 > > ;; brief > > ;;;;; ***subsubheading 1.1.1 > > ;; brief > > > > Then used the command > > > > M-x outline-minor-mode > > > > Then executed > > > > (setq-default outline-minor-mode-highlight 'override) > > > > with C-x C-e > > > > But the different highlight levels are not being highlighted with different colours. > > I am guessing that you should first set outline-minor-mode-highlight > then activate outline-minor-mode. Setting a variable directly usually > does not perform any changes. - Philip No, that does not work. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 13:38 ` pauline-galea @ 2021-05-27 13:47 ` Philip Kaludercic 2021-05-27 15:07 ` pauline-galea 2021-05-27 17:03 ` pauline-galea 0 siblings, 2 replies; 22+ messages in thread From: Philip Kaludercic @ 2021-05-27 13:47 UTC (permalink / raw) To: pauline-galea; +Cc: Help Gnu Emacs pauline-galea@gmx.com writes: >> I am guessing that you should first set outline-minor-mode-highlight >> then activate outline-minor-mode. Setting a variable directly usually >> does not perform any changes. - Philip > > No, that does not work. I just tried it using my local master checkout I just built this morning, and it worked... Are you sure your major mode initializes outline-minor-mode properly? -- Philip K. ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 13:47 ` Philip Kaludercic @ 2021-05-27 15:07 ` pauline-galea 2021-05-27 17:06 ` Philip Kaludercic 2021-05-27 17:03 ` pauline-galea 1 sibling, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-27 15:07 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Help Gnu Emacs > Sent: Friday, May 28, 2021 at 1:47 AM > From: "Philip Kaludercic" <philipk@posteo.net> > To: pauline-galea@gmx.com > Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > pauline-galea@gmx.com writes: > > >> I am guessing that you should first set outline-minor-mode-highlight > >> then activate outline-minor-mode. Setting a variable directly usually > >> does not perform any changes. - Philip > > > > No, that does not work. > > I just tried it using my local master checkout I just built this > morning, and it worked... Are you sure your major mode initializes > outline-minor-mode properly? It would be beneficial to help me set it up because you seem to have been successful, or there wight be some problems lurking about. What is wrong about Load an elisp file M-x emacs-lisp-mode Execute the following (setq-default outline-minor-mode-highlight 'override) M-x outline-minor-mode > -- > Philip K. > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 15:07 ` pauline-galea @ 2021-05-27 17:06 ` Philip Kaludercic 2021-05-27 17:13 ` pauline-galea 0 siblings, 1 reply; 22+ messages in thread From: Philip Kaludercic @ 2021-05-27 17:06 UTC (permalink / raw) To: pauline-galea; +Cc: Help Gnu Emacs pauline-galea@gmx.com writes: > What is wrong about > > Load an elisp file I guess you mean open, not load as in (load "elisp-file.el") > M-x emacs-lisp-mode > > Execute the following > > (setq-default outline-minor-mode-highlight 'override) Is outline-minor-mode-highlight defined by default? What happens when you do M-x customize-option outline-minor-mode-highlight? > M-x outline-minor-mode -- Philip K. ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 17:06 ` Philip Kaludercic @ 2021-05-27 17:13 ` pauline-galea 0 siblings, 0 replies; 22+ messages in thread From: pauline-galea @ 2021-05-27 17:13 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Help Gnu Emacs > Sent: Friday, May 28, 2021 at 5:06 AM > From: "Philip Kaludercic" <philipk@posteo.net> > To: pauline-galea@gmx.com > Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > pauline-galea@gmx.com writes: > > > What is wrong about > > > > Load an elisp file > > I guess you mean open, not load as in (load "elisp-file.el") Correct, I meant "open" or reading an existing file to an emacs buffer. > > M-x emacs-lisp-mode > > > > Execute the following > > > > (setq-default outline-minor-mode-highlight 'override) > > Is outline-minor-mode-highlight defined by default? What happens when > you do M-x customize-option outline-minor-mode-highlight? > > > M-x outline-minor-mode Have tried that but there is no difference between the different subheading levels. > -- > Philip K. > ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 13:47 ` Philip Kaludercic 2021-05-27 15:07 ` pauline-galea @ 2021-05-27 17:03 ` pauline-galea 2021-05-27 17:34 ` Philip Kaludercic 1 sibling, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-27 17:03 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Help Gnu Emacs > Sent: Friday, May 28, 2021 at 1:47 AM > From: "Philip Kaludercic" <philipk@posteo.net> > To: pauline-galea@gmx.com > Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > pauline-galea@gmx.com writes: > > >> I am guessing that you should first set outline-minor-mode-highlight > >> then activate outline-minor-mode. Setting a variable directly usually > >> does not perform any changes. - Philip > > > > No, that does not work. > > I just tried it using my local master checkout I just built this > morning, and it worked... Are you sure your major mode initializes > outline-minor-mode properly? Do you get different heading colours for the three heading levels below? ;;; * heading 1 ;; brief body ;;;; ** subheading 1.1 ;; brief body ;;;;; *** subsubheading 1.1.1 ;; brief body ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 17:03 ` pauline-galea @ 2021-05-27 17:34 ` Philip Kaludercic 2021-05-27 18:13 ` pauline-galea 0 siblings, 1 reply; 22+ messages in thread From: Philip Kaludercic @ 2021-05-27 17:34 UTC (permalink / raw) To: pauline-galea; +Cc: Help Gnu Emacs [-- Attachment #1: Type: text/plain, Size: 1038 bytes --] pauline-galea@gmx.com writes: >> Sent: Friday, May 28, 2021 at 1:47 AM >> From: "Philip Kaludercic" <philipk@posteo.net> >> To: pauline-galea@gmx.com >> Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> >> Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with >> outline-minor-mode-highlight >> >> pauline-galea@gmx.com writes: >> >> >> I am guessing that you should first set outline-minor-mode-highlight >> >> then activate outline-minor-mode. Setting a variable directly usually >> >> does not perform any changes. - Philip >> > >> > No, that does not work. >> >> I just tried it using my local master checkout I just built this >> morning, and it worked... Are you sure your major mode initializes >> outline-minor-mode properly? > > Do you get different heading colours for the three heading levels below? > > ;;; * heading 1 > ;; brief body > ;;;; ** subheading 1.1 > ;; brief body > ;;;;; *** subsubheading 1.1.1 > ;; brief body Yes, I'll attach a screenshot below. It's not pretty, but I notice a difference. -- Philip K. [-- Attachment #2: Screenshot_2021-05-27_19-33-38.png --] [-- Type: image/png, Size: 49737 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 17:34 ` Philip Kaludercic @ 2021-05-27 18:13 ` pauline-galea 2021-05-27 18:27 ` Stephen Berman 2021-05-27 19:04 ` Philip Kaludercic 0 siblings, 2 replies; 22+ messages in thread From: pauline-galea @ 2021-05-27 18:13 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Help Gnu Emacs > Sent: Friday, May 28, 2021 at 5:34 AM > From: "Philip Kaludercic" <philipk@posteo.net> > To: pauline-galea@gmx.com > Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > pauline-galea@gmx.com writes: > > >> Sent: Friday, May 28, 2021 at 1:47 AM > >> From: "Philip Kaludercic" <philipk@posteo.net> > >> To: pauline-galea@gmx.com > >> Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > >> Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with > >> outline-minor-mode-highlight > >> > >> pauline-galea@gmx.com writes: > >> > >> >> I am guessing that you should first set outline-minor-mode-highlight > >> >> then activate outline-minor-mode. Setting a variable directly usually > >> >> does not perform any changes. - Philip > >> > > >> > No, that does not work. > >> > >> I just tried it using my local master checkout I just built this > >> morning, and it worked... Are you sure your major mode initializes > >> outline-minor-mode properly? > > > > Do you get different heading colours for the three heading levels below? > > > > ;;; * heading 1 > > ;; brief body > > ;;;; ** subheading 1.1 > > ;; brief body > > ;;;;; *** subsubheading 1.1.1 > > ;; brief body > > Yes, I'll attach a screenshot below. It's not pretty, but I notice a > difference. All three subheaditgs look the same to me. That was my point, the result in not pretty and the capability requires more work. For instance, changing the faces would also change those heading highlighting. This does not seem to bother the maintainers whilst expecting other to be ok with it, terning down requests for improvements. > -- > Philip K. > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 18:13 ` pauline-galea @ 2021-05-27 18:27 ` Stephen Berman 2021-05-27 18:36 ` pauline-galea 2021-05-27 19:04 ` Philip Kaludercic 1 sibling, 1 reply; 22+ messages in thread From: Stephen Berman @ 2021-05-27 18:27 UTC (permalink / raw) To: pauline-galea; +Cc: Philip Kaludercic, Help Gnu Emacs On Thu, 27 May 2021 20:13:25 +0200 pauline-galea@gmx.com wrote: >> Sent: Friday, May 28, 2021 at 5:34 AM >> From: "Philip Kaludercic" <philipk@posteo.net> >> To: pauline-galea@gmx.com >> Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> >> Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with >> outline-minor-mode-highlight >> >> pauline-galea@gmx.com writes: >> >> >> Sent: Friday, May 28, 2021 at 1:47 AM >> >> From: "Philip Kaludercic" <philipk@posteo.net> >> >> To: pauline-galea@gmx.com >> >> Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> >> >> Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with >> >> outline-minor-mode-highlight >> >> >> >> pauline-galea@gmx.com writes: >> >> >> >> >> I am guessing that you should first set outline-minor-mode-highlight >> >> >> then activate outline-minor-mode. Setting a variable directly usually >> >> >> does not perform any changes. - Philip >> >> > >> >> > No, that does not work. >> >> >> >> I just tried it using my local master checkout I just built this >> >> morning, and it worked... Are you sure your major mode initializes >> >> outline-minor-mode properly? >> > >> > Do you get different heading colours for the three heading levels below? >> > >> > ;;; * heading 1 >> > ;; brief body >> > ;;;; ** subheading 1.1 >> > ;; brief body >> > ;;;;; *** subsubheading 1.1.1 >> > ;; brief body >> >> Yes, I'll attach a screenshot below. It's not pretty, but I notice a >> difference. > > All three subheaditgs look the same to me. That was my point, the > result in not pretty and the capability requires more work. For > instance, changing the faces would also change those heading > highlighting. This does not seem to bother the maintainers whilst > expecting other to be ok with it, terning down requests for > improvements. After doing `M-: (outline-minor-mode-highlight-buffer)' I see the three headings in different colors. Steve Berman ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 18:27 ` Stephen Berman @ 2021-05-27 18:36 ` pauline-galea 2021-05-27 18:58 ` Stephen Berman 0 siblings, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-27 18:36 UTC (permalink / raw) To: Stephen Berman; +Cc: Philip Kaludercic, Help Gnu Emacs > Sent: Friday, May 28, 2021 at 6:27 AM > From: "Stephen Berman" <stephen.berman@gmx.net> > To: pauline-galea@gmx.com > Cc: "Philip Kaludercic" <philipk@posteo.net>, "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > On Thu, 27 May 2021 20:13:25 +0200 pauline-galea@gmx.com wrote: > > >> Sent: Friday, May 28, 2021 at 5:34 AM > >> From: "Philip Kaludercic" <philipk@posteo.net> > >> To: pauline-galea@gmx.com > >> Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > >> Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with > >> outline-minor-mode-highlight > >> > >> pauline-galea@gmx.com writes: > >> > >> >> Sent: Friday, May 28, 2021 at 1:47 AM > >> >> From: "Philip Kaludercic" <philipk@posteo.net> > >> >> To: pauline-galea@gmx.com > >> >> Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > >> >> Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with > >> >> outline-minor-mode-highlight > >> >> > >> >> pauline-galea@gmx.com writes: > >> >> > >> >> >> I am guessing that you should first set outline-minor-mode-highlight > >> >> >> then activate outline-minor-mode. Setting a variable directly usually > >> >> >> does not perform any changes. - Philip > >> >> > > >> >> > No, that does not work. > >> >> > >> >> I just tried it using my local master checkout I just built this > >> >> morning, and it worked... Are you sure your major mode initializes > >> >> outline-minor-mode properly? > >> > > >> > Do you get different heading colours for the three heading levels below? > >> > > >> > ;;; * heading 1 > >> > ;; brief body > >> > ;;;; ** subheading 1.1 > >> > ;; brief body > >> > ;;;;; *** subsubheading 1.1.1 > >> > ;; brief body > >> > >> Yes, I'll attach a screenshot below. It's not pretty, but I notice a > >> difference. > > > > All three subheaditgs look the same to me. That was my point, the > > result in not pretty and the capability requires more work. For > > instance, changing the faces would also change those heading > > highlighting. This does not seem to bother the maintainers whilst > > expecting other to be ok with it, terning down requests for > > improvements. > > After doing `M-: (outline-minor-mode-highlight-buffer)' I see the three > headings in different colors. > > Steve Berman Why is this all so difficult !!! How do I use "outline-minor-mode-highlight-buffer". It is not an interactive function. Have tried executing with "C-x C-e" but nothing took effect. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 18:36 ` pauline-galea @ 2021-05-27 18:58 ` Stephen Berman 2021-05-27 19:11 ` pauline-galea 0 siblings, 1 reply; 22+ messages in thread From: Stephen Berman @ 2021-05-27 18:58 UTC (permalink / raw) To: pauline-galea; +Cc: Philip Kaludercic, Help Gnu Emacs On Thu, 27 May 2021 20:36:50 +0200 pauline-galea@gmx.com wrote: >> >> > Do you get different heading colours for the three heading levels below? >> >> > >> >> > ;;; * heading 1 >> >> > ;; brief body >> >> > ;;;; ** subheading 1.1 >> >> > ;; brief body >> >> > ;;;;; *** subsubheading 1.1.1 >> >> > ;; brief body >> >> >> >> Yes, I'll attach a screenshot below. It's not pretty, but I notice a >> >> difference. >> > >> > All three subheaditgs look the same to me. That was my point, the >> > result in not pretty and the capability requires more work. For >> > instance, changing the faces would also change those heading >> > highlighting. This does not seem to bother the maintainers whilst >> > expecting other to be ok with it, terning down requests for >> > improvements. >> >> After doing `M-: (outline-minor-mode-highlight-buffer)' I see the three >> headings in different colors. >> >> Steve Berman > > Why is this all so difficult !!! > > How do I use "outline-minor-mode-highlight-buffer". It is not an > interactive function. Have tried executing with "C-x C-e" but nothing > took effect. You can invoke it like I did: type `M-:' (i.e. Alt+:) and at the minibuffer prompt enter `(outline-minor-mode-highlight-buffer)'. But it's supposed to be called by outline-minor-mode when the major mode doesn't support font-lock. Maybe you should file a bug report (`M-x report-emacs-bug'). Steve Berman ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 18:58 ` Stephen Berman @ 2021-05-27 19:11 ` pauline-galea 0 siblings, 0 replies; 22+ messages in thread From: pauline-galea @ 2021-05-27 19:11 UTC (permalink / raw) To: Stephen Berman; +Cc: Philip Kaludercic, Help Gnu Emacs > Sent: Friday, May 28, 2021 at 6:58 AM > From: "Stephen Berman" <stephen.berman@gmx.net> > To: pauline-galea@gmx.com > Cc: "Philip Kaludercic" <philipk@posteo.net>, "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > On Thu, 27 May 2021 20:36:50 +0200 pauline-galea@gmx.com wrote: > > >> >> > Do you get different heading colours for the three heading levels below? > >> >> > > >> >> > ;;; * heading 1 > >> >> > ;; brief body > >> >> > ;;;; ** subheading 1.1 > >> >> > ;; brief body > >> >> > ;;;;; *** subsubheading 1.1.1 > >> >> > ;; brief body > >> >> > >> >> Yes, I'll attach a screenshot below. It's not pretty, but I notice a > >> >> difference. > >> > > >> > All three subheaditgs look the same to me. That was my point, the > >> > result in not pretty and the capability requires more work. For > >> > instance, changing the faces would also change those heading > >> > highlighting. This does not seem to bother the maintainers whilst > >> > expecting other to be ok with it, terning down requests for > >> > improvements. > >> > >> After doing `M-: (outline-minor-mode-highlight-buffer)' I see the three > >> headings in different colors. > >> > >> Steve Berman > > > > Why is this all so difficult !!! > > > > How do I use "outline-minor-mode-highlight-buffer". It is not an > > interactive function. Have tried executing with "C-x C-e" but nothing > > took effect. > > You can invoke it like I did: type `M-:' (i.e. Alt+:) and at the > minibuffer prompt enter `(outline-minor-mode-highlight-buffer)'. But > it's supposed to be called by outline-minor-mode when the major mode > doesn't support font-lock. Maybe you should file a bug report (`M-x > report-emacs-bug'). > > Steve Berman > I figured it out. It is the same as using "C-x C-e" from an elisp file. Have executed your suggested command using "M-:" and still I cannot see a very noticeable differences between heading levels. Thank you. I also think that outline-mode needs a bug report for some changes to be made to the code. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 18:13 ` pauline-galea 2021-05-27 18:27 ` Stephen Berman @ 2021-05-27 19:04 ` Philip Kaludercic 2021-05-27 19:17 ` pauline-galea 1 sibling, 1 reply; 22+ messages in thread From: Philip Kaludercic @ 2021-05-27 19:04 UTC (permalink / raw) To: pauline-galea; +Cc: Help Gnu Emacs pauline-galea@gmx.com writes: > All three subheaditgs look the same to me. That was my point, the > result in not pretty > and the capability requires more work. My bad then, I thought you were saying that the headlines were not highlighted at all. > For instance, changing the > faces would also change > those heading highlighting. This does not seem to bother the > maintainers whilst expecting > other to be ok with it, terning down requests for improvements. I looked over it, and it does seem like a bug, as the wrong face is being applied. My guess is that outline-font-lock-face is returning the wrong face. Did you report this as a proper bug? -- Philip K. ^ permalink raw reply [flat|nested] 22+ messages in thread
* "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 19:04 ` Philip Kaludercic @ 2021-05-27 19:17 ` pauline-galea 2021-05-27 19:22 ` Philip Kaludercic 0 siblings, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-27 19:17 UTC (permalink / raw) To: Philip Kaludercic; +Cc: Help Gnu Emacs > Sent: Friday, May 28, 2021 at 7:04 AM > From: "Philip Kaludercic" <philipk@posteo.net> > To: pauline-galea@gmx.com > Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > pauline-galea@gmx.com writes: > > > All three subheaditgs look the same to me. That was my point, the > > result in not pretty > > and the capability requires more work. > > My bad then, I thought you were saying that the headlines were not > highlighted at all. I was pointing out that different headline levels are not being highlighted differently as the code implies. Thanks for confirming. > > For instance, changing the > > faces would also change > > those heading highlighting. This does not seem to bother the > > maintainers whilst expecting > > other to be ok with it, terning down requests for improvements. > > I looked over it, and it does seem like a bug, as the wrong face is > being applied. My guess is that outline-font-lock-face is returning the > wrong face. > > Did you report this as a proper bug? Have seen some bug reports, only to have the bug reports closed by the maintainers because the p9roblems do not bother them. Would need some help to convince them. You seem to understand what's wrong. > -- > Philip K. > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight 2021-05-27 19:17 ` pauline-galea @ 2021-05-27 19:22 ` Philip Kaludercic 2021-05-27 19:37 ` bug#48707: outline not distinguishing between levels well enough pauline-galea 0 siblings, 1 reply; 22+ messages in thread From: Philip Kaludercic @ 2021-05-27 19:22 UTC (permalink / raw) To: pauline-galea; +Cc: Help Gnu Emacs pauline-galea@gmx.com writes: >> > For instance, changing the >> > faces would also change >> > those heading highlighting. This does not seem to bother the >> > maintainers whilst expecting >> > other to be ok with it, terning down requests for improvements. >> >> I looked over it, and it does seem like a bug, as the wrong face is >> being applied. My guess is that outline-font-lock-face is returning the >> wrong face. >> >> Did you report this as a proper bug? > > Have seen some bug reports, only to have the bug reports closed by the maintainers > because the p9roblems do not bother them. Would need some help to convince them. > > You seem to understand what's wrong. Sure, just Cc me in the bug report. -- Philip K. ^ permalink raw reply [flat|nested] 22+ messages in thread
* bug#48707: outline not distinguishing between levels well enough 2021-05-27 19:22 ` Philip Kaludercic @ 2021-05-27 19:37 ` pauline-galea 2021-05-27 22:44 ` Juri Linkov 0 siblings, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-27 19:37 UTC (permalink / raw) To: 48707; +Cc: Philip Kaludercic outline is supposed to highlight the eight different heading levels in a way that is easy to distinguish between them. I do not see such a capability at this time. Settings up different colours is also quite complicated and confusing. I have originally discussed this on "help-gnu-emacs@gnu.org", who encouraged me to send a bug report. I do not get different heading colours for the three heading levels below. Philip has mentioned the possibility that the wrong face is being applied. --------- test.el -------- ;;; * heading 1 ;; comments ;;;; ** subheading 1.1 ;; comments ;;;;; *** subsubheading 1.1.1 ;; comments Many Thanks Paula > Sent: Friday, May 28, 2021 at 7:22 AM > From: "Philip Kaludercic" <philipk@posteo.net> > To: pauline-galea@gmx.com > Cc: "Help Gnu Emacs" <help-gnu-emacs@gnu.org> > Subject: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight > > pauline-galea@gmx.com writes: > > >> > For instance, changing the > >> > faces would also change > >> > those heading highlighting. This does not seem to bother the > >> > maintainers whilst expecting > >> > other to be ok with it, terning down requests for improvements. > >> > >> I looked over it, and it does seem like a bug, as the wrong face is > >> being applied. My guess is that outline-font-lock-face is returning the > >> wrong face. > >> > >> Did you report this as a proper bug? > > > > You seem to understand what's wrong. > > Sure, just Cc me in the bug report. > > -- > Philip K. > ^ permalink raw reply [flat|nested] 22+ messages in thread
* bug#48707: outline not distinguishing between levels well enough 2021-05-27 19:37 ` bug#48707: outline not distinguishing between levels well enough pauline-galea @ 2021-05-27 22:44 ` Juri Linkov 2021-05-27 23:33 ` pauline-galea 0 siblings, 1 reply; 22+ messages in thread From: Juri Linkov @ 2021-05-27 22:44 UTC (permalink / raw) To: pauline-galea; +Cc: Philip Kaludercic, 48707 [-- Attachment #1: Type: text/plain, Size: 764 bytes --] > outline is supposed to highlight the eight different heading levels in a way that > is easy to distinguish between them. I do not see such a capability at this time. > > Settings up different colours is also quite complicated and confusing. I have originally > discussed this on "help-gnu-emacs@gnu.org", who encouraged me to send a bug report. > > I do not get different heading colours for the three heading levels below. > Philip has mentioned the possibility that the wrong face is being applied. > > --------- test.el -------- > > ;;; * heading 1 > ;; comments > ;;;; ** subheading 1.1 > ;; comments > ;;;;; *** subsubheading 1.1.1 > ;; comments Thank you very much for the bug report. This is really a bug that should be fixed by the following patch: [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: outline-font-lock-keywords.patch --] [-- Type: text/x-diff, Size: 726 bytes --] diff --git a/lisp/outline.el b/lisp/outline.el index fa7c1a27d9..3eb3e21036 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -205,7 +205,8 @@ outline-font-lock-keywords (list 'face (outline-font-lock-face) 'keymap outline-mode-cycle-map) (list 'face nil - 'keymap outline-mode-cycle-map))) + 'keymap outline-mode-cycle-map)) + (list 'face (outline-font-lock-face))) (outline-font-lock-face)) (when outline-minor-mode (pcase outline-minor-mode-highlight ^ permalink raw reply related [flat|nested] 22+ messages in thread
* bug#48707: outline not distinguishing between levels well enough 2021-05-27 22:44 ` Juri Linkov @ 2021-05-27 23:33 ` pauline-galea 2021-05-28 18:59 ` Juri Linkov 0 siblings, 1 reply; 22+ messages in thread From: pauline-galea @ 2021-05-27 23:33 UTC (permalink / raw) To: Juri Linkov; +Cc: Philip Kaludercic, 48707 Thank you for the patch. I have updated outline.el and rebuilt emacs and I can see changes. I am unsure though how to change the heading level colours for different subheading levels, because the headings all look like comments. Regards > Sent: Friday, May 28, 2021 at 10:44 AM > From: "Juri Linkov" <juri@linkov.net> > To: pauline-galea@gmx.com > Cc: 48707@debbugs.gnu.org, "Philip Kaludercic" <philipk@posteo.net> > Subject: Re: bug#48707: outline not distinguishing between levels well enough > > > outline is supposed to highlight the eight different heading levels in a way that > > is easy to distinguish between them. I do not see such a capability at this time. > > > > Settings up different colours is also quite complicated and confusing. I have originally > > discussed this on "help-gnu-emacs@gnu.org", who encouraged me to send a bug report. > > > > I do not get different heading colours for the three heading levels below. > > Philip has mentioned the possibility that the wrong face is being applied. > > > > --------- test.el -------- > > > > ;;; * heading 1 > > ;; comments > > ;;;; ** subheading 1.1 > > ;; comments > > ;;;;; *** subsubheading 1.1.1 > > ;; comments > > Thank you very much for the bug report. This is really a bug > that should be fixed by the following patch: > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* bug#48707: outline not distinguishing between levels well enough 2021-05-27 23:33 ` pauline-galea @ 2021-05-28 18:59 ` Juri Linkov 2021-05-28 19:23 ` pauline-galea 0 siblings, 1 reply; 22+ messages in thread From: Juri Linkov @ 2021-05-28 18:59 UTC (permalink / raw) To: pauline-galea; +Cc: Philip Kaludercic, 48707 tags 48707 fixed close 48707 28.0.50 thanks > Thank you for the patch. I have updated outline.el and rebuilt emacs and I can see > changes. I am unsure though how to change the heading level colours for different > subheading levels, because the headings all look like comments. Thanks for confirming. Now the fix is pushed. ^ permalink raw reply [flat|nested] 22+ messages in thread
* bug#48707: outline not distinguishing between levels well enough 2021-05-28 18:59 ` Juri Linkov @ 2021-05-28 19:23 ` pauline-galea 0 siblings, 0 replies; 22+ messages in thread From: pauline-galea @ 2021-05-28 19:23 UTC (permalink / raw) To: Juri Linkov; +Cc: Philip Kaludercic, 48707 > Sent: Saturday, May 29, 2021 at 6:59 AM > From: "Juri Linkov" <juri@linkov.net> > To: pauline-galea@gmx.com > Cc: 48707@debbugs.gnu.org, "Philip Kaludercic" <philipk@posteo.net> > Subject: Re: bug#48707: outline not distinguishing between levels well enough > > tags 48707 fixed > close 48707 28.0.50 > thanks > > > Thank you for the patch. I have updated outline.el and rebuilt emacs and I can see > > changes. I am unsure though how to change the heading level colours for different > > subheading levels, because the headings all look like comments. > > Thanks for confirming. Now the fix is pushed. I have now been able to view different colours for the different heading levels. ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2021-05-28 19:23 UTC | newest] Thread overview: 22+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-05-26 17:35 "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight pauline-galea 2021-05-27 9:54 ` Philip Kaludercic 2021-05-27 13:38 ` pauline-galea 2021-05-27 13:47 ` Philip Kaludercic 2021-05-27 15:07 ` pauline-galea 2021-05-27 17:06 ` Philip Kaludercic 2021-05-27 17:13 ` pauline-galea 2021-05-27 17:03 ` pauline-galea 2021-05-27 17:34 ` Philip Kaludercic 2021-05-27 18:13 ` pauline-galea 2021-05-27 18:27 ` Stephen Berman 2021-05-27 18:36 ` pauline-galea 2021-05-27 18:58 ` Stephen Berman 2021-05-27 19:11 ` pauline-galea 2021-05-27 19:04 ` Philip Kaludercic 2021-05-27 19:17 ` pauline-galea 2021-05-27 19:22 ` Philip Kaludercic 2021-05-27 19:37 ` bug#48707: outline not distinguishing between levels well enough pauline-galea 2021-05-27 22:44 ` Juri Linkov 2021-05-27 23:33 ` pauline-galea 2021-05-28 18:59 ` Juri Linkov 2021-05-28 19:23 ` pauline-galea
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.
![[-- Attachment #2: Screenshot_2021-05-27_19-33-38.png --] [-- Type: image/png, Size: 49737 bytes --]](../../877djkozc1.fsf@icterid/2-Screenshot_2021-05-27_19-33-38.png){kind=link}