From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Changes in lisp/Makefile.in to skip preloaded files Date: Tue, 06 Oct 2009 12:16:38 -0400 Message-ID: References: <837hv9neza.fsf@gnu.org> <8363asoov2.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1254846726 6111 80.91.229.12 (6 Oct 2009 16:32:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Oct 2009 16:32:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 06 18:31:57 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MvCx6-0002T0-H1 for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2009 18:31:52 +0200 Original-Received: from localhost ([127.0.0.1]:49215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvCx6-0006iD-2a for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2009 12:31:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvCiS-00043Q-2J for emacs-devel@gnu.org; Tue, 06 Oct 2009 12:16:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvCiN-00042D-FR for emacs-devel@gnu.org; Tue, 06 Oct 2009 12:16:43 -0400 Original-Received: from [199.232.76.173] (port=60260 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvCiN-000428-BZ for emacs-devel@gnu.org; Tue, 06 Oct 2009 12:16:39 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:35246) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvCiM-0004R9-S4 for emacs-devel@gnu.org; Tue, 06 Oct 2009 12:16:39 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MvCiM-000174-DZ; Tue, 06 Oct 2009 12:16:38 -0400 X-Spook: fraud Ft. Bragg 64 Vauxhall Cross Treasury event security X-Ran: ~SGX'}TU0bBi8bOE#cU|~$C/PF_R!>"~[N~mGRI>Rlt+VG-[+xU)Xh=|k#+WV8FK}Z-R@g X-Hue: black X-Attribution: GM In-Reply-To: <8363asoov2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Oct 2009 11:25:53 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115931 Archived-At: Eli Zaretskii wrote: >> so this change will now cause autoloads to appear out of date after >> every configure. Is that what you really want? Should autoloads >> depend on src/Makefile.in instead? It need not depend on either, as the comment indicates. That was just to make any error message clear in the unlikely error that src/Makefile was missing. The dependency can just be removed. >> Similar with the preload= thing: why not run Sed on src/Makefile.in? Because Makefile.in does not have the appropriate platform specific list of dumped files, only the generated Makefile does. > I think I see the reason for the latter: it's because src/Makefile.in > spells out $lisp spanned over many lines, whereas src/Makefile has > them all in the same line, which simplifies the job of th Sed script > to some extent. That's just a nice bonus, the real reason is above. > Anyway, I cannot say that I like this solution. In particular, it > cannot be ported to w32, because the list of preloaded files is too > long and overflows the max size of command lines on some Windows > systems (lib-src/makefile.w32-in breaks it into 3 lists for that very > reason). > > I can think about 2 alternatives which are better (IMO): Feel free to change it as you see fit. > P.S. I generally find any Make or shell/Sed trickery misplaced in > Emacs Makefiles, since we have the full power of Emacs at our > fingertips. As Miles has said, sed is already used, along with grep, throughout the Makefiles. It is the simplest tool for this job. BTW, no real harm results if this change is simply never synced to windows.