bug#14349: org-agenda does not handle diary appointments with days

bug#14349: org-agenda does not handle diary appointments with days

[Nic Ferrier]

Sample ~/diary file:

29/7/2000 wedding anniversary
May 13, 2013
  12:00 Meeting, Nic and Pat
Tuesday, May 14, 2013
  11:00 Meeting to be decided.

Now do org-agenda-list, here is what we get:

Month-agenda (W18-W23):
Saturday    4 May 2013
Sunday      5 May 2013
Monday      6 May 2013 W19
Tuesday     7 May 2013
  Diary:      11:00...... Meeting to be decided.
  Diary:      May 14, 2013
Wednesday   8 May 2013
Thursday    9 May 2013
Friday     10 May 2013
Saturday   11 May 2013
Sunday     12 May 2013
Monday     13 May 2013 W20
  Diary:      12:00...... Meeting | Nic and Pat, (GMT) Greenwich Mean Time : Dublin, Edinburgh, Lisbon, London. 
Tuesday    14 May 2013
  Diary:      11:00...... Meeting to be decided.
  Diary:      May 14, 2013
Wednesday  15 May 2013
Thursday   16 May 2013
Friday     17 May 2013
Saturday   18 May 2013
Sunday     19 May 2013
Monday     20 May 2013 W21
Tuesday    21 May 2013
  Diary:      11:00...... Meeting to be decided.
  Diary:      May 14, 2013


The meeting with the specified day name from the diary file is being
inserted at every Tuesday.

Unfortunately, the day-name is standard in the output from
the function calendar-date-string which is used to automatically add
entries to the diary file.

The problem appears unrelated to org-agenda but is something to do with
the way diary mode understands it's entries. You can get the same broken
behaviour viewing the calendar and marking diary entries.


Nic Ferrier

bug#14349: org-agenda does not handle diary appointments with days

[Glenn Morris]

Nic Ferrier wrote:

> Sample ~/diary file:
>
> 29/7/2000 wedding anniversary
> May 13, 2013
>   12:00 Meeting, Nic and Pat
> Tuesday, May 14, 2013
>   11:00 Meeting to be decided.

This example doesn't make sense. The first entry is European format.
The second entry doesn't match anything in diary-european-date-forms.
The third just matches "Tuesday".

So either you need to customize diary-date-forms, or use more standard
diary entries.

bug#14349: org-agenda does not handle diary appointments with days

[Nic Ferrier]

Glenn Morris <rgm@gnu.org> writes:

> Nic Ferrier wrote:
>
>> Sample ~/diary file:
>>
>> 29/7/2000 wedding anniversary
>> May 13, 2013
>>   12:00 Meeting, Nic and Pat
>> Tuesday, May 14, 2013
>>   11:00 Meeting to be decided.
>
> This example doesn't make sense. The first entry is European format.
> The second entry doesn't match anything in diary-european-date-forms.
> The third just matches "Tuesday".
>
> So either you need to customize diary-date-forms, or use more standard
> diary entries.

I disagree.

Take that first entry out and it's the same problem.

The problem is the addition of the day. But the day is added by default
by `calendar-date-string'.

bug#14349: org-agenda does not handle diary appointments with days

[Glenn Morris]

Nic Ferrier wrote:

> Take that first entry out and it's the same problem.

Sure. The first line is simply the only thing that tells me you are
using European date format. It isn't the default and you didn't say.

> The problem is the addition of the day. But the day is added by default
> by `calendar-date-string'.

?

emacs -Q -f calendar
i d
-> May 4, 2013

(no day)

Please give a complete recipe starting from emacs -Q.

bug#14349: org-agenda does not handle diary appointments with days

[Nic Ferrier]

Glenn Morris <rgm@gnu.org> writes:

> Nic Ferrier wrote:
>
>> Take that first entry out and it's the same problem.
>
> Sure. The first line is simply the only thing that tells me you are
> using European date format. It isn't the default and you didn't say.
>
>> The problem is the addition of the day. But the day is added by default
>> by `calendar-date-string'.
>
> ?
>
> emacs -Q -f calendar
> i d
> -> May 4, 2013
>
> (no day)
>
> Please give a complete recipe starting from emacs -Q.

Thanks for taking the time here. I've always found the calendar and
diary to be a bit "difficult".

But I didn't say anything about the diary insert functions available
from calendar. Specifically I called out:

 (calendar-date-string '(05 13 2013)) 
   => "Monday, May 13, 2013"

This is used by the Outlook integration I was referring to on the devel
list:

  https://lists.gnu.org/archive/html/emacs-devel/2013-05/msg00067.html


The reason that function behaves like that is because the function is
supposed to be separately customized with calendar-date-display-form.


You're right, my emacs does have:

  calendar-date-style => 'european

so calendar-date-string should be expected to insert in that style
should it not?


I've tested from -Q and it all looks good, but that makes sense.

When you have:

  calendar-date-style => 'american

and no customization of:

  calendar-date-display-form 

then inserting dates with calender-date-string is fine.

But when you have:

  calendar-date-style => 'european

and no customization of:

  calendar-date-display-form 

then inserting dates with calender-date-string is not fine, it's broken
in the way I described.

Which means we should either tie calendar-date-style and
calendar-date-display-form together or nor use
calendar-date-display-form to insert directly into the diary?


Nic

bug#14349: org-agenda does not handle diary appointments with days

[Glenn Morris]

Version: 24.4

(Please keep the debbugs address cc'd.)

Nic Ferrier wrote:

>  (calendar-date-string '(05 13 2013)) 
>    => "Monday, May 13, 2013"
>
> This is used by the Outlook integration I was referring to on the devel

Then I guess diary-outlook-format-1 needs to pass the NODAYNAME argument
to calendar-date-string.