From: Michael Welsh Duggan <mwd@cert.org>
To: Alan Mackenzie <acm@muc.de>
Cc: Chong Yidong <cyd@stupidchicken.com>,
"5649@debbugs.gnu.org" <5649@debbugs.gnu.org>
Subject: bug#5649: 23.1.92; Indentation problems in C mode
Date: Mon, 01 Mar 2010 10:17:00 -0500 [thread overview]
Message-ID: <tntocj8ul5f.fsf@maru.green.cert.org> (raw)
In-Reply-To: <20100301113832.GA12488@muc.de> (Alan Mackenzie's message of "Mon, 1 Mar 2010 06:38:32 -0500")
Alan Mackenzie <acm@muc.de> writes:
> Hi, Michael and Yidong
>
> On Fri, Feb 26, 2010 at 07:12:06PM -0500, Chong Yidong wrote:
>> Michael Welsh Duggan <mwd@cert.org> writes:
>
>> > I'm getting some screwy indentation behavior from C mode. From a
>> > current bzr checkout/install of emacs, try the following recipe:
>
>> > emacs -Q foo.c | starts emacs on foo.c (included below)
>> > C-u 7 C-n | move down 7 lines
>> > TAB | indent, nothing changes (good)
>> > C-p C-p | move up 2 lines
>> > TAB C-n TAB C-n | indent 2 lines, nothing changes (good)
>> > TAB | line unindents by 2 (bad)
>> > TAB | line re-indents (good, but strange)
>> > TAB | no change this time
>
>> Thanks. This is a regression vs Emacs 23.1, so we should definitely fix
>> it before releasing Emacs 23.2.
>
>> I can reproduce the bug with the Emacs 23.0.90, so it's be around since
>> at lease 12-09 last year. However, I haven't yet had the time to do a
>> proper bisect.
>
> I've just committed the folowing patch, which should fix the bug:
I'm afraid this causes a much more serious bug. Recipe:
emacs -Q
Open a new C-mode file. Then type the following:
#if FOO
#endif
int bar;
For me the following happens: The #endif is not fontified. The "int
bar" is not fontified. The semicolon causes an error. I have verified
that reverting the patch below goes back to the old behavior, so this
patch is what is causing the bug.
> === modified file 'lisp/progmodes/cc-engine.el'
> --- lisp/progmodes/cc-engine.el 2010-02-25 21:21:25 +0000
> +++ lisp/progmodes/cc-engine.el 2010-03-01 11:23:59 +0000
> @@ -2641,7 +2641,8 @@
> ;; (car c-state-cache). There can be no open parens/braces/brackets
> ;; between `good-pos'/`good-pos-actual-macro-start' and (point-max),
> ;; due to the interface spec to this function.
> - (setq pos (if good-pos-actual-macro-end
> + (setq pos (if (and good-pos-actual-macro-end
> + (> in-macro-start good-pos-actual-macro-start))
> (1+ good-pos-actual-macro-end) ; get outside the macro as
> ; marked by a `category' text property.
> good-pos))
>
>
> Thanks for the clean and concise bug report!
--
Michael Welsh Duggan
(mwd@cert.org)
next prev parent reply other threads:[~2010-03-01 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 16:11 bug#5649: 23.1.92; Indentation problems in C mode Michael Welsh Duggan
2010-02-27 0:12 ` Chong Yidong
2010-03-01 11:38 ` Alan Mackenzie
2010-03-01 15:00 ` Chong Yidong
2010-03-01 15:17 ` Michael Welsh Duggan [this message]
2010-03-01 18:04 ` Alan Mackenzie
2010-03-01 18:40 ` Michael Welsh Duggan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tntocj8ul5f.fsf@maru.green.cert.org \
--to=mwd@cert.org \
--cc=5649@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.