Re: 23.0.60; whitespace.el mishap

[Michael Welsh Duggan <mwd@cert.org>]

Rajesh Vaidheeswarran <rv@gnu.org> writes:

> I'll check out the bug. Thanks for the report.
>
> But, I'm a bit confused. Does this crash emacs?

No, sorry.  I was in a rush and forgot to elide the crash portion of the
default bug reporting error message.

> Michael Welsh Duggan wrote:
>> Please describe exactly what actions triggered the bug
>> and the precise symptoms of the bug:
>>
>> Given the c buffer:
>>
>> int main()
>> {
>>     if (1) {
>>         x = foo;
>>     }
>>     return 0;
>> }
>>
>>
>> `M-x whitespace-cleanup' will result in:
>>
>> int main()
>> {
>>     if (1) {
>>         x= foo;
>>     }
>>     return 0;
>> }
>>
>> This is because `whitespace-indentation-regexp' includes a trailing
>> "[^\n\t]", which matches the x.  After `re-search-forward' of
>> `whitespace-cleanup-region' the point is now after the `x'.  In order
>> for the subsequent `delete-horizontal-space' to work, a
>> (forward-char -1) should probably be done, before the
>> `current-indentation' call.
>>
>> In GNU Emacs 23.0.60.2 (i686-pc-linux-gnu, GTK+ Version 2.10.4)
>>  of 2008-02-05 on maru.green.cert.org
>> Windowing system distributor `The X.Org Foundation', version 11.0.70101000
>> configured using `configure  '--prefix=/home/mwd' '--without-toolkit-scroll-bars' '--with-gif=no''
>>
>> Important settings:
>>   value of $LC_ALL: nil
>>   value of $LC_COLLATE: nil
>>   value of $LC_CTYPE: nil
>>   value of $LC_MESSAGES: nil
>>   value of $LC_MONETARY: nil
>>   value of $LC_NUMERIC: nil
>>   value of $LC_TIME: nil
>>   value of $LANG: en_US.UTF-8
>>   value of $XMODIFIERS: @im=none
>>   locale-coding-system: utf-8-unix
>>   default-enable-multibyte-characters: t
>>
>> Major mode: C/l
>>
>> Minor modes in effect:
>>   shell-dirtrack-mode: t
>>   display-time-mode: t
>>   tooltip-mode: t
>>   mouse-wheel-mode: t
>>   menu-bar-mode: t
>>   file-name-shadow-mode: t
>>   global-font-lock-mode: t
>>   font-lock-mode: t
>>   global-auto-composition-mode: t
>>   auto-composition-mode: t
>>   auto-compression-mode: t
>>   line-number-mode: t
>>   abbrev-mode: t
>>
>> Recent input:
>> C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
>> C-n C-n C-n <escape> > C-w C-p C-p C-p C-p C-p C-p 
>> C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-e C-b C-b 
>> C-b C-b C-b SPC C-x C-s C-b C-b SPC C-x C-s C-f C-d 
>> C-x C-s C-a C-SPC C-n <switch-frame> q C-x 4 b <return> C-p C-SPC
>> C-n M-x M-p <return> <switch-frame> SPC <switch-frame> SPC SPC SPC
>> SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC
>> SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC q <switch-frame> C-p C-p
>> C-e C-p 
>> C-e <return> <tab> ( f o r w a r d - c j h a <backspace> <backspace>
>> <backspace> h a r SPC - 1 ) C-x C-s C-u 
>> C-M-x <switch-frame> C-_ C-n <backspace> C-p C-a C-SPC C-n M-x M-p
>> <return> <switch-frame> SPC C-_ <switch-frame> SPC SPC SPC SPC SPC
>> SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC
>> SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC
>> SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC
>> SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC
>> SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC
>> SPC <switch-frame> C-p C-p C-p C-p C-p C-p C-p C-p C-p 
>> C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
>> C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
>> <switch-frame> M-x r e p o r t - e m a c s - 0 <backspace> b <tab>
>> <return>
>>
>> Recent messages:
>> Result: nil
>>
>> Result: nil
>>  [2 times]
>> Result: #<marker at 236 in fooo.c>
>>
>> Result: #<marker in no buffer>
>>
>> Result: #<marker in no buffer>
>>
>>
>>   
>

-- 
Michael Welsh Duggan
(mwd@cert.org)