From: Kenichi Handa <handa@m17n.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: wilde@sha-bang.de, eliz@gnu.org, emacs-devel@gnu.org
Subject: Re: Interactive ucs-insert fails in HEAD
Date: Tue, 13 Oct 2009 14:13:44 +0900 [thread overview]
Message-ID: <tl7skdn6flj.fsf@m17n.org> (raw)
In-Reply-To: <f7ccd24b0910091247u4d2f936ek36a00c2c973d636d@mail.gmail.com> (message from Juanma Barranquero on Fri, 9 Oct 2009 21:47:59 +0200)
In article <f7ccd24b0910091247u4d2f936ek36a00c2c973d636d@mail.gmail.com>, Juanma Barranquero <lekktu@gmail.com> writes:
> My patch is just a workaround so ucs-insert works again. I've already
> asked Handa-san to please take a look at it.
I found that the problem is caused by this name.
SQUARED CJK UNIFIED IDEOGRAPH-89E3
The Lisp reader reads both "89e3" and "89E3" as 89000.0, but
symbols of those names are printed differently:
(format "%S %S" '\89e3 '\89E3)
=> "\\89e3 89E3"
(1) "89E3" should be read as a symbol.
OR
(2) '\89E3 should be printed as \89E3.
I'm not sure which is better.
Anyway, I've just committed uni-name.el that contains
"\89e3" (instead of "89e3"), so the current bug should be
fixed now.
The fix for (1) is this:
--- lread.c.~1.414.~ 2009-09-25 21:43:00.000000000 +0900
+++ lread.c 2009-10-13 13:47:10.000000000 +0900
@@ -3272,7 +3272,7 @@
while (*cp >= '0' && *cp <= '9')
cp++;
}
- if (*cp == 'e' || *cp == 'E')
+ if (*cp == 'e')
{
state |= E_CHAR;
cp++;
And the fix for (2) is this:
--- print.c.~1.259.~ 2009-09-25 21:43:00.000000000 +0900
+++ print.c 2009-10-13 13:40:36.000000000 +0900
@@ -1753,7 +1753,7 @@
{
while (p != end && ((*p >= '0' && *p <= '9')
/* Needed for \2e10. */
- || *p == 'e'))
+ || *p == 'e' || *p == 'E'))
p++;
confusing = (end == p);
}
Stefan and Yidong, please install whichever you think better.
---
Kenichi Handa
handa@m17n.org
next prev parent reply other threads:[~2009-10-13 5:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 9:57 Interactive ucs-insert fails in HEAD Sascha Wilde
2009-10-09 11:32 ` Eli Zaretskii
2009-10-09 11:44 ` Juanma Barranquero
2009-10-09 13:04 ` Juanma Barranquero
2009-10-09 14:47 ` Sascha Wilde
2009-10-09 16:21 ` Eli Zaretskii
2009-10-09 19:47 ` Juanma Barranquero
2009-10-10 7:52 ` Eli Zaretskii
2009-10-10 11:44 ` Juanma Barranquero
2009-10-10 13:14 ` Eli Zaretskii
2009-10-10 14:06 ` Juanma Barranquero
2009-10-13 5:13 ` Kenichi Handa [this message]
2009-10-13 18:46 ` Stefan Monnier
2009-10-15 7:23 ` Kenichi Handa
2009-10-09 19:50 ` Juanma Barranquero
2009-10-10 7:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tl7skdn6flj.fsf@m17n.org \
--to=handa@m17n.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=wilde@sha-bang.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.