From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Thu, 04 Mar 2010 20:24:52 +0900 Message-ID: References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83vddidh73.fsf@gnu.org> <83hbp2cxgx.fsf@gnu.org> <87aauugy1g.fsf@stupidchicken.com> <83eik6co9l.fsf@gnu.org> <87mxyuyvxy.fsf@stupidchicken.com> <87fx4l8mkf.fsf@stupidchicken.com> <831vg5cll1.fsf@gnu.org> <83pr3pb1iu.fsf@gnu.org> <834oky4mkt.fsf@gnu.org> <87635ejy9c.fsf@stupidchicken.com> <83zl2q30pa.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1267701923 19261 80.91.229.12 (4 Mar 2010 11:25:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 4 Mar 2010 11:25:23 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 04 12:25:17 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nn9B6-0007hd-KU for ged-emacs-devel@m.gmane.org; Thu, 04 Mar 2010 12:25:16 +0100 Original-Received: from localhost ([127.0.0.1]:44313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nn9B6-0006Uy-09 for ged-emacs-devel@m.gmane.org; Thu, 04 Mar 2010 06:25:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nn9Ax-0006U3-2O for emacs-devel@gnu.org; Thu, 04 Mar 2010 06:25:07 -0500 Original-Received: from [140.186.70.92] (port=54907 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nn9Av-0006TH-Dy for emacs-devel@gnu.org; Thu, 04 Mar 2010 06:25:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nn9At-00034Z-De for emacs-devel@gnu.org; Thu, 04 Mar 2010 06:25:05 -0500 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:40517) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nn9Ao-000337-Un; Thu, 04 Mar 2010 06:24:59 -0500 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id o24BOrGc021796; Thu, 4 Mar 2010 20:24:53 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp2.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id o24BOrG8005092; Thu, 4 Mar 2010 20:24:53 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp2.aist.go.jp with ESMTP id o24BOqtD012519; Thu, 4 Mar 2010 20:24:53 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1Nn9Ai-0005OB-Ni; Thu, 04 Mar 2010 20:24:52 +0900 In-Reply-To: <83zl2q30pa.fsf@gnu.org> (message from Eli Zaretskii on Tue, 02 Mar 2010 22:53:05 +0200) X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121637 Archived-At: In article <83zl2q30pa.fsf@gnu.org>, Eli Zaretskii writes: > The problem was in two places: in emacs_mule_char and in > decode_coding_emacs_mule (which calls emacs_mule_char). > emacs_mule_char called DECODE_CHAR, which could result in a call to > decode_char, which could call load_charset_map_from_file (through > load_charset). Both emacs_mule_char and decode_coding_emacs_mule walk > through buffer text with pointers, and those need to be fixed-up after > the call to load_charset_map_from_file. > I replaced the call to DECODE_CHAR with CODING_DECODE_CHAR, which > wraps DECODE_CHAR with code that fixes up the pointers to buffer text > if a charset map was loaded by DECODE_CHAR. decode_coding_emacs_mule > needed a similar fixup for its own pointers to buffer text. > This is now fixed in the repository. I think this fixes the original > problem; at least my .emacs.desktop file with a Latin-2 character now > loads correctly, both in the MS-Windows build and in the MS-DOS build. Thank you for fixing it. > Perhaps Handa-san could look at the two other callers of DECODE_CHAR > in coding.c, and see if they, too, need to be replaced with > CODING_DECODE_CHAR. Two other callers of DECODE_CHAR Fdecode_sjis_char and Fdecode_big5_char, and they are ok. --- Kenichi Handa handa@m17n.org