all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cyd@stupidchicken.com, emacs-devel@gnu.org
Subject: Re: Emacs 23.1.93 pretest
Date: Thu, 04 Mar 2010 20:24:52 +0900	[thread overview]
Message-ID: <tl7lje81g8r.fsf@m17n.org> (raw)
In-Reply-To: <83zl2q30pa.fsf@gnu.org> (message from Eli Zaretskii on Tue, 02 Mar 2010 22:53:05 +0200)

In article <83zl2q30pa.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:

> The problem was in two places: in emacs_mule_char and in
> decode_coding_emacs_mule (which calls emacs_mule_char).
> emacs_mule_char called DECODE_CHAR, which could result in a call to
> decode_char, which could call load_charset_map_from_file (through
> load_charset).  Both emacs_mule_char and decode_coding_emacs_mule walk
> through buffer text with pointers, and those need to be fixed-up after
> the call to load_charset_map_from_file.

> I replaced the call to DECODE_CHAR with CODING_DECODE_CHAR, which
> wraps DECODE_CHAR with code that fixes up the pointers to buffer text
> if a charset map was loaded by DECODE_CHAR.  decode_coding_emacs_mule
> needed a similar fixup for its own pointers to buffer text.

> This is now fixed in the repository.  I think this fixes the original
> problem; at least my .emacs.desktop file with a Latin-2 character now
> loads correctly, both in the MS-Windows build and in the MS-DOS build.

Thank you for fixing it.

> Perhaps Handa-san could look at the two other callers of DECODE_CHAR
> in coding.c, and see if they, too, need to be replaced with
> CODING_DECODE_CHAR.

Two other callers of DECODE_CHAR Fdecode_sjis_char and
Fdecode_big5_char, and they are ok.

---
Kenichi Handa
handa@m17n.org




  reply	other threads:[~2010-03-04 11:24 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-27  3:40 Emacs 23.1.93 pretest Chong Yidong
2010-02-27  9:05 ` Eli Zaretskii
2010-02-27 10:21   ` Eli Zaretskii
2010-02-27 11:28     ` Juanma Barranquero
2010-02-27 12:11       ` Juanma Barranquero
2010-02-27 13:15         ` Eli Zaretskii
2010-02-27 14:14           ` Eli Zaretskii
2010-02-27 14:31           ` Andreas Schwab
2010-02-27 14:54             ` Eli Zaretskii
2010-02-27 14:59               ` Lennart Borgman
2010-02-27 15:29                 ` Eli Zaretskii
2010-02-27 15:22           ` Chong Yidong
2010-02-27 18:58             ` Eli Zaretskii
2010-03-04 11:32             ` Kenichi Handa
2010-03-04 12:35               ` Jason Rumney
2010-02-27 15:39           ` Juanma Barranquero
2010-02-27 19:41           ` Stefan Monnier
2010-02-27 11:57     ` Eli Zaretskii
2010-02-27 19:03       ` Eli Zaretskii
2010-02-27 21:37         ` Chong Yidong
2010-02-27 22:22           ` Eli Zaretskii
2010-02-28  1:25             ` Chong Yidong
2010-02-28 17:21               ` Eli Zaretskii
2010-02-28  1:45             ` Chong Yidong
2010-02-28 10:46               ` Andreas Schwab
2010-02-28 14:25                 ` Chong Yidong
2010-02-28 15:38                   ` Andreas Schwab
2010-02-28 17:32                   ` Eli Zaretskii
2010-02-28 19:31                     ` Eli Zaretskii
2010-03-02 18:15                       ` Eli Zaretskii
2010-03-02 19:53                         ` Chong Yidong
2010-03-02 20:53                           ` Eli Zaretskii
2010-03-04 11:24                             ` Kenichi Handa [this message]
2010-02-28 17:34                   ` Eli Zaretskii
2010-02-28 21:34                     ` Chong Yidong
2010-02-28 17:15               ` Eli Zaretskii
2010-03-02 15:42 ` Drew Adams
2010-03-02 16:02   ` Chong Yidong
2010-03-02 18:35     ` Drew Adams
2010-03-02 19:53       ` Chong Yidong
2010-03-04 14:36 ` bug#5679: " Sergei Organov
2010-03-04 15:57   ` Chong Yidong
2010-03-04 17:43     ` osv
2010-03-04 18:06       ` Chong Yidong
2010-03-04 19:22         ` osv
2010-03-09  0:05           ` YAMAMOTO Mitsuharu
2010-03-09  9:57             ` osv
2010-03-09 11:30             ` osv
2010-03-10 11:19           ` YAMAMOTO Mitsuharu
2010-03-10 11:29             ` osv
2010-03-10 11:54               ` YAMAMOTO Mitsuharu
2010-03-10 12:12                 ` osv
2010-03-11  0:38                   ` YAMAMOTO Mitsuharu
2010-03-10  6:23         ` YAMAMOTO Mitsuharu
2010-03-10 10:05           ` osv
  -- strict thread matches above, loose matches on Subject: below --
2010-04-03  1:13 Chong Yidong
2010-04-03  1:34 ` Juanma Barranquero
2010-04-03  2:36   ` Chong Yidong
2010-04-03  2:38     ` Juanma Barranquero
2010-04-03  9:33       ` Eli Zaretskii
2010-04-03 12:45       ` Sean Sieger
2010-04-03 13:53         ` Eli Zaretskii
2010-04-03 15:06         ` Chong Yidong
2010-04-03 15:52           ` Eli Zaretskii
2010-04-03  1:45 ` Sean Sieger
2010-04-03  7:01 ` Eli Zaretskii
2010-04-03  8:26 ` Eli Zaretskii
2010-04-04 19:22 ` Drew Adams
2010-04-05  0:48   ` Sean Sieger
2010-04-11 18:30     ` Uwe Siart
2010-04-11 18:34       ` Uwe Siart
2010-04-05  9:33 ` Eduard Wiebe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tl7lje81g8r.fsf@m17n.org \
    --to=handa@m17n.org \
    --cc=cyd@stupidchicken.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.