From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: record_unwind_save_match_data in autocmp_chars Date: Mon, 05 Oct 2009 09:42:19 +0900 Message-ID: References: <83ab08q0bq.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1254703411 6432 80.91.229.12 (5 Oct 2009 00:43:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2009 00:43:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 05 02:43:25 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mubff-0007SN-9u for ged-emacs-devel@m.gmane.org; Mon, 05 Oct 2009 02:43:23 +0200 Original-Received: from localhost ([127.0.0.1]:54103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mubff-0004Z2-5r for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2009 20:43:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mubew-000460-IY for emacs-devel@gnu.org; Sun, 04 Oct 2009 20:42:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mubep-00041z-8o for emacs-devel@gnu.org; Sun, 04 Oct 2009 20:42:36 -0400 Original-Received: from [199.232.76.173] (port=39889 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mubeo-00041h-On for emacs-devel@gnu.org; Sun, 04 Oct 2009 20:42:31 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:53374) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mubem-0005AW-LO; Sun, 04 Oct 2009 20:42:28 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mubej-0002n3-AS; Sun, 04 Oct 2009 20:42:25 -0400 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id n950gJHJ008216; Mon, 5 Oct 2009 09:42:20 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp4.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id n950gJHV019909; Mon, 5 Oct 2009 09:42:19 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp4.aist.go.jp with ESMTP id n950gJ2X024537; Mon, 5 Oct 2009 09:42:19 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1Mubed-0008JM-B5; Mon, 05 Oct 2009 09:42:19 +0900 In-Reply-To: <83ab08q0bq.fsf@gnu.org> (message from Eli Zaretskii on Sat, 03 Oct 2009 11:43:53 +0200) X-detected-operating-system: by mx20.gnu.org: Solaris 9 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115905 Archived-At: In article <83ab08q0bq.fsf@gnu.org>, Eli Zaretskii writes: > composite.c:autocmp_chars calls record_unwind_save_match_data before > it starts looping on an element of composition-function-table. > However, since the loop calls fast_looking_at, which is documented not > to change match data, is the call to record_unwind_save_match_data > really necessary? If it is still necessary, what other functions > called by autocmp_chars might clobber match data? autocmp_chars calls the Lisp function auto-compose-chars via safe_call, and auto-compose-chars calls Lisp functions registered in composition-function-table. --- Kenichi Handa handa@m17n.org