From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lux Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * lib-src/etags.c: Free variables. Date: Fri, 9 Dec 2022 23:35:42 +0800 Message-ID: References: <83ilikzja5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25419"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 09 16:37:08 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3fQx-0006PX-Gd for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Dec 2022 16:37:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3fQR-0000o4-Q9; Fri, 09 Dec 2022 10:36:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3fPu-0000Td-BK for emacs-devel@gnu.org; Fri, 09 Dec 2022 10:36:06 -0500 Original-Received: from out162-62-58-211.mail.qq.com ([162.62.58.211]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3fPm-00035Z-Ua; Fri, 09 Dec 2022 10:36:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1670600145; bh=n/ap8zFWHX0b6QtobI8aQ87BtSswpJE2pnfUdDTz4nU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=YKPMSHDZxQW9dU7lQw+Oh0uO6XJFd2mnvM45YVyiww9qJAcbi5chs5kDxhrfGiME4 9H6KlKy46XzCD4kDIb+vJP1sQ4CYdP7EImcCL1rhtzpLKXnWeE558JGZkhUP+P3d9f FXWTu5s1fJFgl8gqDEJUmriwIEZ5IKfcptgYqDWE= Original-Received: from lx-pc ([240e:399:e6f:ee32:f815:4044:ba50:97f9]) by newxmesmtplogicsvrszc2-1.qq.com (NewEsmtp) with SMTP id 8EC2E03B; Fri, 09 Dec 2022 23:35:44 +0800 X-QQ-mid: xmsmtpt1670600144tw1dvpp20 X-QQ-XMAILINFO: NB1ivCKmzgb3i9aD285hk069SMC5i5fHe8lawuUDq3bSf1ffpB16GvoSfdZJVc s1AcHhCnScfVbGkmbEg9pMRFoF4gl+kjthAdofSI6IbqirgmLBZk7NOfy8R6xJIZ8bOGIOiOJwN9 SO/9lCrSIY535M0eHM45NfCdMNf9jG0IX9/nN2CJj0OU5hkn3aDeYCP//tKTszwiefIxOWXFYeQN GbewZfm1EmP+mZQyY6MARAVkVAETMQkglYg0GK6B3Bh8Rc20LCGM95v3GRgPwkF/7aC7/fcFDsaR uR87B8rnewYmMUEOxTPj0+9MJtpcRB6G79NAcLABLDd6Uwqn0LyLBdhy3P+r43b8KZKBiqjzaJee sO+/AQHBCOSItU1hBgkqgh7RiKA7ONcx+skb0EaZMue4XcBtwOu1A71ZccpcNl2Ew/iX2qj0q6MD eIVHG8hIXQMzYWTnhJvjKn6kIbKl5nLDdPIh4EQZVUe1vQdoBgmKDsUoMqV00x8SmncOP51VEYGp hLxGMIx8l4mEOWwDzK1FKhg0Bjx6C1w33uhhH2tH6FM3N4nNFfMu43OajIZkbpBNCeEDaRsI6YLf erDzKeB+WgEqHavGUBecB2c3ajM5IAa3n23YwtLDjQ4iS097fp8+nglXCS9Dg+ktYoyio14pUcgN jiwPdKKJqbfww34248P51Fju7yG+R+uzJrg8cPJArDvRFCqSUx1aisOFibsH8TSsRi7r0ZTNJepZ A7Fq2W30PLFYSSzKfOa+dxpbKhs1lkwTMEaqbbup+ezjI3ZcJmJ/GH3HCz17ZxMl8rYcMIVV4Kc5 pKufKh0FFAUVsADhZIPW7cELrieVWwt+bw1uV9dt X-OQ-MSGID: <20221209233542.03de5b1a@lx-pc> In-Reply-To: <83ilikzja5.fsf@gnu.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) Received-SPF: none client-ip=162.62.58.211; envelope-from=lx@shellcodes.org; helo=out162-62-58-211.mail.qq.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301076 Archived-At: On Fri, 09 Dec 2022 17:30:42 +0200 Eli Zaretskii wrote: > > From: lu4nx > > Cc: lu4nx > > Date: Fri, 9 Dec 2022 23:03:04 +0800 > > > > --- > > lib-src/etags.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/lib-src/etags.c b/lib-src/etags.c > > index a06c236140..0822882d46 100644 > > --- a/lib-src/etags.c > > +++ b/lib-src/etags.c > > @@ -1339,6 +1339,8 @@ main (int argc, char **argv) > > "AND read file names from it"); > > while (readline_internal (&filename_lb, stdin, > > "-", false) > 0) process_file_name (filename_lb.buffer, lang); > > + > > + free (filename_lb.buffer); > > } > > else > > process_file_name (this_file, lang); > > @@ -1375,6 +1377,7 @@ main (int argc, char **argv) > > while (nincluded_files-- > 0) > > fprintf (tagf, "\f\n%s,include\n", *included_files++); > > > > + free (*included_files); > > if (fclose (tagf) == EOF) > > pfatal (tagfile); > > } > > @@ -1400,6 +1403,8 @@ main (int argc, char **argv) > > append_to_tagfile = true; > > } > > > > + free (argbuffer); > > + > > tagf = fopen (tagfile, append_to_tagfile ? "ab" : "wb"); > > if (tagf == NULL) > > pfatal (tagfile); > > What is the rationale for these changes? If a variable is not used > until the program exits, there's no need to free it. > Ok, thanks, just added it by the way when reviewing the code.