bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[Xi Lu]

---
 admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
index 9dc674237ca..08a71c1dde1 100755
--- a/admin/notes/tree-sitter/build-module/build.sh
+++ b/admin/notes/tree-sitter/build-module/build.sh
@@ -3,6 +3,12 @@
 lang=$1
 topdir="$PWD"
 
+if [ $# -lt 1 ]
+then
+    echo "Usage: $0 <language>"
+    exit
+fi
+
 case $(uname) in
     "Darwin")
         soext="dylib"
-- 
2.39.1

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[lux]

Xi Lu <lx@shellcodes.org> writes:

> ---
>  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
> index 9dc674237ca..08a71c1dde1 100755
> --- a/admin/notes/tree-sitter/build-module/build.sh
> +++ b/admin/notes/tree-sitter/build-module/build.sh
> @@ -3,6 +3,12 @@
>  lang=$1
>  topdir="$PWD"
>  
> +if [ $# -lt 1 ]
> +then
> +    echo "Usage: $0 <language>"
> +    exit
> +fi
> +
>  case $(uname) in
>      "Darwin")
>          soext="dylib"

This patch need to review. If not give the `language' paramter, some
errors will be printed.

IMHO, Can the batch.sh and build.sh merge to one shell file?

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[lux]

On Sat, 2023-02-18 at 23:27 +0800, lux wrote:
> Xi Lu <lx@shellcodes.org> writes:
> 
> > ---
> >  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/admin/notes/tree-sitter/build-module/build.sh
> > b/admin/notes/tree-sitter/build-module/build.sh
> > index 9dc674237ca..08a71c1dde1 100755
> > --- a/admin/notes/tree-sitter/build-module/build.sh
> > +++ b/admin/notes/tree-sitter/build-module/build.sh
> > @@ -3,6 +3,12 @@
> >  lang=$1
> >  topdir="$PWD"
> >  
> > +if [ $# -lt 1 ]
> > +then
> > +    echo "Usage: $0 <language>"
> > +    exit
> > +fi
> > +
> >  case $(uname) in
> >      "Darwin")
> >          soext="dylib"
> 
> This patch need to review. If not give the `language' paramter, some
> errors will be printed.
> 
> IMHO, Can the batch.sh and build.sh merge to one shell file?

Hi, Yuan Fu, Can you help to look this issue?

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[Eli Zaretskii]

> Cc: casouri@gmail.com
> From: lux <lx@shellcodes.org>
> Date: Sun, 19 Mar 2023 11:57:06 +0800
> 
> On Sat, 2023-02-18 at 23:27 +0800, lux wrote:
> > Xi Lu <lx@shellcodes.org> writes:
> > 
> > > ---
> > >  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/admin/notes/tree-sitter/build-module/build.sh
> > > b/admin/notes/tree-sitter/build-module/build.sh
> > > index 9dc674237ca..08a71c1dde1 100755
> > > --- a/admin/notes/tree-sitter/build-module/build.sh
> > > +++ b/admin/notes/tree-sitter/build-module/build.sh
> > > @@ -3,6 +3,12 @@
> > >  lang=$1
> > >  topdir="$PWD"
> > >  
> > > +if [ $# -lt 1 ]
> > > +then
> > > +    echo "Usage: $0 <language>"
> > > +    exit
> > > +fi
> > > +
> > >  case $(uname) in
> > >      "Darwin")
> > >          soext="dylib"
> > 
> > This patch need to review. If not give the `language' paramter, some
> > errors will be printed.
> > 
> > IMHO, Can the batch.sh and build.sh merge to one shell file?
> 
> Hi, Yuan Fu, Can you help to look this issue?

I don't see a point, as I'm going to delete these scripts very soon.
They did their job and are no longer needed in our repository.

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[Eli Zaretskii]

> Cc: 61366@debbugs.gnu.org, casouri@gmail.com
> Date: Sun, 19 Mar 2023 08:05:46 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Hi, Yuan Fu, Can you help to look this issue?
> 
> I don't see a point, as I'm going to delete these scripts very soon.

Now done.

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[lux]

On Sun, 2023-03-19 at 08:13 +0200, Eli Zaretskii wrote:
> > Cc: 61366@debbugs.gnu.org, casouri@gmail.com
> > Date: Sun, 19 Mar 2023 08:05:46 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > > Hi, Yuan Fu, Can you help to look this issue?
> > 
> > I don't see a point, as I'm going to delete these scripts very
> > soon.
> 
> Now done.
> 
> 
> 

Ok, thank you.

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> > Cc: 61366@debbugs.gnu.org, casouri@gmail.com
> > Date: Sun, 19 Mar 2023 08:05:46 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> >
> > > Hi, Yuan Fu, Can you help to look this issue?
> >
> > I don't see a point, as I'm going to delete these scripts very soon.
>
> Now done.

This bug was left open by accident, so I'm closing it now.

bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.

[Yuan Fu]

lux <lx@shellcodes.org> writes:

> On Sun, 2023-03-19 at 08:13 +0200, Eli Zaretskii wrote:
>> > Cc: 61366@debbugs.gnu.org, casouri@gmail.com
>> > Date: Sun, 19 Mar 2023 08:05:46 +0200
>> > From: Eli Zaretskii <eliz@gnu.org>
>> > 
>> > > Hi, Yuan Fu, Can you help to look this issue?
>> > 
>> > I don't see a point, as I'm going to delete these scripts very
>> > soon.
>> 
>> Now done.
>> 
>> 
>> 
>
> Ok, thank you.

Sorry, I didn’t see this until now. If you have suggestions for the
build script, you can report those at

https://github.com/casouri/tree-sitter-module

Yuan