From: "Shuguang" <shuguang79@qq.com>
To: 32021@debbugs.gnu.org
Subject: bug#32021: hexl-follow-ascii-mode is not initialized
Date: Sun, 1 Jul 2018 01:07:47 +0800 [thread overview]
Message-ID: <tencent_A5E00653093A1D7EC573A4F57B4E8CAC3207@qq.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
Hi,
Windows 7
Emacs git master/2018.6.24 at least
When I try to toggle hexl-mode, it reports
"defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".
It looks like the definiation of hexl-follow-ascii-mode is incorect.
From the doc of define-minor-mode, it requires INIT-VALUE LIGHTER KEYMAP or at least one keyword argument.
According to the DOC of hexl-follow-ascii-mode, I think the following patch should be proper.
diff --git a/lisp/hexl.el b/lisp/hexl.el
index f37be9d410..6b316dd707 100644
--- a/lisp/hexl.el
+++ b/lisp/hexl.el
@@ -1000,6 +1000,7 @@ hexl-follow-ascii-mode
When following is enabled, the ASCII character corresponding to the
element under the point is highlighted.
The default activation is controlled by `hexl-follow-ascii'."
+ :init-value hexl-follow-ascii
(if hexl-follow-ascii-mode
;; turn it on
(progn
Best Regards,
Shuguang Sun
[-- Attachment #2: Type: text/html, Size: 1242 bytes --]
next reply other threads:[~2018-06-30 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 17:07 Shuguang [this message]
2018-06-30 18:00 ` bug#32021: hexl-follow-ascii-mode is not initialized Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_A5E00653093A1D7EC573A4F57B4E8CAC3207@qq.com \
--to=shuguang79@qq.com \
--cc=32021@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.