all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eason Huang <aqua0210@foxmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 55396@debbugs.gnu.org
Subject: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules
Date: Tue, 14 Jun 2022 19:22:15 +0800	[thread overview]
Message-ID: <tencent_97E9DACE668ADCE48B7A4912D2EDC621F806@qq.com> (raw)
In-Reply-To: <af509a35-5e14-157f-54a8-cf0c0c2dd4b3@yandex.ru> (Dmitry Gutov's message of "Tue, 14 Jun 2022 04:03:59 +0300")

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 13.06.2022 18:00, Eason Huang wrote:
>>> Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over
>>> and over again. So it seems like (project--git-submodules) returns a
>>> list which has "." as one of its elements.
>>>
>>> How does that happen? Do you have a submodule entry which points to "."?
>>>
>> I found that it's this line `load-path = .` cause the issue. Borg need
>> this line to add the vertico directory to load-path when user add a
>> subDirectory to load-path. May be it is an issue of Borg?
>
> Now that I've tried adding that locally, it indeed what triggered the
> problem. It was a bug in 'project--git-submodules', which I've just
> fixed on master in commit 915b34d280.
>
> I think file listing together with submodules should work fine now in
> your case. Not sure about the performance though: we use one process
> call per submodule, so the overhead might get noticeable with 42 of
> them. But please give it a try.
>

Great, I tried on my huge .emacs.d project, it works well and fast.

Tested on macOS with latest commit.

You can close this bug now. Thanks for your great work on it.

-- 
Eason Huang





  reply	other threads:[~2022-06-14 11:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 12:56 bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Eason Huang
2022-05-15  1:48 ` Dmitry Gutov
2022-05-15  4:09   ` Eason Huang
2022-06-12 22:17 ` Dmitry Gutov
2022-06-13 15:00   ` Eason Huang
2022-06-14  1:03     ` Dmitry Gutov
2022-06-14 11:22       ` Eason Huang [this message]
2022-06-14 12:47         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_97E9DACE668ADCE48B7A4912D2EDC621F806@qq.com \
    --to=aqua0210@foxmail.com \
    --cc=55396@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.