From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lux Newsgroups: gmane.emacs.bugs Subject: bug#62435: [PATCH] 29.0 Fix eww--download-directory on MS-Windows Date: Sat, 25 Mar 2023 22:17:01 +0800 Message-ID: References: <83bkkhc68v.fsf@gnu.org> <83355tc4fh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-fo9h5+bzVQ6GN5ozruk5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23564"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) Cc: 62435@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 15:18:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg4iw-0005oI-JO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 15:18:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg4ia-0001Jw-GG; Sat, 25 Mar 2023 10:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg4iY-0001Jk-SJ for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg4iY-0002Mh-KT for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg4iY-0008F4-FW for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: lux Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62435-submit@debbugs.gnu.org id=B62435.167975383831604 (code B ref 62435); Sat, 25 Mar 2023 14:18:02 +0000 Original-Received: (at 62435) by debbugs.gnu.org; 25 Mar 2023 14:17:18 +0000 Original-Received: from localhost ([127.0.0.1]:43168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4hp-0008Df-HH for submit@debbugs.gnu.org; Sat, 25 Mar 2023 10:17:17 -0400 Original-Received: from [203.205.251.84] (port=48402 helo=out203-205-251-84.mail.qq.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg4hm-0008DN-B6 for 62435@debbugs.gnu.org; Sat, 25 Mar 2023 10:17:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1679753824; bh=opm2sMdD3NR+vbUIVL1/b/bJwHXI/sb6L6CZej8QZfs=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=VPOYCfZZ89D8onKCV/spE4J/EBJsQWBDq2YFj/YPvhxXN09skM2pWcCoceHby3U3Y T65hTIPE7sWTQJj3kZMCC0yGyscd4jzf3ByOTLAW2lRQqfLCJKdcoo4epDiXSdOXwq vmwGtThk4QpOVnOv5w6mrhW6AuiLZqOZQJZB+iww= Original-Received: from [IPv6:240e:399:e6f:ee32:f815:4044:ba50:97f9] ([240e:399:e6f:ee32:f815:4044:ba50:97f9]) by newxmesmtplogicsvrszc2-1.qq.com (NewEsmtp) with SMTP id 441BE827; Sat, 25 Mar 2023 22:17:01 +0800 X-QQ-mid: xmsmtpt1679753821t3fnuirgk X-QQ-XMAILINFO: N+dGy5Rc27zGMo07G6BnJT7Y+lzYMPxZWE+zkn/tfWMGV1U0Uk2JdrsOMHg2Og gVyXBjjM8/T2PO2Wst1rYpmA6+pnHHQdC0DeEzP15uvOl5gxy/LO8WiMf3LNy0/hDotMC/HbS0d9 bfBnm2ioaKY3umr0QTsT8WPGZe7CPcbca9L5e3XV+ArTxp5iMTYSyRDvZlruDpAaMITpjFlOxWSZ wc9r99I8QI3NMJcG/BeLy+IAN6+lWHE57yoa9iZaMyQnfQSEHVczDS4P6qj6/xMQqu0VeIknfP63 TccOSSwrIm36fzgwLisTrVDF0+y5W+/6Ot46svvZxKMV1mbxvSA1qPzqW2iBN5rUOyvNWDMYC/fj 9FPgFEe1xMSTRzX3KvVfg9JenYNZAPbVtxU1cDYSW0oGwqgo/i+674G+7NmM7ar6Ezumbz8JKMvF 27NPVXfd1buSy/iHKjJErcJuhHplMQ2yRZ6gyqStRYYGlnkIUO1SlZ3fLW+CoRSlauCQGuvNF1aF AKoRBZYRlxDox6iKs/p3vrj+CYxHpNTbdV1WUia8V/ImHYLwF3/PiEoTD3NsHY78Cq8SDucYbu17 7yo/TnnNy2SBKwY94BaKBn3PwQH3CEANBwZbgPgB/dcLLmyScNfNySjJsGWVFha0w8xGgK9y7+v8 N9cFdifmD/lryBqtwOkrOkbjo47VWMScCiKpfN5dAmKynuXblsfpRplCSJPIzNuT6gZyGxoAg5WG 7nSeR5+lEPrRv8BSChU73W8TqbFtP6HDw6n132TTGCUeA7Rip+rMmL6pDjdv3m832dvbyB1PBc90 pTcRSIg5ETr/8jdvfSR1fq1329WGQEweQmjS+zOG X-OQ-MSGID: <2fca027fc0f3bd646b204507671a311f8c53dfe4.camel@shellcodes.org> In-Reply-To: <83355tc4fh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258579 Archived-At: --=-fo9h5+bzVQ6GN5ozruk5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2023-03-25 at 17:05 +0300, Eli Zaretskii wrote: > > From: lux > > Cc: 62435@debbugs.gnu.org > > Date: Sat, 25 Mar 2023 21:42:44 +0800 > >=20 > >=20 > > +(defcustom eww-default-download-directory "~/Downloads/" > > +=C2=A0 "The default directory where downloaded files will be saved." > > +=C2=A0 :version "29.0" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 ^^^^^^ > This should be "30.1". >=20 > > =C2=A0(defun eww--download-directory () > > =C2=A0=C2=A0 "Return the name of the download directory. > > =C2=A0If ~/Downloads/ exists, that will be used, and if not, the > > =C2=A0DOWNLOAD XDG user directory will be returned.=C2=A0 If that's > > =C2=A0undefined, ~/Downloads/ is returned anyway." > > -=C2=A0 (or (and (file-exists-p "~/Downloads/") > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~/Downlo= ads/") > > +=C2=A0 (or (and (file-exists-p eww-default-download-directory) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 eww-defau= lt-download-directory) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (when-let ((dir (xdg-user-dir "DOW= NLOAD"))) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name-as-director= y dir)) > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~/Downloads/")) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 eww-default-download-directory)) >=20 > Please update the doc string as well. >=20 >=20 Done, please review, thank you. --=-fo9h5+bzVQ6GN5ozruk5 Content-Disposition: attachment; filename="0001-Add-eww-default-download-directory.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Add-eww-default-download-directory.patch"; charset="UTF-8" RnJvbSAzZWIzNzA3MjU2MDViNGU2NjU0MjE5NWI1NDY0YzIzYTg5MWY5M2M2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaSBMdSA8bHhAc2hlbGxjb2Rlcy5vcmc+CkRhdGU6IFNhdCwg MjUgTWFyIDIwMjMgMjE6Mzg6NDggKzA4MDAKU3ViamVjdDogW1BBVENIXSBBZGQgYGV3dy1kZWZh dWx0LWRvd25sb2FkLWRpcmVjdG9yeScuCgoqIGxpc3AvbmV0L2V3dy5lbDogQWRkIHZhcmlhYmxl IGBld3ctZGVmYXVsdC1kb3dubG9hZC1kaXJlY3RvcnknLgotLS0KIGxpc3AvbmV0L2V3dy5lbCB8 IDE5ICsrKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCsp LCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0 L2V3dy5lbAppbmRleCA4NTlhOWI0NGJjYi4uOTU1MjEzOGJiNmUgMTAwNjQ0Ci0tLSBhL2xpc3Av bmV0L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTY0LDE2ICs2NCwyMSBAQCBld3ct dXNlLWJyb3dzZS11cmwKICAgOnZlcnNpb24gIjI4LjEiCiAgIDp0eXBlICdyZWdleHApCiAKKyhk ZWZjdXN0b20gZXd3LWRlZmF1bHQtZG93bmxvYWQtZGlyZWN0b3J5ICJ+L0Rvd25sb2Fkcy8iCisg ICJUaGUgZGVmYXVsdCBkaXJlY3Rvcnkgd2hlcmUgZG93bmxvYWRlZCBmaWxlcyB3aWxsIGJlIHNh dmVkLiIKKyAgOnZlcnNpb24gIjMwLjEiCisgIDpncm91cCAnZXd3CisgIDp0eXBlICdzdHJpbmcp CisKIChkZWZ1biBld3ctLWRvd25sb2FkLWRpcmVjdG9yeSAoKQotICAiUmV0dXJuIHRoZSBuYW1l IG9mIHRoZSBkb3dubG9hZCBkaXJlY3RvcnkuCi1JZiB+L0Rvd25sb2Fkcy8gZXhpc3RzLCB0aGF0 IHdpbGwgYmUgdXNlZCwgYW5kIGlmIG5vdCwgdGhlCi1ET1dOTE9BRCBYREcgdXNlciBkaXJlY3Rv cnkgd2lsbCBiZSByZXR1cm5lZC4gIElmIHRoYXQncwotdW5kZWZpbmVkLCB+L0Rvd25sb2Fkcy8g aXMgcmV0dXJuZWQgYW55d2F5LiIKLSAgKG9yIChhbmQgKGZpbGUtZXhpc3RzLXAgIn4vRG93bmxv YWRzLyIpCi0gICAgICAgICAgICJ+L0Rvd25sb2Fkcy8iKQorICAiUmV0dXJuIHRoZSBuYW1lIG9m IHRoZSBkb3dubG9hZCBkaXJlY3RvcnkgYmFzZWQgb24gdGhlIHZhbHVlIG9mCitgZXd3LWRlZmF1 bHQtZG93bmxvYWQtZGlyZWN0b3J5Jy4gSWYgdGhlIHNwZWNpZmllZCBkaXJlY3RvcnkgZXhpc3Rz LCBpdAorIHdpbGwgYmUgdXNlZC4gT3RoZXJ3aXNlLCB0aGUgRE9XTkxPQUQgWERHIHVzZXIgZGly ZWN0b3J5IHdpbGwgYmUgcmV0dXJuZWQuIgorICAob3IgKGFuZCAoZmlsZS1leGlzdHMtcCBld3ct ZGVmYXVsdC1kb3dubG9hZC1kaXJlY3RvcnkpCisgICAgICAgICAgIGV3dy1kZWZhdWx0LWRvd25s b2FkLWRpcmVjdG9yeSkKICAgICAgICh3aGVuLWxldCAoKGRpciAoeGRnLXVzZXItZGlyICJET1dO TE9BRCIpKSkKICAgICAgICAgKGZpbGUtbmFtZS1hcy1kaXJlY3RvcnkgZGlyKSkKLSAgICAgICJ+ L0Rvd25sb2Fkcy8iKSkKKyAgICAgIGV3dy1kZWZhdWx0LWRvd25sb2FkLWRpcmVjdG9yeSkpCiAK IChkZWZjdXN0b20gZXd3LWRvd25sb2FkLWRpcmVjdG9yeSAnZXd3LS1kb3dubG9hZC1kaXJlY3Rv cnkKICAgIkRpcmVjdG9yeSB3aGVyZSBmaWxlcyB3aWxsIGRvd25sb2FkZWQuCi0tIAoyLjM5LjIK Cg== --=-fo9h5+bzVQ6GN5ozruk5--