From: LdBeth <andpuke@foxmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64272@debbugs.gnu.org, LdBeth <andpuke@foxmail.com>,
monnier@iro.umontreal.ca
Subject: bug#64272: 28.1; lisp_file_lexically_bound_p behavior mismatches file local variables
Date: Sun, 25 Jun 2023 19:45:14 -0500 [thread overview]
Message-ID: <tencent_411DFB7A4830E87470AD62FFBEDCA2BB3B09@qq.com> (raw)
In-Reply-To: <tencent_801CA17A56314C746AAC30FFB8DC58BB1109@qq.com>
>>>>> In <tencent_801CA17A56314C746AAC30FFB8DC58BB1109@qq.com>
>>>>> LdBeth <andpuke@foxmail.com> wrote:
ldb> So as I continue digging into lread.c and trying to find alternative
ldb> solutions, I find these:
ldb> DEFSYM (Qget_file_char, "get-file-char");
ldb> /* Used instead of Qget_file_char while loading *.elc files compiled
ldb> by Emacs 21 or older. */
ldb> DEFSYM (Qget_emacs_mule_file_char, "get-emacs-mule-file-char");
ldb> While `get-file-char` is exposed to emacs lisp,
ldb> `get-emacs-mule-file-char' is not even a defined lisp function.
ldb> There are multiple places in `lread.c` that handles
ldb> `Qget_emacs_mule_file_char`. Which I believe it time to consider
ldb> them as dead code and remove them.
Sorry, I misread on how `Qget_emacs_mule_file_char' is been used.
It is still been used internally in `lread.c' because of how READCHAR
works.
ldb> For the only two functions that calls `lisp_file_lexically_bound_p`,
ldb> `load` is hard coded to use `get-file-char` which is a wrapper around
ldb> `getc()`, and `eval-buffer` uses the `BUFFERP (readcharfun)`
ldb> branch in `readchar`. I think both case can be changed to
ldb> use a more flexible way to test file local variables
ldb> rather than stick to the READCHAR UNREAD api.
I think this still holds valid.
---
ldb
prev parent reply other threads:[~2023-06-26 0:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 18:22 bug#64272: 28.1; lisp_file_lexically_bound_p behavior mismatches file local variables LdBeth
2023-06-24 18:52 ` Eli Zaretskii
2023-06-24 19:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 2:11 ` LdBeth
2023-06-25 6:08 ` Eli Zaretskii
2023-06-25 13:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 15:02 ` Eli Zaretskii
2023-06-25 15:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 17:17 ` LdBeth
2023-06-25 18:16 ` Eli Zaretskii
2023-06-25 23:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-26 0:53 ` LdBeth
2023-06-26 11:13 ` Eli Zaretskii
2023-06-26 15:18 ` Gregory Heytings
2023-06-26 15:23 ` Eli Zaretskii
2023-11-21 13:12 ` Gerd Möllmann
2023-06-26 10:59 ` Eli Zaretskii
2023-06-25 23:16 ` LdBeth
2023-06-26 0:45 ` LdBeth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_411DFB7A4830E87470AD62FFBEDCA2BB3B09@qq.com \
--to=andpuke@foxmail.com \
--cc=64272@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.