all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Yi Yue" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Philip Kaludercic" <philipk@posteo.net>
Cc: 70526 <70526@debbugs.gnu.org>
Subject: bug#70526: 29.2; package-vc-upgrade failed with error message "File is not under version control"
Date: Wed, 24 Apr 2024 11:00:32 +0900	[thread overview]
Message-ID: <tencent_1BCBCA866888CE754E21EF0370AEC7352B08@qq.com> (raw)
In-Reply-To: <87pluflvmq.fsf@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

(sorry for the format problem again) &gt; (unrelated, but why do your messages include HTML entities?)  (Sorry, I forgot to forbid the default formatter of my email client.) &gt; My main fear is that this might have some unintended consequences.  Of course.  &gt; I wouldn't want to rely on my understanding of vc either. While it  &gt; would be easy to add a dynamic variable to indicate this behaviour, I am  &gt; careful not to overburden the abstractions that VC provides.  Understand.  I read the docstring of `vc-pull', which is used by `package-vc-upgrade'.  It says:  --------------------------------------------------------------------------  "Update the current fileset or branch.  You must be visiting a version controlled file, or in a `vc-dir' buffer.  ..." --------------------------------------------------------------------------  But `vc-dir' is a user command other than a function, it will open a new buffer and return nil.  In consideration of the fact that `vc-pull' is an async function, it is not easy for us to  kill the `vc-diff' buffer right after the pull operation.  As you suggested earlier, maybe we need to modify vc.el, making the restriction looser?  Also, I noticed that the maintainer bind `default-directory' in this commit:  https://github.com/emacs-mirror/emacs/commit/7ab556b57631cb28db86b89ba296bc0599d9a399  Improve robustness of 'package-vc-update' Regards

[-- Attachment #2: Type: text/html, Size: 1491 bytes --]

  parent reply	other threads:[~2024-04-24  2:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23  1:51 bug#70526: 29.2; package-vc-upgrade failed with error message "File is not under version control" Yi Yue via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-23  8:31 ` Philip Kaludercic
2024-04-23 10:11 ` Yi Yue via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-23 19:35   ` Philip Kaludercic
2024-04-23 21:07     ` Yi Yue via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-24  2:00     ` Yi Yue via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-04-24  6:19       ` Philip Kaludercic
2024-04-24  7:02         ` Yi Yue via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-24  7:51           ` Philip Kaludercic
2024-04-24  8:09             ` o0o0o���� via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-27  7:28               ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_1BCBCA866888CE754E21EF0370AEC7352B08@qq.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=70526@debbugs.gnu.org \
    --cc=include_yy@qq.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.