From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: lux Newsgroups: gmane.emacs.bugs Subject: bug#60562: [PATCH] Fix split-string error if there is a space in the filename. Date: Sat, 7 Jan 2023 17:42:35 +0800 Message-ID: References: <87zgawgfic.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22077"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60562@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 07 10:43:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE5jM-0005aA-4e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Jan 2023 10:43:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pE5jG-0006fF-M0; Sat, 07 Jan 2023 04:43:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE5jC-0006eC-C9 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 04:43:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pE5jC-0006QJ-3Z for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 04:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pE5jB-0001eu-Oq for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 04:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: lux Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2023 09:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60562-submit@debbugs.gnu.org id=B60562.16730845776366 (code B ref 60562); Sat, 07 Jan 2023 09:43:01 +0000 Original-Received: (at 60562) by debbugs.gnu.org; 7 Jan 2023 09:42:57 +0000 Original-Received: from localhost ([127.0.0.1]:56492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE5j7-0001eb-BP for submit@debbugs.gnu.org; Sat, 07 Jan 2023 04:42:57 -0500 Original-Received: from out203-205-221-236.mail.qq.com ([203.205.221.236]:43906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE5j3-0001e6-Un for 60562@debbugs.gnu.org; Sat, 07 Jan 2023 04:42:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1673084559; bh=lAd5WuEpctoyQr3cAmgwd2Itvs5edjj3PLxZEZlXZbs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=aooBvM43wWAQJnIcNXADntN4djgTrd7SOGJz2KVU1YMSAE8Q1eG1XKIrvgFW7REYU soaSU/mMskHsVO7pf0xlRhU7gw6rq+GeGomxTVp4STQ3uLCeZMbe9w5gtd7taS8JHv 7Lj2FxOKbRHem+LLiKBp/+JcUsC49kfCgJIJgkjo= Original-Received: from lx-pc ([240e:399:e6f:ee32:f815:4044:ba50:97f9]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id AA602677; Sat, 07 Jan 2023 17:42:38 +0800 X-QQ-mid: xmsmtpt1673084558t9jpf43kz X-QQ-XMAILINFO: Ms5xyImz3IR/UmfKosRJPwPSGpeWXhi7BIPHFoBKiweququhQnwL0iZNbggRrr VX38lb3IkcidoBMnZ9sIqoyCb+Q9+Pg/Zwnrnh1dT1bmhdVc7otYG5/0mQMhp/rO85/ZKjcdZ4BR QJidcJT4gxXWd2xMPpZIpOb9UadDtQM0tSNoQUfgz/HlXcZedbtGL0+WIBtGrgt73fSg3968QUSL lW3wuWwu9hc3g6bFHaBnPpj1TEW8k2n11Lzb9+ZIfBiCtfvTgUu+o5c1baPUZ0YGPT1KHHw+0MVP RIp9/JZctXWU5sGii1ifDfpngbd07wVpdyDNbFUMT4ZDnZUI8NCol/nLPGNle6rVgnNMl1bZ3sFJ wfz6lyEHZV3nzHP6Rk00BnUV2zAwk7fTf8or0Iq3Xl9lrNYEfhtAOO9Q8UJdyJtVbj3JENzEtiRB faOfpvXcDyFbMAPICez8Gha+w9PXeKVfomIncX8v3Ry8vzT6/VGGoNNSWYQLs0KIL2/6aYKH13of f4xdb8iQXfwH2xGBaP5TruzKHMlmdcLZ/H5erW8tQ3urgjP9QCYad1c6Eoe0aCGybVjKjKGgV7aE DmJONAuBX5zktd+uW0X55sHHZk7yHopKB0Ocxus49ixZynG/L0yA1eigj1HT6W7ZHV6fay0uYdHY I0bxIn/FbB4pP5EMkFMxfsw23GHIbFNJBBCHEO3cTWOU3nSW9J2UpQIqCDG5DG+YUypPdkKlmfXY dbODP3qSO+aezIlTapXi1dgDzIaPmGK/gcuh8Rv4yrTuIqn7G4id2TZWO9mBWxhXX5iebxWk7ngQ kaOqT9DPlwgp6JQJeDK1XRUiiaA6A9qAa2apgBM6 X-OQ-MSGID: <20230107174235.5ff2050d@lx-pc> In-Reply-To: <87zgawgfic.fsf@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252778 Archived-At: On Fri, 06 Jan 2023 10:48:43 +0100 Robert Pluim wrote: > >>>>> On Thu, 5 Jan 2023 06:56:05 +0800, lux > >>>>> said: > > lux> * lisp/htmlfontify.el (hfy-list-files): Specify separator > lux> (\n\r). --- > lux> lisp/htmlfontify.el | 5 +++-- > lux> 1 file changed, 3 insertions(+), 2 deletions(-) > > lux> diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el > lux> index c989a12d205..be020b6b1c5 100644 > lux> --- a/lisp/htmlfontify.el > lux> +++ b/lisp/htmlfontify.el > lux> @@ -1826,8 +1826,9 @@ hfy-list-files > lux> ;;(message "hfy-list-files");;DBUG > lux> ;; FIXME: this changes the dir of the current buffer. Is > lux> that right?? (cd directory) > lux> - (mapcar (lambda (F) (if (string-match "^./\\(.*\\)" F) > lux> (match-string 1 F) F)) > lux> - (split-string (shell-command-to-string > lux> hfy-find-cmd))) ) > lux> + (remove-if #'string-empty-p > lux> + (mapcar (lambda (F) (if (string-match > lux> "^./\\(.*\\)" F) (match-string 1 F) F)) > lux> + (split-string (shell-command-to-string > lux> hfy-find-cmd) "[\n\r]+")) )) > > You can avoid the issue (and improve portability) by using > `directory-files-recursively' instead of `find' But `hfy-find-cmd' is a configurable variable: (defcustom hfy-find-cmd "find . -type f \\! -name \\*~ \\! -name \\*.flc \\! -path \\*/CVS/\\*" "Find command used to harvest a list of files to attempt to fontify." :tag "find-command" :type '(string)) I don't know if using `directory-files-recursively' has other effects.