From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CLSsLRmGvGLu9gAAbAwnHQ (envelope-from ) for ; Wed, 29 Jun 2022 19:04:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kA68LBmGvGI9IQAAG6o9tA (envelope-from ) for ; Wed, 29 Jun 2022 19:04:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 502799A95 for ; Wed, 29 Jun 2022 19:04:25 +0200 (CEST) Received: from localhost ([::1]:47080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6b71-0007Xh-Rp for larch@yhetil.org; Wed, 29 Jun 2022 13:04:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6b54-0007Ux-8m for emacs-orgmode@gnu.org; Wed, 29 Jun 2022 13:02:22 -0400 Received: from ciao.gmane.io ([116.202.254.214]:46646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6b52-0002WW-L3 for emacs-orgmode@gnu.org; Wed, 29 Jun 2022 13:02:21 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1o6b4z-0004hE-S5 for emacs-orgmode@gnu.org; Wed, 29 Jun 2022 19:02:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: Proposal: 'executable' org-capture-templaes Date: Thu, 30 Jun 2022 00:02:11 +0700 Message-ID: References: <87fskrobiw.fsf@localhost> <87a6ay1enh.fsf@localhost> <87edzvdb44.fsf@localhost> <878rpu5qf4.fsf@localhost> <87zgi7357y.fsf@localhost> <875ykuslpx.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656522265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1NJ9DUZeApC7u9wiee6FHs8Efx+hwg/Df8Pj+M0l7ws=; b=hRsl/kc9czzBSg9JPvG9rQ7VrZ82G6GHPPAIxudcjHgH+sldPLHIk+1ZpGe91JrkV9qtOO i2FuAMChSJ6uOC8cZ5NEIcMle1Y0WfOeYtNyGQ1sQhEtxLmHxGO5dx2ETZ1onWPK4Mv+V4 ByQQXQBs8Z8nKNNPuTIvPjkJTrDGS4Ma9E81ktVtf0Ma5p9aVIkhLFHPdC63Lv2rTmU/JN 5Tjs4HNBecYpmTLAer3ahtvc7MSryTEkUvJ8DHVYD+5k1s/LM7y/LKqdmJXZ5a7b2Ja3vk qy20fgfolafIbZbLckqHYygCb/WqQvDrS2jMfRV+OOGg4pzubEilOOS366adew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656522265; a=rsa-sha256; cv=none; b=IH/C5jF6zH1slA3fZ6b6TeWyCIdWOkutzx2dPVY8xx9ZBcVIuru3QbTpD3SIx0rxaaL1dc Rv0wy/Hh93R3nLxv20rnD84tdoeHoJrc2yubK9CZh7EK4vPnp/CKc/liZP2mEoE0kIrAUt 0CfaTF/cOvLREzRmelPu28Rpna81MOF2Mr0Ed484Z5IKZxkTOyy18/SKn6oMPLCZSBUHip jvE4Qz1EgtbU0o/dGgCW5j9ps8cOWwo9i4WFPc8l7x/olJUz6B+2zAB/TRtlrTZrjIuNpz DhKDQg0WtakFqHTaPiSqHSFplFDb2ZxntmG/HivDLaHlIdxCOKP+57yDHJVUwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.74 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 502799A95 X-Spam-Score: 2.74 X-Migadu-Scanner: scn0.migadu.com X-TUID: xjra2qsajVAp On 26/06/2022 11:50, Arthur Miller wrote: > Max Nikulin writes: >> >> By state I mean some structure opaque to menu package. It just receives it from >> caller as an optional argument and (when given) later passes it to >> handler. Maybe it is alien approach in LISP, but in C (where closures are >> impossible) it is a widely used technique. Functions having callback argument >> usually have another void* one that is later passed as an argument of the >> callback function in addition to other data. > > I understand, I have done my share of C, and know what you mean. Say > posix thread will take a void* to user data, and pass it on. This is > exactly what this is about. It is just that we don't need an extra > structure to pass around. We have a menu entry, which *is* the user > data. You a right, it is not strictly necessary that menu should be aware of state. I expect some helper though, e.g. ;;; -*- lexical-binding: t; -*- (defun org-menu-multiinstance-stateful (menus &rest args) (let* ((buffer-name (or (plist-get args :buffer-name) "*Select menu*")) (state (plist-get args :state)) (handler (plist-get args :handler)) (handler-closure (and handler state (lambda (entry &rest _) (funcall handler entry state))))) (when state (org-plist-delete args :state)) (when handler (org-plist-delete args :handler)) (plist-put args :buffer-name (generate-new-buffer-name buffer-name)) (apply #'org-select (if handler-closure (mapcar (lambda (menu) (append menu (list :org-select-handler handler-closure))) menus) menus) args))) (provide 'org-multimenu) To be able to call menu as (load (expand-file-name "org-multimenu")) (org-menu-multiinstance-stateful `((("1" "one" 1) ("2" "two" 2))) :state (format-time-string "%T") :text "Some heading" :buffer-name "*Test menu*" :handler (lambda (entry state) (org-select-quit) ; it does not kill the buffer (message "handler %S %S" entry state))) I do not like how to closures are represented in elisp stack traces (e.g. JavaScript engines in browsers tries hard to give some debug names for anonymous functions). It should not be a problem when passed handler is a named function (not a lambda) despite closure in the adjacent frame. However I would expect that menu handler is not aware if menu is implemented using buffers. From my point of view handler should not have buffer argument. What I missed in your current implementation is ability to change text of menu entries in response to action. E.g. "C-c C-e" ox dispatcher has some options and user should see current values. P.S. I am sorry for long delay.