From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KD0FNondsWIa0AAAbAwnHQ (envelope-from ) for ; Tue, 21 Jun 2022 17:02:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cKINNYndsWI8TwEAG6o9tA (envelope-from ) for ; Tue, 21 Jun 2022 17:02:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1CE83B1C2 for ; Tue, 21 Jun 2022 17:02:33 +0200 (CEST) Received: from localhost ([::1]:47708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3fOi-0002m2-Aa for larch@yhetil.org; Tue, 21 Jun 2022 11:02:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3fO0-0002kW-Ul for emacs-orgmode@gnu.org; Tue, 21 Jun 2022 11:01:53 -0400 Received: from ciao.gmane.io ([116.202.254.214]:56490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3fNx-0001fK-UO for emacs-orgmode@gnu.org; Tue, 21 Jun 2022 11:01:47 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1o3fNv-0004QV-KI for emacs-orgmode@gnu.org; Tue, 21 Jun 2022 17:01:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH v3] ol.el: add description format parameter to org-link-parameters Date: Tue, 21 Jun 2022 22:01:38 +0700 Message-ID: References: <87zgl1npow.fsf@localhost> <20220405192931.6747-1-hugo@heagren.com> <87a6cx79xn.fsf@localhost> <87zgi6fckr.fsf@heagren.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US In-Reply-To: <87zgi6fckr.fsf@heagren.com> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655823753; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=kAqVpiEfFNoWocamQ+xFwnb89WMqfAaE9KW1gPOr0Hg=; b=MWWkbi3Z6sQGpTwRmDLxR2jCHX9R9XIMsYrbwI6xjzwSi85XllH07wQEMd8jDucXpEI0UU fjttYOXSot8pECneYlFRZHS/09vXlMzqpm2xHphJYbYtqp5aIUMdQkiWHPyYYTu8PGIe/2 xD8XAKKJwMtqgtgZboyg6G2RFgBUho2V3FZTh1aGa/wyPK1VSApptTSf8CQdKHxhfL2bFb 8g7CNOlAAtbjBf5rg2UUKJ77JCqlJ/ZvTW34zpPHLWje5BadNO+BgX9rUq04963uilZud6 Zh/lk/sdhpTPUiN8jCpVkkhF7JftMA71qtMT38cJT00zvZeAfQKxcCudmLBm4g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655823753; a=rsa-sha256; cv=none; b=NJnb27ToZef9SAhPbOzslbUj9bF9kausK2h23Icw+iCFSJO1r1z6ZIMbH7k61RlO6KC45g QW4gsEavDabID4tfyG5JKyYv3XDDBzH9By1ewACM2OKn2XZPfionRzt0spqOk4C9Rb9svP nAqeJ32u6Smz9mzJq3M/rMXgpabSwE351Ud4BbNYXxzGPTSykzRQxXhLFml8y8gchvZ6PF bv3Zj4dKCi4njBuWf0gxn6K60BLuXr7X/mC4AeI6H8SBJrJTed5Qq2KVNoaoFmYdKtwcBh 3qvj0ulGHHun4PThHied4oAmJWrDdcTVpKWtGi/jUU1KhfrbSV2S8lFFx8G4Wg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A1CE83B1C2 X-Spam-Score: 3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: 57QNnEbnBmyA On 21/06/2022 19:03, Hugo Heagren wrote: > +(defmacro test-ol-with-link-parameters-as (type parameters &rest body) [...] > + `(progn > + (setq orig-parameters org-link-parameters) I can easily miss something, but wouldn't it be enough to use let-binding `(let ((org-link-parameters org-link-parameters)) ,@body) Otherwise it is better to use something like `condition-case' to restore original state even when some error is signaled. > + (org-link-set-parameters ,type ,@parameters) > + (let ((rtn (progn ,@body))) > + (setq org-link-parameters orig-parameters) > + rtn)))