org mobile - pre hooks

org mobile - pre hooks

[Richard Riley]

Could I suggest that org-mobile-pre-push-hook is processed at the start
of the org-mobile-push function before the checks? That way it can be
used to properly setup mobile e.g using auth-source for the mobile
password.

  (add-hook 'org-mobile-pre-push-hook 
              '(lambda()
                 (setq org-mobile-encryption-password (funcall (plist-get (car (auth-source-search :host '("orgmobile"))) ':secret)))))
  

Re: org mobile - pre hooks

[Bastien]

Hi Richard,

Richard Riley <rileyrg@googlemail.com> writes:

> Could I suggest that org-mobile-pre-push-hook is processed at the start
> of the org-mobile-push function before the checks? That way it can be
> used to properly setup mobile e.g using auth-source for the mobile
> password.

This trivial patch will perhaps do.  I'm not using org-mobile.el so
please let me know if there are any side-effects.

Thanks,

-- 
 Bastien

Re: org mobile - pre hooks

[Bastien]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi Richard,

Richard Riley <rileyrg@googlemail.com> writes:

> Could I suggest that org-mobile-pre-push-hook is processed at the start
> of the org-mobile-push function before the checks? That way it can be
> used to properly setup mobile e.g using auth-source for the mobile
> password.

This trivial patch will perhaps do.  I'm not using org-mobile.el so
please let me know if there are any side-effects.

Thanks,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-mobile.el.patch --]
[-- Type: text/x-patch, Size: 612 bytes --]

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 5471734..ffdd92c 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -305,9 +305,9 @@ create all custom agenda views, for upload to the mobile phone."
 	  (org-agenda-redo-command org-agenda-redo-command))
       (save-excursion
 	(save-window-excursion
+	  (run-hooks 'org-mobile-pre-push-hook)
 	  (org-mobile-check-setup)
 	  (org-mobile-prepare-file-lists)
-	  (run-hooks 'org-mobile-pre-push-hook)
 	  (message "Creating agendas...")
 	  (let ((inhibit-redisplay t)) (org-mobile-create-sumo-agenda))
 	  (message "Creating agendas...done")

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

[Accepted] org mobile - pre hooks

[Carsten Dominik]

Patch 654 (http://patchwork.newartisans.com/patch/654/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C87tyfhf6gr.fsf%40gnu.org%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] org mobile - pre hooks
> Date: Sun, 06 Mar 2011 04:17:08 -0000
> From: Bastien Guerry <bzg@altern.org>
> X-Patchwork-Id: 654
> Message-Id: <87tyfhf6gr.fsf@gnu.org>
> To: Richard Riley <rileyrg@googlemail.com>
> Cc: Emacs-orgmode mailing list <emacs-orgmode@gnu.org>
> 
> Hi Richard,
> 
> Richard Riley <rileyrg@googlemail.com> writes:
> 
> > Could I suggest that org-mobile-pre-push-hook is processed at the start
> > of the org-mobile-push function before the checks? That way it can be
> > used to properly setup mobile e.g using auth-source for the mobile
> > password.
> 
> This trivial patch will perhaps do.  I'm not using org-mobile.el so
> please let me know if there are any side-effects.
> 
> Thanks,
> 
> 
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index 5471734..ffdd92c 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -305,9 +305,9 @@ create all custom agenda views, for upload to the mobile phone."
>  	  (org-agenda-redo-command org-agenda-redo-command))
>        (save-excursion
>  	(save-window-excursion
> +	  (run-hooks 'org-mobile-pre-push-hook)
>  	  (org-mobile-check-setup)
>  	  (org-mobile-prepare-file-lists)
> -	  (run-hooks 'org-mobile-pre-push-hook)
>  	  (message "Creating agendas...")
>  	  (let ((inhibit-redisplay t)) (org-mobile-create-sumo-agenda))
>  	  (message "Creating agendas...done")
>