bug#16748: restoring a frameset duplicates existing frames

bug#16748: restoring a frameset duplicates existing frames

[Glenn Morris]

Package: emacs
Version: 24.3.50

Current trunk on GNU/Linux under X:

emacs -Q
C-x C-f 1
M-x make-frame
C-x C-f 2
;; Now we have two frames, one visiting "1", the other "2".
;; Save to register "a":
C-x r f a

M-x make-frame
C-x C-f 3

C-x r j a

This iconifies the existing frames 1, 2, 3, and creates new frames
visiting 1 and 2. These are identical to the ones that previously
existed, so why did it create new copies?
M-x frame-configuration-to-register does not duplicate existing frames
in this way, it simply iconifies frame 3.

bug#16748: restoring a frameset duplicates existing frames

[Juanma Barranquero]

On Fri, Feb 14, 2014 at 7:33 AM, Glenn Morris <rgm@gnu.org> wrote:

> This iconifies the existing frames 1, 2, 3, and creates new frames
> visiting 1 and 2. These are identical to the ones that previously
> existed, so why did it create new copies?
>
> M-x frame-configuration-to-register does not duplicate existing frames
> in this way, it simply iconifies frame 3.

It was an attempt to be compatible with f-c-t-r, though it is
impossible to be identical because f-c-t-r does not recreate deleted
frames. Currently, if you use the prefix,
frame-configuration-to-register does not duplicate frames, it reuses
the existing ones.

Honestly, I do not like the current behavior and would prefer to
switch the meaning of Ctrl-U.

    J

bug#16748: restoring a frameset duplicates existing frames

[Juanma Barranquero]

On Fri, Feb 14, 2014 at 2:26 PM, Juanma Barranquero <lekktu@gmail.com> wrote:

> Currently, if you use the prefix,
> frame-configuration-to-register does not duplicate frames, it reuses
> the existing ones.

and deletes any one remaining that is not restored.

frameset-save/restore supports many options related to which frames to
restore and which ones to keep (look at the docstring of
`frameset-restore'), so we can adapt frameset-to-register to whatever
behavior we want, once it is clearly defined. At most it would mean
passing some more info to registerv-make.

   J

bug#16748: restoring a frameset duplicates existing frames

[Juanma Barranquero]

On Fri, Feb 14, 2014 at 2:31 PM, Juanma Barranquero <lekktu@gmail.com> wrote:

> we can adapt frameset-to-register to whatever
> behavior we want, once it is clearly defined.

After giving it some thought, I think you're right, jump-to-frameset
should be more aggressive reusing frames even when DELETE is nil.

After all, in 24.3

  C-x r f a
  C-x r j a

gives just one frame, while you get two in 24.3.50. I'll fix it.

    J

bug#16748: restoring a frameset duplicates existing frames

[Juanma Barranquero]

I've committed a change that I think fixes it. Please try and report
any additional trouble.

There's a bug that I'm hitting with

emacs -Q
C-x 3
C-x r f a
C-x 5 2
C-x r j a

=> "Error (frameset): #<window 6> is not a live window"

but it happens inside window-state-put and I think is unrelated to this one.

bug#16748: restoring a frameset duplicates existing frames

[Glenn Morris]

Thanks, works for me.