* ^M in compilation buffers
@ 2009-02-17 16:16 Sam Steingold
2009-02-17 16:46 ` Sam Steingold
2009-02-17 18:33 ` Stefan Monnier
0 siblings, 2 replies; 7+ messages in thread
From: Sam Steingold @ 2009-02-17 16:16 UTC (permalink / raw
To: emacs-devel
Hi,
omake prints progress bar using the usual ^M terminal trick.
last week it was parsed nicely by emacs, i.e., the progress bar was updated
in-place and, eventually, overwritten (by the last omake message).
today, the freshly compiled cvs head emacs does not do that: the ^M character
is inserted into the *compilation* buffer as is (instead of being interpreted
as C-a C-k):
[=== ] 01358 / 11812^M [====== ] 02995 /
11837^M [====== ] 03039 / 11837^M [====== ] 03244
/ 11849^M [====== ] 03337 / 11849^M [====== ]
03428 / 11849^M [====== ] 03502 / 11849^M [=======
] 03598 / 11849^M [======= ] 03659 / 11849^M [=======
] 03692 / ....
any advice?
Thanks
Sam.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ^M in compilation buffers
2009-02-17 16:16 ^M in compilation buffers Sam Steingold
@ 2009-02-17 16:46 ` Sam Steingold
2009-02-17 18:33 ` Stefan Monnier
1 sibling, 0 replies; 7+ messages in thread
From: Sam Steingold @ 2009-02-17 16:46 UTC (permalink / raw
Cc: emacs-devel
Sam Steingold wrote:
> omake prints progress bar using the usual ^M terminal trick.
> last week it was parsed nicely by emacs, i.e., the progress bar was
> updated in-place and, eventually, overwritten (by the last omake message).
> today, the freshly compiled cvs head emacs does not do that: the ^M
> character is inserted into the *compilation* buffer as is (instead of
> being interpreted as C-a C-k):
> [=== ] 01358 / 11812^M [====== ] 02995
> / 11837^M [====== ] 03039 / 11837^M
> [====== ] 03244 / 11849^M [====== ] 03337
> / 11849^M [====== ] 03428 / 11849^M
> [====== ] 03502 / 11849^M [======= ] 03598 / 11849^M
> [======= ] 03659 / 11849^M [======= ] 03692 / ....
this patch fixes *compilation*:
--- compile.el.~1.485.~ 2009-01-05 16:47:34.000000000 -0500
+++ compile.el 2009-02-17 11:31:48.001949000 -0500
@@ -1739,6 +1739,8 @@ Just inserts the text, and runs `compila
;; point at `process-mark' scroll along with the output, but we
;; now use window-point-insertion-type instead.
(insert string)
+ (unless comint-inhibit-carriage-motion
+ (comint-carriage-motion (process-mark proc) (point)))
(set-marker (process-mark proc) (point))
(run-hooks 'compilation-filter-hook))
(goto-char pos))))))
alas, this cannot be done from within compilation-filter-hook because
(process-mark proc) is overwritten before compilation-filter-hook is called.
(also, comint.el calls comint-carriage-motion from comint-output-filter, not a
hook).
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ^M in compilation buffers
2009-02-17 16:16 ^M in compilation buffers Sam Steingold
2009-02-17 16:46 ` Sam Steingold
@ 2009-02-17 18:33 ` Stefan Monnier
2009-02-17 19:49 ` Sam Steingold
1 sibling, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2009-02-17 18:33 UTC (permalink / raw
To: Sam Steingold; +Cc: emacs-devel
> omake prints progress bar using the usual ^M terminal trick.
> last week it was parsed nicely by emacs, i.e., the progress bar was updated
> in-place and, eventually, overwritten (by the last omake message).
Are you sure it was parsed nicely last week in compilation-mode?
I see no related changes to compile.el.
AFAIK this has never worked in compilation mode, only in comint-mode.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ^M in compilation buffers
2009-02-17 18:33 ` Stefan Monnier
@ 2009-02-17 19:49 ` Sam Steingold
2009-02-18 1:51 ` Stefan Monnier
2009-02-18 5:13 ` Glenn Morris
0 siblings, 2 replies; 7+ messages in thread
From: Sam Steingold @ 2009-02-17 19:49 UTC (permalink / raw
To: Stefan Monnier; +Cc: emacs-devel
On Tue, Feb 17, 2009 at 1:33 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> omake prints progress bar using the usual ^M terminal trick.
>> last week it was parsed nicely by emacs, i.e., the progress bar was updated
>> in-place and, eventually, overwritten (by the last omake message).
>
> Are you sure it was parsed nicely last week in compilation-mode?
I think so.
> I see no related changes to compile.el.
me neither.
> AFAIK this has never worked in compilation mode, only in comint-mode.
well, now that I fixed that, it works for me in compilation mode too.
--
Sam Steingold <http://sds.podval.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ^M in compilation buffers
2009-02-17 19:49 ` Sam Steingold
@ 2009-02-18 1:51 ` Stefan Monnier
2009-02-18 5:13 ` Glenn Morris
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2009-02-18 1:51 UTC (permalink / raw
To: Sam Steingold; +Cc: emacs-devel
>>> omake prints progress bar using the usual ^M terminal trick.
>>> last week it was parsed nicely by emacs, i.e., the progress bar was updated
>>> in-place and, eventually, overwritten (by the last omake message).
>> Are you sure it was parsed nicely last week in compilation-mode?
> I think so.
>> I see no related changes to compile.el.
> me neither.
>> AFAIK this has never worked in compilation mode, only in comint-mode.
> well, now that I fixed that, it works for me in compilation mode too.
Yes, I think the change is good, but I just want to make sure we
understand what's going on.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ^M in compilation buffers
2009-02-17 19:49 ` Sam Steingold
2009-02-18 1:51 ` Stefan Monnier
@ 2009-02-18 5:13 ` Glenn Morris
2009-02-18 15:39 ` Sam Steingold
1 sibling, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2009-02-18 5:13 UTC (permalink / raw
To: Sam Steingold; +Cc: Stefan Monnier, emacs-devel
Sam Steingold wrote:
> well, now that I fixed that, it works for me in compilation mode too.
In compilation-filter:
compile.el:1744:23:Warning: reference to free variable
`comint-inhibit-carriage-motion'
In end of data:
compile.el:2352:1:Warning: the function `comint-carriage-motion' is
not known to be defined.
cd etc/refcards
emacs -Q
M-x compile make -k cs-dired-ref.pdf RET ; without using tab completion
error in process filter: unless: Symbol's value as variable is void: comint-inhibit-carriage-motion
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ^M in compilation buffers
2009-02-18 5:13 ` Glenn Morris
@ 2009-02-18 15:39 ` Sam Steingold
0 siblings, 0 replies; 7+ messages in thread
From: Sam Steingold @ 2009-02-18 15:39 UTC (permalink / raw
To: Glenn Morris; +Cc: Stefan Monnier, emacs-devel
On Wed, Feb 18, 2009 at 12:13 AM, Glenn Morris <rgm@gnu.org> wrote:
> Sam Steingold wrote:
>
>> well, now that I fixed that, it works for me in compilation mode too.
>
> In compilation-filter:
> compile.el:1744:23:Warning: reference to free variable
> `comint-inhibit-carriage-motion'
>
> In end of data:
> compile.el:2352:1:Warning: the function `comint-carriage-motion' is
> not known to be defined.
>
>
> cd etc/refcards
>
> emacs -Q
>
> M-x compile make -k cs-dired-ref.pdf RET ; without using tab completion
>
> error in process filter: unless: Symbol's value as variable is void: comint-inhibit-carriage-motion
>
fixed in the cvs.
thanks.
--
Sam Steingold <http://sds.podval.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-02-18 15:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-17 16:16 ^M in compilation buffers Sam Steingold
2009-02-17 16:46 ` Sam Steingold
2009-02-17 18:33 ` Stefan Monnier
2009-02-17 19:49 ` Sam Steingold
2009-02-18 1:51 ` Stefan Monnier
2009-02-18 5:13 ` Glenn Morris
2009-02-18 15:39 ` Sam Steingold
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.