From: Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: xiliuya <xiliuya@aliyun.com>
Cc: "Eli Zaretskii" <eliz@gnu.org>,
"João Távora" <joaotavora@gmail.com>,
62795@debbugs.gnu.org
Subject: bug#62795: 29.0.90; eglot: gdscript default port is 6005
Date: Mon, 17 Apr 2023 15:33:40 +0800 [thread overview]
Message-ID: <sdvleirufmz.fsf@netyu.xyz> (raw)
In-Reply-To: <87h6tg3sne.fsf@aliyun.com>
xiliuya via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> writes:
> I have modified it according to your suggestion, is that OK?
> I tested it locally and it works.
>
> ```emacs-lisp
> (defun gdscript-eglot-contact (&optional _interactive)
> "Produce a suitable value for LSP contact in `eglot-server-programs'."
> (list "localhost"
> (string-to-number
> (with-temp-buffer
> (insert-file-contents
> (expand-file-name "~/.config/godot/editor_settings-4.tres"))
> (goto-char (point-min))
> (goto-char (+ 39 (string-match
> "network/language_server/remote_port"
> (buffer-string))))
> (buffer-substring
> (point)
> (line-end-position))))))
> ```
>
>> If the function is made simple enough and portable across operating
>> systems where the Godot engine runs, then a lambda version of it can be
>> added to eglot.el IMO. But it's really better to add it to
>> gdscript-mode.el, wherever it is maintained.
>>
>> João
>
> I submitted this question to the gdscript-mode codebase, but haven't
> heard back yet.
> [issues/121](https://github.com/godotengine/emacs-gdscript-mode/issues/121)
I'll try to file a PR in that repo for this function within a few hours,
will send an update to this thread when done.
--
Best,
RY
next prev parent reply other threads:[~2023-04-17 7:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 10:33 bug#62795: 29.0.90; eglot: gdscript default port is 6005 xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 8:07 ` Eli Zaretskii
2023-04-15 8:17 ` João Távora
2023-04-15 12:19 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 13:13 ` João Távora
2023-04-15 13:28 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 14:04 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 3:48 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 5:49 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 6:16 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 7:36 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 8:57 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:08 ` João Távora
2023-04-16 12:29 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 7:33 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-04-17 8:43 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 13:22 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:16 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sdvleirufmz.fsf@netyu.xyz \
--to=bug-gnu-emacs@gnu.org \
--cc=62795@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=ruijie@netyu.xyz \
--cc=xiliuya@aliyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.